From: Ming Lei <ming.lei@redhat.com>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
damien.lemoal@wdc.com, jiangguoqing@kylinos.cn,
shinichiro.kawasaki@wdc.com
Subject: Re: [PATCH V2 1/1] blk-lib: don't check bdev_get_queue() NULL check
Date: Tue, 15 Feb 2022 20:02:17 +0800 [thread overview]
Message-ID: <YguWSd90b3Sb2Ptv@T590> (raw)
In-Reply-To: <20220215115247.11717-2-kch@nvidia.com>
On Tue, Feb 15, 2022 at 03:52:47AM -0800, Chaitanya Kulkarni wrote:
> Based on the comment present in the bdev_get_queue()
> bdev->bd_queue can never be NULL. Remove the NULL check for the local
> variable q that is set from bdev_get_queue() for discard, write_same,
> and write_zeroes.
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Looks fine,
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
next prev parent reply other threads:[~2022-02-15 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 11:52 [PATCH V2 0/1] blk-lib: cleanup bdev_get_queue() Chaitanya Kulkarni
2022-02-15 11:52 ` [PATCH V2 1/1] blk-lib: don't check bdev_get_queue() NULL check Chaitanya Kulkarni
2022-02-15 12:02 ` Ming Lei [this message]
2022-02-15 14:51 ` [PATCH V2 0/1] blk-lib: cleanup bdev_get_queue() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YguWSd90b3Sb2Ptv@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=jiangguoqing@kylinos.cn \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.