From: Cyril Hrubis <chrubis@suse.cz>
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] lib/tst_memutils.c: Fix resource leak
Date: Tue, 15 Feb 2022 14:04:42 +0100 [thread overview]
Message-ID: <Yguk6nhRcd863ia+@yuki> (raw)
In-Reply-To: <20220211152751.4651-1-bogdan.lezhepekov@suse.com>
Hi!
> diff --git a/lib/tst_memutils.c b/lib/tst_memutils.c
> index 4a4974761..2e6d7d5fd 100644
> --- a/lib/tst_memutils.c
> +++ b/lib/tst_memutils.c
> @@ -122,7 +122,10 @@ static int write_score(const char *path, int score)
> return 1;
>
> if (fprintf(f, "%d", score) <= 0)
> + {
> + fclose(f);
> return 1;
> + }
The coding style is wrong. Please run 'make check' in the respective
directory when the source code located and fix all warnings.
> if (fclose(f))
> return 1;
> --
> 2.35.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-02-15 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 15:27 [LTP] [PATCH v1] lib/tst_memutils.c: Fix resource leak Bogdan Lezhepekov via ltp
2022-02-15 13:04 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yguk6nhRcd863ia+@yuki \
--to=chrubis@suse.cz \
--cc=bogdan.lezhepekov@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.