From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4316AC433EF for ; Tue, 15 Feb 2022 15:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239440AbiBOPBg (ORCPT ); Tue, 15 Feb 2022 10:01:36 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233597AbiBOPBe (ORCPT ); Tue, 15 Feb 2022 10:01:34 -0500 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20721.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::721]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECB0283; Tue, 15 Feb 2022 07:01:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkTUZOH6tWUH7zk4JOUDmZY6ZDfd71a844EpdSu4YGf+bbvBwjLZzDwd0/PZxjqRgsAUoRkRCIFRboP937ypFY0WyZfy422wSO5EzvDfagnK/0r1otB1OokJY2zeRCjCd3EguykyYKD1+BRaHQUs7vWEUNF8C8cWUxX9++ASj9bwoYnoSSJ4o8qctuPIGxExLRvi/FVEOdyoGTTcX/Wlnjbg4TmQcYUSb7VGBTZXp6qhCeUXc5e59S1+JkZEPGfP2p2XnZbvLT+uYYC8L/Z0Rpn5bdYxb5eLGrQghBq0fPKks8Qx4fw5RpW2Ps7bnpYqd6aMgYSd8Y+8AkQBFf0CDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vaC6fjee2qozoeib4sQ6xWlEnDHNrmpbnJf91q6Ykk8=; b=JBIDFQjRA7vmlyM7gfPu6g0qMD38mvuf4GwZ+tN5P8Docch3AYakkWHPt1NTIQuA1ceU7k/2dJZj/4Cr4Y6TwtS0zBZ5zgy/yTxRbrof4TEtIZdZl2DooEhjCk6KwdPqGRrf3l3uAS5za1xzd0anV0orrtfdLRqc2OlJQ/JeTzaEJ1bNwzQFoWyXE/Q8pL17d44nOlGnrnXvykLVlOMQpq8w7mUgWoVGFR6Wv25U60kWPQUfUacV8g71Mv4j4FVQ5uFfoxpgpvyUgQHccMHtDEL304ukPfqkWLcmgWKxczNvAPXgxZ55e8zf8BdsAbQgf8AFgr5FH6ESM37eEtFFrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vaC6fjee2qozoeib4sQ6xWlEnDHNrmpbnJf91q6Ykk8=; b=vg1QqQs6J6aLEL1x6EDa6RcGbA21+aYEyb08PUrxUUZA0Y2ek8J5sD709vIzDxuUMtgh/9gbPxY9LsmKJwVfLzTyGSCAznX95OKSCMnhmP2wSIFqW/j/I5JpBqLFsltWR+oCDPXnxh+cAuGjGDEmsG9BMxbAjF+dg83/e0FYsHg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from DU2PR07MB8110.eurprd07.prod.outlook.com (2603:10a6:10:239::15) by DU2PR07MB8149.eurprd07.prod.outlook.com (2603:10a6:10:272::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.13; Tue, 15 Feb 2022 15:01:20 +0000 Received: from DU2PR07MB8110.eurprd07.prod.outlook.com ([fe80::5162:f984:3822:5b7b]) by DU2PR07MB8110.eurprd07.prod.outlook.com ([fe80::5162:f984:3822:5b7b%3]) with mapi id 15.20.4975.011; Tue, 15 Feb 2022 15:01:20 +0000 Date: Tue, 15 Feb 2022 16:01:15 +0100 From: Krzysztof Adamski To: Guenter Roeck Cc: Alexander Sverdlin , Mark Rutland , Ard Biesheuvel , Catalin Marinas , Will Deacon , Peter Collingbourne , Wolfram Sang , Matija Glavinic-Pecotic , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v2] arm64: move efi_reboot to restart handler Message-ID: References: <79bcce92-abb2-4c3e-7193-d18e144da8a0@nokia.com> <489b76f9-fbaf-dae0-c90d-c52ee0de92a4@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <489b76f9-fbaf-dae0-c90d-c52ee0de92a4@roeck-us.net> X-ClientProxiedBy: HE1PR07CA0046.eurprd07.prod.outlook.com (2603:10a6:7:66::32) To DU2PR07MB8110.eurprd07.prod.outlook.com (2603:10a6:10:239::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a922f2e-6194-43d6-3148-08d9f094065a X-MS-TrafficTypeDiagnostic: DU2PR07MB8149:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o81lRXfw+Z2gSeoHORbp1Kc5VQt8mdPaWpaZfsUq0zUxk8pgL6xZeEzf7wHhOSSm0Nz0yEClD9FxtahbyCqK7aKV1l9TudJbCwAgiJFBRMBm5gCnMs0gkFdcd4GoyFDuRARnORnmojwnEm65hbnHsQrHiWWsMinJ85UlJHVKZM08Zfp3I9dPZtzbmpAnswVE4W1VsorUHifp/kW7bbZC0Yi4BHxw1LOnY4TiWB0aphSBIwd5yk9OWmrm6K2E4y3H8LW/J/5VEOepSSI79gZYzineGhPt679ZEOO9DlxVRkqW/ic+IV5N2PM0EUhoh77mvq359IP3JORO6gl7Fn5C0bvKc5PsioX43sWfaRffMQeB+tTIuVKJ6f+Gu4RrjoP/y7s0EjJHsauxMutPmQsXGsiEFry9E4uypcK4QrGq3YguCBXgkItsUrZ+Gz7hQkSBee9+Y/wbsXPLmb8rqUlMY0cy3uKzOzOZnrQq7aJfcw+PLuuQ88s7oxf6HGv51lRGcPO0Ce5fKefeB4ToIuc4p0IrDOxmuFPDzY3zfghqgDCTIvrDpkeC4kVGE8NXu/VGLnMbIJAKxQW3HArOt7E+8NskB9lTFYntj+0kHxybEJcE7GzrLBEx02MMIpaSYj8xx94zAYp5m0fTLj+jSKyufQqtYo3HLQHFP7L4hjZREzuJkmhZ5UT8G1+pW4cPZfL3D5lHlWRrQw7o6Atg86EnEFz/Es/cp0A+u4RVO4KdMOrYa9/Oi7dWII9MG/Aoz7+7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR07MB8110.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(6506007)(186003)(26005)(38100700002)(8936002)(44832011)(52116002)(7416002)(2906002)(82960400001)(9686003)(6512007)(38350700002)(8676002)(6666004)(66556008)(66946007)(316002)(66476007)(508600001)(6486002)(54906003)(6916009)(4326008)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk8rdGNSMDRUZVhESFBOYWJ2bzhwVjNybndrQyttYldGZ1N2T2dNOHUwSUZx?= =?utf-8?B?TzhRdFdCaW1Xano3eTQ5ejJFaXdvQ3FuNDdFOXJ3TTJZZHV2ODJTUUdqZXlq?= =?utf-8?B?aGdSaXIzYTJGN3NOd1hhaUhPcFBvYTVjcnFSakVjcEVmQmoyR1hCUS84bWxt?= =?utf-8?B?RE56ZlJPeDZIRHUwOGJabHJPUE5vTWJ1ZVY5eGNpTnZ0L1ltTjJlWlBIYmMw?= =?utf-8?B?ejhCYUFURUZKWjZCL3c1Lzc3NzR6OGFXNVFFb2srQ1FtMi9wamg3RGxabGY2?= =?utf-8?B?d21WZk55L1dqbDJRdk4xakhjWWZlcmw1d0RhaStRSXU4YlQzc1BLSWhCbXp0?= =?utf-8?B?d0pCWDlZUExYNlcrS1JySFZ3b1R6M2tDbmErMDdZWUZid0NUQlpyYWIrMlhv?= =?utf-8?B?NTAyTkZ6QXgvRElSSGp5UUx2dGlqVGNKREJ2UGdEZDhpbjMxVmduV1dkenJ6?= =?utf-8?B?alVlNzRPUHNNcjhrMG8rVS9CZ1d3SGlzOXhzRCtKRjJJY1NWOHBjWkIwQmRW?= =?utf-8?B?b01tTDllWUtYUGN5UThoOW82Qi9qaWFhRzBCQ1NwVUhaRytWWEVuOE4zbW5C?= =?utf-8?B?SlIzL3BCeFRiU3hJTmtpdjVLUnZNVDZkNmpzdGVicGdMaGtwTVRvb2R1SjRU?= =?utf-8?B?aEhwTktkUjJmeVZQR0VqZlJLc3ptRERVeEEzT1k2ZmFKbVV2a2hmMm1PMGkz?= =?utf-8?B?NzhUY3NhemdjOVRTSGdHZVo2dWQ3aVEzNFFteUtNZmxRRmJ6TkRERlpCa3VC?= =?utf-8?B?R2xTbWY5TW9OUEluR2kvRXBUbTNreXFFVW5ORzdmcGNaWFQxc2pzRGhqcTd1?= =?utf-8?B?b3JWcHgwZDZzc2g2aitkNzRQSmxVWjhsdkxtRVpjZnlCVGhnWVRYTUhXd1gw?= =?utf-8?B?eGwyTzFXcGxaQXdvNUdiV01ERVJhS2R6eC9oa0ZIUC9FMmI2QkhDTVMvdjhx?= =?utf-8?B?MEtVV2l5Sko4bGRBYnBEaDVNc1paeC91cUJoSlM4YlBYOXZ1aE13a0pXeEsz?= =?utf-8?B?eWg5c0VPdWpFWVFoZHUvZm9sTnlUSTlTREpteDM3dHdIYlpWUUd1NlBlSytT?= =?utf-8?B?cXFweUxWclRWRUR1R3JEK0xLaHEza3dMU3ZXeG9uTTMyRWNjejRtZ25scWxh?= =?utf-8?B?bHhPTHpleWxJZkMxRGgvR1RRUmt5SUNEd2FtT0R0ZXVGL1I2MXVNQzRXdlND?= =?utf-8?B?SjdnaGs4d2dEblA2Mm1TYTY2Sytnd2Vrb0xxc3d4UWVITlQ4c0tyb1pZeCtE?= =?utf-8?B?SVh6WlRGUHNtSEgzcWVmQ1k5MlVsRG9xRVc3MzIwc3lHQVd0ZVBjcm1pYnlH?= =?utf-8?B?OHl3UllKYStnellSQUthY3FpMVZuZkVncXRXanpKL3dtTlZTTDdmb1B1Zmhr?= =?utf-8?B?YU1mbnRxRkYwM09PSEUxeGdYazB0ZHdYMmlYWVBLemFSb3J0SmRTU2o5aFRP?= =?utf-8?B?ZVZSTzRGMGZkbXFoSldESnhsZHpUOE41L3MzYXM2UXpBT3I4OVRZK1ZKdVlT?= =?utf-8?B?YlhOR1Bpb3c0MGVjSzBiNmpQVE5rQlBQNE9kQ2o0MnFiSjBWdHhQTXRxK3VG?= =?utf-8?B?elBOQXNXbmU2M042eDBnd3M4ZWNidlpxM1NkcHBLbDVQSVN5eHZORE44ZnBx?= =?utf-8?B?bHRSOGp1Q1lVSTF4RlZNdDhaY29Bc1pSZXloczVQMldJOVdwOTBIQm9lQlF3?= =?utf-8?B?VFdRRmt5eFp1M1BmU2J3dkdoZFI1VmYyRzhNK1FiL1QwcmVKWEd3L1ZFSWQ1?= =?utf-8?B?Ymo0eEVvMlJQL016UmpxQU5JUWhNa2NNVUpsTWdRaEZyeEtnNEdKNlRLbGNh?= =?utf-8?B?SDRpVEFsbWtDY0tQRk5MWkxUUHpVQWsxTEc4djR5SVEzMGU1THFiVnJHVnEw?= =?utf-8?B?TE5DM1JRUDVpbitVdWllMnN0S09vREpjajlPOU9MSTM2bmxvSEwyRExteWhY?= =?utf-8?B?VzZrYjB0MTFaRmM3NVVsZXFvR1dpblRzMENySmNNcWJWZzNyNmdFWk5zbnZ3?= =?utf-8?B?U212eERDbDc0b3JiNDdWelV5MkRDNDlrRUV6QzVKL3pFcXdHazh0cDRwWWRu?= =?utf-8?B?ZW1kamwwcTZ6Zk0wZFcvN1d6T2Z6ako3WC9mNUFuS3puYWJOYmwxay9QSGs5?= =?utf-8?B?ZGZVdE1nSHNVY3o4WDBENk5rSElsWnZqdXorcHpZSzdCU2RvaTVybjVmeFU2?= =?utf-8?B?Zm94ajhjekI2c1ZmdDQveGtYYkVqdmpNTEt2L1AxR0Q5TVcvZkY2aXBWQ3FY?= =?utf-8?B?QjhJUU91dG5BenkxOEZnZ1NZNlhBPT0=?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a922f2e-6194-43d6-3148-08d9f094065a X-MS-Exchange-CrossTenant-AuthSource: DU2PR07MB8110.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:01:20.4379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KLpxl+WnrXmEcch16zA4VSpSqvVbIZYruRxtYwRczZb6M0taMm1jEhC5gKVJxCiDGJd3xH4NvTJ1jfp91N8H+Up3zU1ePorzLKVLXmZboVY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR07MB8149 Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Dnia Tue, Feb 15, 2022 at 06:30:26AM -0800, Guenter Roeck napisał(a): >On 2/15/22 00:44, Alexander Sverdlin wrote: >>Hello Mark, Ard, >> >>On 01/02/2022 14:58, Mark Rutland wrote: >>>>You could argue that restart handlers were not created for that but they >>>>suit this purpose ideally and it wouldn't make much sense (in my >>>>opinion) to add yet another notifier chain that would run before reset >>>>notifiers, for code that is not supposed to reset the whole system and >>>>this is exacly what I would have to do if efi_reboot() is forced to be >>>>called before all handlers. >>> >>>As above, I think that's just using the wrong interface, and the reboot >>>notifier mechanism *already* exists, so I'm really confused here. >>> >>>Have I misunderstood what you're trying to achieve? >>> >>>Is there some problem with the reboot notifier mechanism that I am unaware of? >>>e.g. do we bypass them in some case where you think they're needed? >>> >>>Are you simply unaware of reboot notifiers? >> >>Could you please check the simple case of pwrseq_emmc.c? >> >>While that's currently the only example of this kind upstream I can imagine >>further use-cases, especially in storage area like above. >> >>Would you suggest it's illegal usage of register_restart_handler()? >>Do we need to fix pwrseq_emmc.c by introducing new atomic notifier chain >>which will be called before restart handlers, so that it works on >>emergency_restart()? >> > >Abuse isn't just about using an API for something it isn't originally intended >for, abuse is also to intentionally _not_ use an API, as it is currently done >by the EFI restart code for arm64. Also, keep in mind that the same argument >(our restart handler _must_ be executed under all circumstances and does therefore >not use the restart API) is likely going to be used again in the future. All >it takes is for some other standard (or chip vendor, for that matter) to declare >their restart handler mandatory if present. Wait, but it is up to us to decide if we want to follow such standard or not. If we want to have code that is more flexible, nobody can refuse us to do so, right? None of the standards says that we can't support restart handlers in case of EFI on ARM64, it was decided by kernel developers, not some vendors. We can change that. >Given that, I'd suggest to cut your losses and try to find another >solution for your problem. That may be to introduce yet another API, >one that is called before the EFI restart handling but that is always >called, unlike reboot notifiers, or simply stick with out-of-tree code. Sure I could create yet another API like you suggest but in practice it would be a copy of existing API as i would have to work exactly the same - would be called at the same time in the same situations. The only thing that would be different would be separate chain. But if we want to prevent registering some custom code to be run before efi_reboot(), that new API would have to be rejected as well, for the same reason. So what is the point? Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 401C6C433F5 for ; Tue, 15 Feb 2022 15:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ymbVmTGDr0R26aw6/Te026Zh41gkJ+UCxzNA4/Jqqks=; b=EvQbKdsmlGxZ6CEp6NVhBB1eJl a+kDNX2gdevMycgHq8HZHIy7YqK46IWlPDcSG/ef+Ni2f4TLFtbIG6ZFaHooa3lEeM54EcT16llu1 xjQUG7re8/uRDymgAiffGTA2rhMkAK6CxM+9Na5OFblhmVNmLyVwTkbxEHR3e3CLcx67760evzEUu MfIzac0+M8C0xbi0tFpzXEWAcYFZ9eV58EmpiUjP1OR5RAx52HxzaA4UQLFoarkTCgsrOzikYLuCi h25sHHIh30z/3UIH58sfWK60Z1VOpH7jmeVTaP6HMtTPNc9mv7JDSLx/KqbwqebO1GkQuuc7mGcLS 4xMMHJ/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJzKc-003A7c-4q; Tue, 15 Feb 2022 15:01:30 +0000 Received: from mail-vi1eur05on2071b.outbound.protection.outlook.com ([2a01:111:f400:7d00::71b] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJzKY-003A6l-0g for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 15:01:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkTUZOH6tWUH7zk4JOUDmZY6ZDfd71a844EpdSu4YGf+bbvBwjLZzDwd0/PZxjqRgsAUoRkRCIFRboP937ypFY0WyZfy422wSO5EzvDfagnK/0r1otB1OokJY2zeRCjCd3EguykyYKD1+BRaHQUs7vWEUNF8C8cWUxX9++ASj9bwoYnoSSJ4o8qctuPIGxExLRvi/FVEOdyoGTTcX/Wlnjbg4TmQcYUSb7VGBTZXp6qhCeUXc5e59S1+JkZEPGfP2p2XnZbvLT+uYYC8L/Z0Rpn5bdYxb5eLGrQghBq0fPKks8Qx4fw5RpW2Ps7bnpYqd6aMgYSd8Y+8AkQBFf0CDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vaC6fjee2qozoeib4sQ6xWlEnDHNrmpbnJf91q6Ykk8=; b=JBIDFQjRA7vmlyM7gfPu6g0qMD38mvuf4GwZ+tN5P8Docch3AYakkWHPt1NTIQuA1ceU7k/2dJZj/4Cr4Y6TwtS0zBZ5zgy/yTxRbrof4TEtIZdZl2DooEhjCk6KwdPqGRrf3l3uAS5za1xzd0anV0orrtfdLRqc2OlJQ/JeTzaEJ1bNwzQFoWyXE/Q8pL17d44nOlGnrnXvykLVlOMQpq8w7mUgWoVGFR6Wv25U60kWPQUfUacV8g71Mv4j4FVQ5uFfoxpgpvyUgQHccMHtDEL304ukPfqkWLcmgWKxczNvAPXgxZ55e8zf8BdsAbQgf8AFgr5FH6ESM37eEtFFrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vaC6fjee2qozoeib4sQ6xWlEnDHNrmpbnJf91q6Ykk8=; b=vg1QqQs6J6aLEL1x6EDa6RcGbA21+aYEyb08PUrxUUZA0Y2ek8J5sD709vIzDxuUMtgh/9gbPxY9LsmKJwVfLzTyGSCAznX95OKSCMnhmP2wSIFqW/j/I5JpBqLFsltWR+oCDPXnxh+cAuGjGDEmsG9BMxbAjF+dg83/e0FYsHg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from DU2PR07MB8110.eurprd07.prod.outlook.com (2603:10a6:10:239::15) by DU2PR07MB8149.eurprd07.prod.outlook.com (2603:10a6:10:272::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.13; Tue, 15 Feb 2022 15:01:20 +0000 Received: from DU2PR07MB8110.eurprd07.prod.outlook.com ([fe80::5162:f984:3822:5b7b]) by DU2PR07MB8110.eurprd07.prod.outlook.com ([fe80::5162:f984:3822:5b7b%3]) with mapi id 15.20.4975.011; Tue, 15 Feb 2022 15:01:20 +0000 Date: Tue, 15 Feb 2022 16:01:15 +0100 From: Krzysztof Adamski To: Guenter Roeck Cc: Alexander Sverdlin , Mark Rutland , Ard Biesheuvel , Catalin Marinas , Will Deacon , Peter Collingbourne , Wolfram Sang , Matija Glavinic-Pecotic , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v2] arm64: move efi_reboot to restart handler Message-ID: References: <79bcce92-abb2-4c3e-7193-d18e144da8a0@nokia.com> <489b76f9-fbaf-dae0-c90d-c52ee0de92a4@roeck-us.net> Content-Disposition: inline In-Reply-To: <489b76f9-fbaf-dae0-c90d-c52ee0de92a4@roeck-us.net> X-ClientProxiedBy: HE1PR07CA0046.eurprd07.prod.outlook.com (2603:10a6:7:66::32) To DU2PR07MB8110.eurprd07.prod.outlook.com (2603:10a6:10:239::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a922f2e-6194-43d6-3148-08d9f094065a X-MS-TrafficTypeDiagnostic: DU2PR07MB8149:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o81lRXfw+Z2gSeoHORbp1Kc5VQt8mdPaWpaZfsUq0zUxk8pgL6xZeEzf7wHhOSSm0Nz0yEClD9FxtahbyCqK7aKV1l9TudJbCwAgiJFBRMBm5gCnMs0gkFdcd4GoyFDuRARnORnmojwnEm65hbnHsQrHiWWsMinJ85UlJHVKZM08Zfp3I9dPZtzbmpAnswVE4W1VsorUHifp/kW7bbZC0Yi4BHxw1LOnY4TiWB0aphSBIwd5yk9OWmrm6K2E4y3H8LW/J/5VEOepSSI79gZYzineGhPt679ZEOO9DlxVRkqW/ic+IV5N2PM0EUhoh77mvq359IP3JORO6gl7Fn5C0bvKc5PsioX43sWfaRffMQeB+tTIuVKJ6f+Gu4RrjoP/y7s0EjJHsauxMutPmQsXGsiEFry9E4uypcK4QrGq3YguCBXgkItsUrZ+Gz7hQkSBee9+Y/wbsXPLmb8rqUlMY0cy3uKzOzOZnrQq7aJfcw+PLuuQ88s7oxf6HGv51lRGcPO0Ce5fKefeB4ToIuc4p0IrDOxmuFPDzY3zfghqgDCTIvrDpkeC4kVGE8NXu/VGLnMbIJAKxQW3HArOt7E+8NskB9lTFYntj+0kHxybEJcE7GzrLBEx02MMIpaSYj8xx94zAYp5m0fTLj+jSKyufQqtYo3HLQHFP7L4hjZREzuJkmhZ5UT8G1+pW4cPZfL3D5lHlWRrQw7o6Atg86EnEFz/Es/cp0A+u4RVO4KdMOrYa9/Oi7dWII9MG/Aoz7+7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR07MB8110.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(6506007)(186003)(26005)(38100700002)(8936002)(44832011)(52116002)(7416002)(2906002)(82960400001)(9686003)(6512007)(38350700002)(8676002)(6666004)(66556008)(66946007)(316002)(66476007)(508600001)(6486002)(54906003)(6916009)(4326008)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk8rdGNSMDRUZVhESFBOYWJ2bzhwVjNybndrQyttYldGZ1N2T2dNOHUwSUZx?= =?utf-8?B?TzhRdFdCaW1Xano3eTQ5ejJFaXdvQ3FuNDdFOXJ3TTJZZHV2ODJTUUdqZXlq?= =?utf-8?B?aGdSaXIzYTJGN3NOd1hhaUhPcFBvYTVjcnFSakVjcEVmQmoyR1hCUS84bWxt?= =?utf-8?B?RE56ZlJPeDZIRHUwOGJabHJPUE5vTWJ1ZVY5eGNpTnZ0L1ltTjJlWlBIYmMw?= =?utf-8?B?ejhCYUFURUZKWjZCL3c1Lzc3NzR6OGFXNVFFb2srQ1FtMi9wamg3RGxabGY2?= =?utf-8?B?d21WZk55L1dqbDJRdk4xakhjWWZlcmw1d0RhaStRSXU4YlQzc1BLSWhCbXp0?= =?utf-8?B?d0pCWDlZUExYNlcrS1JySFZ3b1R6M2tDbmErMDdZWUZid0NUQlpyYWIrMlhv?= =?utf-8?B?NTAyTkZ6QXgvRElSSGp5UUx2dGlqVGNKREJ2UGdEZDhpbjMxVmduV1dkenJ6?= =?utf-8?B?alVlNzRPUHNNcjhrMG8rVS9CZ1d3SGlzOXhzRCtKRjJJY1NWOHBjWkIwQmRW?= =?utf-8?B?b01tTDllWUtYUGN5UThoOW82Qi9qaWFhRzBCQ1NwVUhaRytWWEVuOE4zbW5C?= =?utf-8?B?SlIzL3BCeFRiU3hJTmtpdjVLUnZNVDZkNmpzdGVicGdMaGtwTVRvb2R1SjRU?= =?utf-8?B?aEhwTktkUjJmeVZQR0VqZlJLc3ptRERVeEEzT1k2ZmFKbVV2a2hmMm1PMGkz?= =?utf-8?B?NzhUY3NhemdjOVRTSGdHZVo2dWQ3aVEzNFFteUtNZmxRRmJ6TkRERlpCa3VC?= =?utf-8?B?R2xTbWY5TW9OUEluR2kvRXBUbTNreXFFVW5ORzdmcGNaWFQxc2pzRGhqcTd1?= =?utf-8?B?b3JWcHgwZDZzc2g2aitkNzRQSmxVWjhsdkxtRVpjZnlCVGhnWVRYTUhXd1gw?= =?utf-8?B?eGwyTzFXcGxaQXdvNUdiV01ERVJhS2R6eC9oa0ZIUC9FMmI2QkhDTVMvdjhx?= =?utf-8?B?MEtVV2l5Sko4bGRBYnBEaDVNc1paeC91cUJoSlM4YlBYOXZ1aE13a0pXeEsz?= =?utf-8?B?eWg5c0VPdWpFWVFoZHUvZm9sTnlUSTlTREpteDM3dHdIYlpWUUd1NlBlSytT?= =?utf-8?B?cXFweUxWclRWRUR1R3JEK0xLaHEza3dMU3ZXeG9uTTMyRWNjejRtZ25scWxh?= =?utf-8?B?bHhPTHpleWxJZkMxRGgvR1RRUmt5SUNEd2FtT0R0ZXVGL1I2MXVNQzRXdlND?= =?utf-8?B?SjdnaGs4d2dEblA2Mm1TYTY2Sytnd2Vrb0xxc3d4UWVITlQ4c0tyb1pZeCtE?= =?utf-8?B?SVh6WlRGUHNtSEgzcWVmQ1k5MlVsRG9xRVc3MzIwc3lHQVd0ZVBjcm1pYnlH?= =?utf-8?B?OHl3UllKYStnellSQUthY3FpMVZuZkVncXRXanpKL3dtTlZTTDdmb1B1Zmhr?= =?utf-8?B?YU1mbnRxRkYwM09PSEUxeGdYazB0ZHdYMmlYWVBLemFSb3J0SmRTU2o5aFRP?= =?utf-8?B?ZVZSTzRGMGZkbXFoSldESnhsZHpUOE41L3MzYXM2UXpBT3I4OVRZK1ZKdVlT?= =?utf-8?B?YlhOR1Bpb3c0MGVjSzBiNmpQVE5rQlBQNE9kQ2o0MnFiSjBWdHhQTXRxK3VG?= =?utf-8?B?elBOQXNXbmU2M042eDBnd3M4ZWNidlpxM1NkcHBLbDVQSVN5eHZORE44ZnBx?= =?utf-8?B?bHRSOGp1Q1lVSTF4RlZNdDhaY29Bc1pSZXloczVQMldJOVdwOTBIQm9lQlF3?= =?utf-8?B?VFdRRmt5eFp1M1BmU2J3dkdoZFI1VmYyRzhNK1FiL1QwcmVKWEd3L1ZFSWQ1?= =?utf-8?B?Ymo0eEVvMlJQL016UmpxQU5JUWhNa2NNVUpsTWdRaEZyeEtnNEdKNlRLbGNh?= =?utf-8?B?SDRpVEFsbWtDY0tQRk5MWkxUUHpVQWsxTEc4djR5SVEzMGU1THFiVnJHVnEw?= =?utf-8?B?TE5DM1JRUDVpbitVdWllMnN0S09vREpjajlPOU9MSTM2bmxvSEwyRExteWhY?= =?utf-8?B?VzZrYjB0MTFaRmM3NVVsZXFvR1dpblRzMENySmNNcWJWZzNyNmdFWk5zbnZ3?= =?utf-8?B?U212eERDbDc0b3JiNDdWelV5MkRDNDlrRUV6QzVKL3pFcXdHazh0cDRwWWRu?= =?utf-8?B?ZW1kamwwcTZ6Zk0wZFcvN1d6T2Z6ako3WC9mNUFuS3puYWJOYmwxay9QSGs5?= =?utf-8?B?ZGZVdE1nSHNVY3o4WDBENk5rSElsWnZqdXorcHpZSzdCU2RvaTVybjVmeFU2?= =?utf-8?B?Zm94ajhjekI2c1ZmdDQveGtYYkVqdmpNTEt2L1AxR0Q5TVcvZkY2aXBWQ3FY?= =?utf-8?B?QjhJUU91dG5BenkxOEZnZ1NZNlhBPT0=?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a922f2e-6194-43d6-3148-08d9f094065a X-MS-Exchange-CrossTenant-AuthSource: DU2PR07MB8110.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:01:20.4379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KLpxl+WnrXmEcch16zA4VSpSqvVbIZYruRxtYwRczZb6M0taMm1jEhC5gKVJxCiDGJd3xH4NvTJ1jfp91N8H+Up3zU1ePorzLKVLXmZboVY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR07MB8149 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_070126_156716_08CF952A X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5pYSBUdWUsIEZlYiAxNSwgMjAyMiBhdCAwNjozMDoyNkFNIC0wODAwLCBHdWVudGVyIFJvZWNr IG5hcGlzYcWCKGEpOgo+T24gMi8xNS8yMiAwMDo0NCwgQWxleGFuZGVyIFN2ZXJkbGluIHdyb3Rl Ogo+PkhlbGxvIE1hcmssIEFyZCwKPj4KPj5PbiAwMS8wMi8yMDIyIDE0OjU4LCBNYXJrIFJ1dGxh bmQgd3JvdGU6Cj4+Pj5Zb3UgY291bGQgYXJndWUgdGhhdCByZXN0YXJ0IGhhbmRsZXJzIHdlcmUg bm90IGNyZWF0ZWQgZm9yIHRoYXQgYnV0IHRoZXkKPj4+PnN1aXQgdGhpcyBwdXJwb3NlIGlkZWFs bHkgYW5kIGl0IHdvdWxkbid0IG1ha2UgbXVjaCBzZW5zZSAoaW4gbXkKPj4+Pm9waW5pb24pIHRv IGFkZCB5ZXQgYW5vdGhlciBub3RpZmllciBjaGFpbiB0aGF0IHdvdWxkIHJ1biBiZWZvcmUgcmVz ZXQKPj4+Pm5vdGlmaWVycywgZm9yIGNvZGUgdGhhdCBpcyBub3Qgc3VwcG9zZWQgdG8gcmVzZXQg dGhlIHdob2xlIHN5c3RlbSBhbmQKPj4+PnRoaXMgaXMgZXhhY2x5IHdoYXQgSSB3b3VsZCBoYXZl IHRvIGRvIGlmIGVmaV9yZWJvb3QoKSBpcyBmb3JjZWQgdG8gYmUKPj4+PmNhbGxlZCBiZWZvcmUg YWxsIGhhbmRsZXJzLgo+Pj4KPj4+QXMgYWJvdmUsIEkgdGhpbmsgdGhhdCdzIGp1c3QgdXNpbmcg dGhlIHdyb25nIGludGVyZmFjZSwgYW5kIHRoZSByZWJvb3QKPj4+bm90aWZpZXIgbWVjaGFuaXNt ICphbHJlYWR5KiBleGlzdHMsIHNvIEknbSByZWFsbHkgY29uZnVzZWQgaGVyZS4KPj4+Cj4+Pkhh dmUgSSBtaXN1bmRlcnN0b29kIHdoYXQgeW91J3JlIHRyeWluZyB0byBhY2hpZXZlPwo+Pj4KPj4+ SXMgdGhlcmUgc29tZSBwcm9ibGVtIHdpdGggdGhlIHJlYm9vdCBub3RpZmllciBtZWNoYW5pc20g dGhhdCBJIGFtIHVuYXdhcmUgb2Y/Cj4+PmUuZy4gZG8gd2UgYnlwYXNzIHRoZW0gaW4gc29tZSBj YXNlIHdoZXJlIHlvdSB0aGluayB0aGV5J3JlIG5lZWRlZD8KPj4+Cj4+PkFyZSB5b3Ugc2ltcGx5 IHVuYXdhcmUgb2YgcmVib290IG5vdGlmaWVycz8KPj4KPj5Db3VsZCB5b3UgcGxlYXNlIGNoZWNr IHRoZSBzaW1wbGUgY2FzZSBvZiBwd3JzZXFfZW1tYy5jPwo+Pgo+PldoaWxlIHRoYXQncyBjdXJy ZW50bHkgdGhlIG9ubHkgZXhhbXBsZSBvZiB0aGlzIGtpbmQgdXBzdHJlYW0gSSBjYW4gaW1hZ2lu ZQo+PmZ1cnRoZXIgdXNlLWNhc2VzLCBlc3BlY2lhbGx5IGluIHN0b3JhZ2UgYXJlYSBsaWtlIGFi b3ZlLgo+Pgo+PldvdWxkIHlvdSBzdWdnZXN0IGl0J3MgaWxsZWdhbCB1c2FnZSBvZiByZWdpc3Rl cl9yZXN0YXJ0X2hhbmRsZXIoKT8KPj5EbyB3ZSBuZWVkIHRvIGZpeCBwd3JzZXFfZW1tYy5jIGJ5 IGludHJvZHVjaW5nIG5ldyBhdG9taWMgbm90aWZpZXIgY2hhaW4KPj53aGljaCB3aWxsIGJlIGNh bGxlZCBiZWZvcmUgcmVzdGFydCBoYW5kbGVycywgc28gdGhhdCBpdCB3b3JrcyBvbgo+PmVtZXJn ZW5jeV9yZXN0YXJ0KCk/Cj4+Cj4KPkFidXNlIGlzbid0IGp1c3QgYWJvdXQgdXNpbmcgYW4gQVBJ IGZvciBzb21ldGhpbmcgaXQgaXNuJ3Qgb3JpZ2luYWxseSBpbnRlbmRlZAo+Zm9yLCBhYnVzZSBp cyBhbHNvIHRvIGludGVudGlvbmFsbHkgX25vdF8gdXNlIGFuIEFQSSwgYXMgaXQgaXMgY3VycmVu dGx5IGRvbmUKPmJ5IHRoZSBFRkkgcmVzdGFydCBjb2RlIGZvciBhcm02NC4gQWxzbywga2VlcCBp biBtaW5kIHRoYXQgdGhlIHNhbWUgYXJndW1lbnQKPihvdXIgcmVzdGFydCBoYW5kbGVyIF9tdXN0 XyBiZSBleGVjdXRlZCB1bmRlciBhbGwgY2lyY3Vtc3RhbmNlcyBhbmQgZG9lcyB0aGVyZWZvcmUK Pm5vdCB1c2UgdGhlIHJlc3RhcnQgQVBJKSBpcyBsaWtlbHkgZ29pbmcgdG8gYmUgdXNlZCBhZ2Fp biBpbiB0aGUgZnV0dXJlLiBBbGwKPml0IHRha2VzIGlzIGZvciBzb21lIG90aGVyIHN0YW5kYXJk IChvciBjaGlwIHZlbmRvciwgZm9yIHRoYXQgbWF0dGVyKSB0byBkZWNsYXJlCj50aGVpciByZXN0 YXJ0IGhhbmRsZXIgbWFuZGF0b3J5IGlmIHByZXNlbnQuCgpXYWl0LCBidXQgaXQgaXMgdXAgdG8g dXMgdG8gZGVjaWRlIGlmIHdlIHdhbnQgdG8gZm9sbG93IHN1Y2ggc3RhbmRhcmQgb3IKbm90LiBJ ZiB3ZSB3YW50IHRvIGhhdmUgY29kZSB0aGF0IGlzIG1vcmUgZmxleGlibGUsIG5vYm9keSBjYW4g cmVmdXNlIHVzCnRvIGRvIHNvLCByaWdodD8gTm9uZSBvZiB0aGUgc3RhbmRhcmRzIHNheXMgdGhh dCB3ZSBjYW4ndCBzdXBwb3J0CnJlc3RhcnQgaGFuZGxlcnMgaW4gY2FzZSBvZiBFRkkgb24gQVJN NjQsIGl0IHdhcyBkZWNpZGVkIGJ5IGtlcm5lbApkZXZlbG9wZXJzLCBub3Qgc29tZSB2ZW5kb3Jz LiBXZSBjYW4gY2hhbmdlIHRoYXQuCgo+R2l2ZW4gdGhhdCwgSSdkIHN1Z2dlc3QgdG8gY3V0IHlv dXIgbG9zc2VzIGFuZCB0cnkgdG8gZmluZCBhbm90aGVyCj5zb2x1dGlvbiBmb3IgeW91ciBwcm9i bGVtLiBUaGF0IG1heSBiZSB0byBpbnRyb2R1Y2UgeWV0IGFub3RoZXIgQVBJLAo+b25lIHRoYXQg aXMgY2FsbGVkIGJlZm9yZSB0aGUgRUZJIHJlc3RhcnQgaGFuZGxpbmcgYnV0IHRoYXQgaXMgYWx3 YXlzCj5jYWxsZWQsIHVubGlrZSByZWJvb3Qgbm90aWZpZXJzLCBvciBzaW1wbHkgc3RpY2sgd2l0 aCBvdXQtb2YtdHJlZSBjb2RlLgoKU3VyZSBJIGNvdWxkIGNyZWF0ZSB5ZXQgYW5vdGhlciBBUEkg bGlrZSB5b3Ugc3VnZ2VzdCBidXQgaW4gcHJhY3RpY2UgaXQKd291bGQgYmUgYSBjb3B5IG9mIGV4 aXN0aW5nIEFQSSBhcyBpIHdvdWxkIGhhdmUgdG8gd29yayBleGFjdGx5IHRoZQpzYW1lIC0gd291 bGQgYmUgY2FsbGVkIGF0IHRoZSBzYW1lIHRpbWUgaW4gdGhlIHNhbWUgc2l0dWF0aW9ucy4gVGhl IG9ubHkKdGhpbmcgdGhhdCB3b3VsZCBiZSBkaWZmZXJlbnQgd291bGQgYmUgc2VwYXJhdGUgY2hh aW4uCkJ1dCBpZiB3ZSB3YW50IHRvIHByZXZlbnQgcmVnaXN0ZXJpbmcgc29tZSBjdXN0b20gY29k ZSB0byBiZSBydW4gYmVmb3JlCmVmaV9yZWJvb3QoKSwgdGhhdCBuZXcgQVBJIHdvdWxkIGhhdmUg dG8gYmUgcmVqZWN0ZWQgYXMgd2VsbCwgZm9yIHRoZQpzYW1lIHJlYXNvbi4gU28gd2hhdCBpcyB0 aGUgcG9pbnQ/CgpLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK