From: Danilo Krummrich <danilokrummrich@dk-develop.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH 1/2] dt-bindings: ps2-gpio: convert binding to json-schema
Date: Tue, 15 Feb 2022 18:53:32 +0100 [thread overview]
Message-ID: <YgvonImK7lqBDcYO@pollux> (raw)
In-Reply-To: <b6003ead-e3b4-a803-b92d-c08fc731a654@canonical.com>
On Tue, Feb 15, 2022 at 05:59:36PM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2022 17:51, Danilo Krummrich wrote:
> > Convert the ps2-gpio dt-binding documentation to DT schema format using
> > the json-schema.
> >
> > Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
> > ---
> > .../devicetree/bindings/serio/ps2-gpio.txt | 23 --------
> > .../devicetree/bindings/serio/ps2-gpio.yaml | 58 +++++++++++++++++++
> > 2 files changed, 58 insertions(+), 23 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt
> > create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.yaml
> >
>
> Please version your patches in the subject. You can achieve it manually
> or with `git format-patch -v2`. I think lack of v2 confuses b4 diff
> ("ERROR: Could not auto-find previous revision
> ").
Yes, I accidentally missed the `-v2` parameter.
>
> > +
> > +additionalProperties: true
> > +
>
> I missed this part (lack of) in your v1. This has to be false.
I'll send a v3.
>
> Best regards,
> Krzysztof
Thanks.
- Danilo
next prev parent reply other threads:[~2022-02-15 17:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 16:51 dt-bindings: ps2-gpio: convert binding to json-schema Danilo Krummrich
2022-02-15 16:51 ` [PATCH 1/2] " Danilo Krummrich
2022-02-15 16:59 ` Krzysztof Kozlowski
2022-02-15 17:53 ` Danilo Krummrich [this message]
2022-02-15 16:51 ` [PATCH 2/2] dt-bindings: ps2-gpio: document bus signals open drain Danilo Krummrich
2022-02-15 17:01 ` Krzysztof Kozlowski
2022-02-15 17:01 ` dt-bindings: ps2-gpio: convert binding to json-schema Krzysztof Kozlowski
2022-02-15 17:46 ` Danilo Krummrich
-- strict thread matches above, loose matches on Subject: below --
2022-02-11 23:31 Danilo Krummrich
2022-02-11 23:31 ` [PATCH 1/2] " Danilo Krummrich
2022-02-14 21:49 ` Krzysztof Kozlowski
2022-02-14 22:53 ` Danilo Krummrich
2022-02-15 15:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgvonImK7lqBDcYO@pollux \
--to=danilokrummrich@dk-develop.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.