From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Danilo Krummrich <danilokrummrich@dk-develop.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org
Subject: Re: ps2-gpio: use ktime for IRQ timekeeping
Date: Tue, 15 Feb 2022 14:56:22 -0800 [thread overview]
Message-ID: <Ygwvls62iycw12z/@google.com> (raw)
In-Reply-To: <20220215160208.34826-1-danilokrummrich@dk-develop.de>
On Tue, Feb 15, 2022 at 05:02:04PM +0100, Danilo Krummrich wrote:
> Changes since v1
> ================
> - add patch to refactor struct ps2_gpio_data for clear separation between
> RX and TX
> - make all variables for IRQ timekeeping per-port and initialize them in
> ps2_gpio_open()
>
> This patch series implements the usage of ktime for IRQ timekeeping to
> overcome:
>
> (1) The resolution limitations of jiffies.
> (2) Potential spurious IRQs generated by gpio controllers.
>
> Besides that, based on the newly implemented timekeeping, it fixes a wrongly
> suspected extra clock cycle for TX transfers and a race condition when
> starting an immediate TX transfer based on data received from an RX transfer.
>
> Danilo Krummrich (4):
> input: ps2-gpio: refactor struct ps2_gpio_data
> input: ps2-gpio: use ktime for IRQ timekeeping
> input: ps2-gpio: remove tx timeout from ps2_gpio_irq_tx()
> input: ps2-gpio: don't send rx data before the stop bit
>
> drivers/input/serio/ps2-gpio.c | 180 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------
> 1 file changed, 116 insertions(+), 64 deletions(-)
Applied the lot, thank you.
--
Dmitry
prev parent reply other threads:[~2022-02-15 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 16:02 ps2-gpio: use ktime for IRQ timekeeping Danilo Krummrich
2022-02-15 16:02 ` [PATCH 1/4] input: ps2-gpio: refactor struct ps2_gpio_data Danilo Krummrich
2022-02-15 21:54 ` Dmitry Torokhov
2022-02-15 22:23 ` Danilo Krummrich
2022-02-15 22:38 ` Dmitry Torokhov
2022-02-15 16:02 ` [PATCH 2/4] input: ps2-gpio: use ktime for IRQ timekeeping Danilo Krummrich
2022-02-15 16:02 ` [PATCH 3/4] input: ps2-gpio: remove tx timeout from ps2_gpio_irq_tx() Danilo Krummrich
2022-02-15 16:02 ` [PATCH 4/4] input: ps2-gpio: don't send rx data before the stop bit Danilo Krummrich
2022-02-15 22:56 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygwvls62iycw12z/@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=danilokrummrich@dk-develop.de \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.