From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Danilo Krummrich <danilokrummrich@dk-develop.de>
Cc: krzysztof.kozlowski@canonical.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH v3 3/3] input: ps2-gpio: enforce GPIOs flag open drain
Date: Tue, 15 Feb 2022 14:56:40 -0800 [thread overview]
Message-ID: <YgwvqAvi8OvGi0Ft@google.com> (raw)
In-Reply-To: <20220215180829.63543-4-danilokrummrich@dk-develop.de>
On Tue, Feb 15, 2022 at 07:08:29PM +0100, Danilo Krummrich wrote:
> The PS/2 bus defines the data and clock line be open drain, therefore
> for both enforce the particular GPIO flags in the driver.
>
> Without enforcing to flag at least the clock gpio as open drain we run
> into the following warning:
>
> WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90
>
> gpiochip_enable_irq() warns on a GPIO being configured as output while
> serving as IRQ source without being flagged as open drain.
>
> Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-02-15 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 18:08 dt-bindings: ps2-gpio: convert binding to json-schema Danilo Krummrich
2022-02-15 18:08 ` [PATCH v3 1/3] " Danilo Krummrich
2022-02-16 7:19 ` Krzysztof Kozlowski
2022-02-15 18:08 ` [PATCH v3 2/3] dt-bindings: ps2-gpio: document bus signals open drain Danilo Krummrich
2022-02-16 7:19 ` Krzysztof Kozlowski
2022-02-15 18:08 ` [PATCH v3 3/3] input: ps2-gpio: enforce GPIOs flag " Danilo Krummrich
2022-02-15 22:56 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgwvqAvi8OvGi0Ft@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=danilokrummrich@dk-develop.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.