From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9A26C433EF for ; Wed, 16 Feb 2022 08:25:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F84D10E8EA; Wed, 16 Feb 2022 08:25:15 +0000 (UTC) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4441010E608; Tue, 15 Feb 2022 22:59:29 +0000 (UTC) Received: by mail-pj1-x1035.google.com with SMTP id d9-20020a17090a498900b001b8bb1d00e7so652656pjh.3; Tue, 15 Feb 2022 14:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=neA8UZ+ztvqI+c9Y0GhuINKiFZbH9bwEKDbDdCj/aBEOg8Je4KJR2FY7wqhQqcBAYk 3Wy+WGL8h5hMZhHiRrJnELKEzNVne+rWwRiNSK+LaaB40t3gKAMZ5iPl6SH4z0sCF1sK WeebZKAyrtHxpGEBt52RHDKoImWcRYibqiE5YdJSrERCh5ErepkYhiOc7Yw8VRa7JtSJ adEHSUdt8ZETIXkSrLoXpm9wbvKFejNQ1Fv3M/q0bRnt69wRrVeApz/eynGg7QDAnCzT uJF8lE/RahbG4H9xVfC7Tm4Wgh1nT1vyrj+ukgd4F45LFSngNGYO0nz3bd1+0RfzB/uo Q/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=V+tcmYagwQfeTZ4kkh7wjDtuNyeaQWxpoAvGPgBRojc/TqL3HbJVaQ169BpRdCRF8q Jl5JGiEWN+JSGARykgkHGLGpFBHLTZeqB7frYgEGQuY750wsq1UXqhTdWx7lZPDC6KmS WU+lwvRSVIzHYfeFJC4DT0aMQkLZb3+jlDcA6oZ5UqUGeSbQw+RzglcW+shJPOtPPS5P DzcKoriYOcc4RdUZXJ8IIrGpkae5UPjpig0GJLfmFDTFsCAcZHntJuTMUEa9k9uU/tDW ELO0t0Q9g+rM/ifb6+sYcf7cznyn032e0+cB8IMtOmy5QrfibvgVSXo944Y+SSS2YiNf EemA== X-Gm-Message-State: AOAM532vb9dC4TP0q4NNwSKAEuZF3AN6N+xHpOOTVv8NTTmJyrM7DiY0 4ZrFzctNOGCMbFjf2nEiT+I= X-Google-Smtp-Source: ABdhPJzD5VTWuMUJjUi6d0x1rXiN3okRfTcvfy3+tsDIIsH6bfb6SZ+FiyUr2n1wCBp6WTu5fGOOUA== X-Received: by 2002:a17:902:f686:: with SMTP id l6mr1079179plg.7.1644965965923; Tue, 15 Feb 2022 14:59:25 -0800 (PST) Received: from google.com ([2620:15c:202:201:4e4a:b0ff:e926:40e2]) by smtp.gmail.com with ESMTPSA id n85sm10430319pfd.142.2022.02.15.14.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 14:59:25 -0800 (PST) Date: Tue, 15 Feb 2022 14:59:21 -0800 From: Dmitry Torokhov To: Qing Wang Subject: Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it Message-ID: References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-7-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com> X-Mailman-Approved-At: Wed, 16 Feb 2022 08:25:14 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Snitzer , David Airlie , Michael Turquette , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Hans Verkuil , dm-devel@redhat.com, Benjamin Tissoires , Srinivas Pandruvada , linux-clk@vger.kernel.org, Alasdair Kergon , amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-media@vger.kernel.org, Konrad Rzeszutek Wilk , intel-gfx@lists.freedesktop.org, Jiri Kosina , Jani Nikula , linux-block@vger.kernel.org, Rodrigo Vivi , Mauro Carvalho Chehab , Jens Axboe , Stephen Boyd , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Roger Pau =?iso-8859-1?Q?Monn=E9?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/20220215160208.34826-3-danilokrummrich@dk-develop.de) which makes this change not applicable. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28F04C433FE for ; Wed, 16 Feb 2022 06:28:40 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-noRZN7V6P5a4rcWaF4VEDQ-1; Wed, 16 Feb 2022 01:28:35 -0500 X-MC-Unique: noRZN7V6P5a4rcWaF4VEDQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02D3418397B3; Wed, 16 Feb 2022 06:28:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D7DB4108BA; Wed, 16 Feb 2022 06:28:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A9D051809CB9; Wed, 16 Feb 2022 06:28:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21FMxYPq016946 for ; Tue, 15 Feb 2022 17:59:34 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4A6705361F7; Tue, 15 Feb 2022 22:59:34 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46BC0401E37 for ; Tue, 15 Feb 2022 22:59:34 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2DC691800046 for ; Tue, 15 Feb 2022 22:59:34 +0000 (UTC) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-oHfupT18OHOpz9lML3Kg-g-1; Tue, 15 Feb 2022 17:59:30 -0500 X-MC-Unique: oHfupT18OHOpz9lML3Kg-g-1 Received: by mail-pj1-f50.google.com with SMTP id ki18-20020a17090ae91200b001b8be87e9abso2763414pjb.1; Tue, 15 Feb 2022 14:59:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=E/OW3wSrX8JMu5RFVkHdtwu/dk4Uuw1SxtpRfAi0tnU1ItoKL67iWH4g/QRs7bLm7v m4IWqbu9Gw0TfEHIvsmXdrR6ihuEbZMiXz0Wu5cplZrDHqILYLWLk7wu6DZIx7Mdg84R o0XjPpkhcOGxLM7KxSBQlBKTCjrPBiwG53jjtG3uy9g54ueBLUHoP0rIQ1dpUoyir3dM bYv1QrVEKpkvSEJHjb9KqrUaU3TCjm+V3MPxJAqLsTiwL+mUVYetBtQp5Kj7wgkWL8Kd s/VWMwUxliRBLyEFAU41/9zmjyRk0iVUnqIgGPYqCTe45n5b7Zy4sjUsjZeeuhDxqQwg 5Vjw== X-Gm-Message-State: AOAM530SHvvHAsOa1fbtLFIfQDHNQrPXfmdxYywV9zR5y8ZaaDcmx8a7 g8Af6hOgJiRaXh08mh1E6Wg= X-Google-Smtp-Source: ABdhPJzD5VTWuMUJjUi6d0x1rXiN3okRfTcvfy3+tsDIIsH6bfb6SZ+FiyUr2n1wCBp6WTu5fGOOUA== X-Received: by 2002:a17:902:f686:: with SMTP id l6mr1079179plg.7.1644965965923; Tue, 15 Feb 2022 14:59:25 -0800 (PST) Received: from google.com ([2620:15c:202:201:4e4a:b0ff:e926:40e2]) by smtp.gmail.com with ESMTPSA id n85sm10430319pfd.142.2022.02.15.14.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 14:59:25 -0800 (PST) Date: Tue, 15 Feb 2022 14:59:21 -0800 From: Dmitry Torokhov To: Qing Wang Message-ID: References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-7-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Wed, 16 Feb 2022 01:28:09 -0500 Cc: Mike Snitzer , David Airlie , Michael Turquette , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Hans Verkuil , dm-devel@redhat.com, Benjamin Tissoires , Srinivas Pandruvada , linux-clk@vger.kernel.org, Alasdair Kergon , amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-media@vger.kernel.org, Konrad Rzeszutek Wilk , intel-gfx@lists.freedesktop.org, Jiri Kosina , Jani Nikula , linux-block@vger.kernel.org, Rodrigo Vivi , Mauro Carvalho Chehab , Jens Axboe , Stephen Boyd , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [dm-devel] [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/20220215160208.34826-3-danilokrummrich@dk-develop.de) which makes this change not applicable. Thanks. -- Dmitry -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 491EDC43217 for ; Tue, 15 Feb 2022 22:59:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8D0110E60B; Tue, 15 Feb 2022 22:59:30 +0000 (UTC) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4441010E608; Tue, 15 Feb 2022 22:59:29 +0000 (UTC) Received: by mail-pj1-x1035.google.com with SMTP id d9-20020a17090a498900b001b8bb1d00e7so652656pjh.3; Tue, 15 Feb 2022 14:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=neA8UZ+ztvqI+c9Y0GhuINKiFZbH9bwEKDbDdCj/aBEOg8Je4KJR2FY7wqhQqcBAYk 3Wy+WGL8h5hMZhHiRrJnELKEzNVne+rWwRiNSK+LaaB40t3gKAMZ5iPl6SH4z0sCF1sK WeebZKAyrtHxpGEBt52RHDKoImWcRYibqiE5YdJSrERCh5ErepkYhiOc7Yw8VRa7JtSJ adEHSUdt8ZETIXkSrLoXpm9wbvKFejNQ1Fv3M/q0bRnt69wRrVeApz/eynGg7QDAnCzT uJF8lE/RahbG4H9xVfC7Tm4Wgh1nT1vyrj+ukgd4F45LFSngNGYO0nz3bd1+0RfzB/uo Q/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=V+tcmYagwQfeTZ4kkh7wjDtuNyeaQWxpoAvGPgBRojc/TqL3HbJVaQ169BpRdCRF8q Jl5JGiEWN+JSGARykgkHGLGpFBHLTZeqB7frYgEGQuY750wsq1UXqhTdWx7lZPDC6KmS WU+lwvRSVIzHYfeFJC4DT0aMQkLZb3+jlDcA6oZ5UqUGeSbQw+RzglcW+shJPOtPPS5P DzcKoriYOcc4RdUZXJ8IIrGpkae5UPjpig0GJLfmFDTFsCAcZHntJuTMUEa9k9uU/tDW ELO0t0Q9g+rM/ifb6+sYcf7cznyn032e0+cB8IMtOmy5QrfibvgVSXo944Y+SSS2YiNf EemA== X-Gm-Message-State: AOAM532vb9dC4TP0q4NNwSKAEuZF3AN6N+xHpOOTVv8NTTmJyrM7DiY0 4ZrFzctNOGCMbFjf2nEiT+I= X-Google-Smtp-Source: ABdhPJzD5VTWuMUJjUi6d0x1rXiN3okRfTcvfy3+tsDIIsH6bfb6SZ+FiyUr2n1wCBp6WTu5fGOOUA== X-Received: by 2002:a17:902:f686:: with SMTP id l6mr1079179plg.7.1644965965923; Tue, 15 Feb 2022 14:59:25 -0800 (PST) Received: from google.com ([2620:15c:202:201:4e4a:b0ff:e926:40e2]) by smtp.gmail.com with ESMTPSA id n85sm10430319pfd.142.2022.02.15.14.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 14:59:25 -0800 (PST) Date: Tue, 15 Feb 2022 14:59:21 -0800 From: Dmitry Torokhov To: Qing Wang Message-ID: References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-7-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com> Subject: Re: [Intel-gfx] [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Snitzer , David Airlie , Michael Turquette , dri-devel@lists.freedesktop.org, Hans Verkuil , dm-devel@redhat.com, Benjamin Tissoires , Srinivas Pandruvada , linux-clk@vger.kernel.org, Alasdair Kergon , amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-media@vger.kernel.org, Konrad Rzeszutek Wilk , intel-gfx@lists.freedesktop.org, Jiri Kosina , linux-block@vger.kernel.org, Mauro Carvalho Chehab , Jens Axboe , Stephen Boyd , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Roger Pau =?iso-8859-1?Q?Monn=E9?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/20220215160208.34826-3-danilokrummrich@dk-develop.de) which makes this change not applicable. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C8DC433EF for ; Tue, 15 Feb 2022 22:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244738AbiBOW7s (ORCPT ); Tue, 15 Feb 2022 17:59:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244719AbiBOW7j (ORCPT ); Tue, 15 Feb 2022 17:59:39 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C85E3891; Tue, 15 Feb 2022 14:59:29 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id k60-20020a17090a4cc200b001b932781f3eso3056814pjh.0; Tue, 15 Feb 2022 14:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=neA8UZ+ztvqI+c9Y0GhuINKiFZbH9bwEKDbDdCj/aBEOg8Je4KJR2FY7wqhQqcBAYk 3Wy+WGL8h5hMZhHiRrJnELKEzNVne+rWwRiNSK+LaaB40t3gKAMZ5iPl6SH4z0sCF1sK WeebZKAyrtHxpGEBt52RHDKoImWcRYibqiE5YdJSrERCh5ErepkYhiOc7Yw8VRa7JtSJ adEHSUdt8ZETIXkSrLoXpm9wbvKFejNQ1Fv3M/q0bRnt69wRrVeApz/eynGg7QDAnCzT uJF8lE/RahbG4H9xVfC7Tm4Wgh1nT1vyrj+ukgd4F45LFSngNGYO0nz3bd1+0RfzB/uo Q/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=jcyxnoN6sH1LNSWvMVODjrCi1Ms/7ihCiQuLNAMrFzQBcpH/78A0aGGgxNLLgFLTFW WrusZ2fOr9fBta4oykkLyMkUveNo2imJ4f6cbXXPB0XFGhZfh0IbcbZXGAQuk7PIqduF 91hPNb5oSKYlfSZysWanByackIqS5vJHMFRjIQP63i4EnO7nJ8059jALZfCxi8AB4I/5 gYH7pPleib3Aa008mRWxzzXgO88LhREpfTn+FV5tUnKLWGRtPVlh5++9HQqyb+ryY3VC IP0M/b0m+4C/QfcXd9ucaK/N8LMSlCjuFa6dKZGrQYPKw/tS66KVQ+gLVAkzwrdqTFjS Q83w== X-Gm-Message-State: AOAM533xqME4mPEYcYWb4rBukVPdwafCX+GxdAzGg6QAtQaa2ylA5Lw+ XR7gFu+igA3JZzd5jbbo3gw= X-Google-Smtp-Source: ABdhPJzD5VTWuMUJjUi6d0x1rXiN3okRfTcvfy3+tsDIIsH6bfb6SZ+FiyUr2n1wCBp6WTu5fGOOUA== X-Received: by 2002:a17:902:f686:: with SMTP id l6mr1079179plg.7.1644965965923; Tue, 15 Feb 2022 14:59:25 -0800 (PST) Received: from google.com ([2620:15c:202:201:4e4a:b0ff:e926:40e2]) by smtp.gmail.com with ESMTPSA id n85sm10430319pfd.142.2022.02.15.14.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 14:59:25 -0800 (PST) Date: Tue, 15 Feb 2022 14:59:21 -0800 From: Dmitry Torokhov To: Qing Wang Cc: Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Michael Turquette , Stephen Boyd , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Mauro Carvalho Chehab , Hans Verkuil , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it Message-ID: References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-7-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/20220215160208.34826-3-danilokrummrich@dk-develop.de) which makes this change not applicable. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19C4FC433F5 for ; Wed, 16 Feb 2022 08:23:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE71910E8E0; Wed, 16 Feb 2022 08:23:45 +0000 (UTC) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4441010E608; Tue, 15 Feb 2022 22:59:29 +0000 (UTC) Received: by mail-pj1-x1035.google.com with SMTP id d9-20020a17090a498900b001b8bb1d00e7so652656pjh.3; Tue, 15 Feb 2022 14:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=neA8UZ+ztvqI+c9Y0GhuINKiFZbH9bwEKDbDdCj/aBEOg8Je4KJR2FY7wqhQqcBAYk 3Wy+WGL8h5hMZhHiRrJnELKEzNVne+rWwRiNSK+LaaB40t3gKAMZ5iPl6SH4z0sCF1sK WeebZKAyrtHxpGEBt52RHDKoImWcRYibqiE5YdJSrERCh5ErepkYhiOc7Yw8VRa7JtSJ adEHSUdt8ZETIXkSrLoXpm9wbvKFejNQ1Fv3M/q0bRnt69wRrVeApz/eynGg7QDAnCzT uJF8lE/RahbG4H9xVfC7Tm4Wgh1nT1vyrj+ukgd4F45LFSngNGYO0nz3bd1+0RfzB/uo Q/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=; b=V+tcmYagwQfeTZ4kkh7wjDtuNyeaQWxpoAvGPgBRojc/TqL3HbJVaQ169BpRdCRF8q Jl5JGiEWN+JSGARykgkHGLGpFBHLTZeqB7frYgEGQuY750wsq1UXqhTdWx7lZPDC6KmS WU+lwvRSVIzHYfeFJC4DT0aMQkLZb3+jlDcA6oZ5UqUGeSbQw+RzglcW+shJPOtPPS5P DzcKoriYOcc4RdUZXJ8IIrGpkae5UPjpig0GJLfmFDTFsCAcZHntJuTMUEa9k9uU/tDW ELO0t0Q9g+rM/ifb6+sYcf7cznyn032e0+cB8IMtOmy5QrfibvgVSXo944Y+SSS2YiNf EemA== X-Gm-Message-State: AOAM532vb9dC4TP0q4NNwSKAEuZF3AN6N+xHpOOTVv8NTTmJyrM7DiY0 4ZrFzctNOGCMbFjf2nEiT+I= X-Google-Smtp-Source: ABdhPJzD5VTWuMUJjUi6d0x1rXiN3okRfTcvfy3+tsDIIsH6bfb6SZ+FiyUr2n1wCBp6WTu5fGOOUA== X-Received: by 2002:a17:902:f686:: with SMTP id l6mr1079179plg.7.1644965965923; Tue, 15 Feb 2022 14:59:25 -0800 (PST) Received: from google.com ([2620:15c:202:201:4e4a:b0ff:e926:40e2]) by smtp.gmail.com with ESMTPSA id n85sm10430319pfd.142.2022.02.15.14.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 14:59:25 -0800 (PST) Date: Tue, 15 Feb 2022 14:59:21 -0800 From: Dmitry Torokhov To: Qing Wang Subject: Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it Message-ID: References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-7-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com> X-Mailman-Approved-At: Wed, 16 Feb 2022 08:23:45 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Snitzer , David Airlie , Michael Turquette , dri-devel@lists.freedesktop.org, Hans Verkuil , dm-devel@redhat.com, Benjamin Tissoires , Srinivas Pandruvada , linux-clk@vger.kernel.org, Alasdair Kergon , amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-media@vger.kernel.org, Konrad Rzeszutek Wilk , intel-gfx@lists.freedesktop.org, Jiri Kosina , linux-block@vger.kernel.org, Rodrigo Vivi , Mauro Carvalho Chehab , Jens Axboe , Stephen Boyd , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Roger Pau =?iso-8859-1?Q?Monn=E9?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/20220215160208.34826-3-danilokrummrich@dk-develop.de) which makes this change not applicable. Thanks. -- Dmitry