From: Wolfram Sang <wsa@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH 1/2] i2c: i801: Drop useless masking in i801_access
Date: Wed, 2 Mar 2022 22:12:12 +0100 [thread overview]
Message-ID: <Yh/drMSLHC+8hKqF@ninjato> (raw)
In-Reply-To: <20220301173937.636a21ce@endymion.delvare> <20220301172859.5593309a@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Tue, Mar 01, 2022 at 05:28:59PM +0100, Jean Delvare wrote:
> I went all the way back to kernel 2.6.12 and that masking was never
> needed. I suppose it was there in anticipation of software PEC
> support, but that was never added to the driver (and never will be,
> as this is made obsolete by hardware PEC).
>
> I'm also removing initialization to 0, which is not needed either,
> and would prevent the compiler from reporting an actual usage of
> uninitialized variables.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-02 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 16:28 [PATCH 1/2] i2c: i801: Drop useless masking in i801_access Jean Delvare
2022-03-01 16:39 ` [PATCH 2/2] i2c: i801: Add support for the Process Call command Jean Delvare
2022-03-02 14:12 ` Jarkko Nikula
2022-03-02 13:54 ` [PATCH 1/2] i2c: i801: Drop useless masking in i801_access Jarkko Nikula
2022-03-02 21:12 ` Wolfram Sang [this message]
2022-03-02 21:13 ` Wolfram Sang
2022-03-03 16:41 ` Jean Delvare
2022-03-03 18:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh/drMSLHC+8hKqF@ninjato \
--to=wsa@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.