From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Peter Rosin <peda@axentia.se>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: mux: demux-pinctrl: do not deactivate a master that is not active
Date: Wed, 2 Mar 2022 22:22:37 +0100 [thread overview]
Message-ID: <Yh/gHSaRNs9Z8La2@ninjato> (raw)
In-Reply-To: <Yh/e4OzQ/hYSb+dg@ninjato>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Wed, Mar 02, 2022 at 10:17:20PM +0100, Wolfram Sang wrote:
>
> > Attempting to rollback the activation of the current master when
> > the current master has not been activated is bad. priv->cur_chan
>
> But the master is activated?
>
> 259 /* switch to first parent as active master */
> 260 i2c_demux_activate_master(priv, 0);
>
> Or am I missing something? :)
But _this_ code is affected by the problem you describe, or?
237 if (!adap_np) {
238 dev_err(&pdev->dev, "can't get phandle for parent %d\n", i);
239 err = -ENOENT;
240 goto err_rollback;
241 }
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-02 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 11:22 [PATCH] i2c: mux: demux-pinctrl: do not deactivate a master that is not active Peter Rosin
2022-03-02 19:42 ` *** SPAM *** " Marion & Christophe JAILLET
2022-03-02 21:17 ` Wolfram Sang
2022-03-02 21:22 ` Wolfram Sang [this message]
2022-03-02 22:45 ` Peter Rosin
2022-03-19 23:55 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh/gHSaRNs9Z8La2@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.