From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDBAC433F5 for ; Wed, 2 Mar 2022 22:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbiCBWYK (ORCPT ); Wed, 2 Mar 2022 17:24:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbiCBWYK (ORCPT ); Wed, 2 Mar 2022 17:24:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D61CE0AEA; Wed, 2 Mar 2022 14:23:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E629B61AA8; Wed, 2 Mar 2022 22:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 125FEC004E1; Wed, 2 Mar 2022 22:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646259805; bh=ruaxpWDeM+wgTsYbBMTZZvhUl9cquYwlcym89lKCGMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jED46bNwHfOG4K5q0CuXZfDANIQ8ePJYDXhNnnl9bX2mI1ZBrbEJWrEkYfKLFt9xY WQn9JurdZoalUi8N6A+v/fjWbn6PwaDS7Rdmf0rJXTocM4dw6EDwEQC5GnoHLpKg1a NOFKJuOt/APeiQgqXKgURqb5c2JI4jcbW0qWO68/CS96SB+a4aDen9guhtKNwV2CWb rT9S0oUTr1/i87mpUDFtoaerBU3SCvmvb4s+DLjM8Xpo0ZL0bEov/tdLo5JO1B5zEw ZsnXzzxtTh69nVk26ccAeIq/Dc6K0AY31FUHYeknifGSWzpq8aedZag9t07BSj+qco pvLpM9VMZn/BA== Date: Wed, 2 Mar 2022 22:23:23 +0000 From: Eric Biggers To: "Jason A. Donenfeld" Cc: Herbert Xu , Tianjia Zhang , "David S. Miller" , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Gilad Ben-Yossef , Ard Biesheuvel , "Markku-Juhani O . Saarinen" , Jussi Kivilinna , X86 ML , Linux Crypto Mailing List , linux-arm-kernel , LKML Subject: Re: [PATCH 1/3] crypto: sm4 - create SM4 library based on sm4 generic code Message-ID: References: <20210610134459.28541-1-tianjia.zhang@linux.alibaba.com> <20210610134459.28541-2-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Mar 02, 2022 at 01:26:13AM +0100, Jason A. Donenfeld wrote: > On Wed, Mar 2, 2022 at 1:24 AM Herbert Xu wrote: > > > > On Tue, Mar 01, 2022 at 11:34:28AM +0100, Jason A. Donenfeld wrote: > > > > lib/crypto/Kconfig | 3 + > > > > lib/crypto/Makefile | 3 + > > > > lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++ > > > > > > If this is only used by the crypto API, it does not belong in > > > lib/crypto. > > > > Nope there is no such rule. lib/crypto is fine if you're adding > > code that is shared between crypto and arch/*/crypto. > > The sprawling madness continues then... Noted. I think it would make more sense for this code to be in crypto/, for the reason that Jason gave. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E752CC433EF for ; Wed, 2 Mar 2022 22:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1NiDoimLQptYc++AVigOWqM61Ep5gWQZwd948Nh+ckQ=; b=QjpFVHIPfaosd/ ey98l/P79ZsnrEJgl7FJZ3NpuyajYSNh2g/1EKaFwvEUPrtQb9wF5enyuV9meJ1oMZ4M6IFFnMlnz +uOO7r9Uh3SwBghiW2IykbagLxP/cXH7Wlqbfy39s+2J44gJS4nTKWkesClbHDkIO93qag4Ftrvof Tbfzyiy+oZRSxswKt3Igqu04r9pkZJrRTgdXZem2iMQwVhpemUNih0BuptXDtls04ri7stz1TBD3q Ih9L0DFjth8fYCRj82zYM5+k2dpQ/chNAccT0IQHJd+opKvR9/7tCZYHg8D6chKhBXdqYN9zOHQsJ XSBponI7uRWf4/kSBmgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPXNc-004Xp8-O4; Wed, 02 Mar 2022 22:23:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPXNW-004Xnh-VF for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 22:23:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2D056188F; Wed, 2 Mar 2022 22:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 125FEC004E1; Wed, 2 Mar 2022 22:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646259805; bh=ruaxpWDeM+wgTsYbBMTZZvhUl9cquYwlcym89lKCGMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jED46bNwHfOG4K5q0CuXZfDANIQ8ePJYDXhNnnl9bX2mI1ZBrbEJWrEkYfKLFt9xY WQn9JurdZoalUi8N6A+v/fjWbn6PwaDS7Rdmf0rJXTocM4dw6EDwEQC5GnoHLpKg1a NOFKJuOt/APeiQgqXKgURqb5c2JI4jcbW0qWO68/CS96SB+a4aDen9guhtKNwV2CWb rT9S0oUTr1/i87mpUDFtoaerBU3SCvmvb4s+DLjM8Xpo0ZL0bEov/tdLo5JO1B5zEw ZsnXzzxtTh69nVk26ccAeIq/Dc6K0AY31FUHYeknifGSWzpq8aedZag9t07BSj+qco pvLpM9VMZn/BA== Date: Wed, 2 Mar 2022 22:23:23 +0000 From: Eric Biggers To: "Jason A. Donenfeld" Cc: Herbert Xu , Tianjia Zhang , "David S. Miller" , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Gilad Ben-Yossef , Ard Biesheuvel , "Markku-Juhani O . Saarinen" , Jussi Kivilinna , X86 ML , Linux Crypto Mailing List , linux-arm-kernel , LKML Subject: Re: [PATCH 1/3] crypto: sm4 - create SM4 library based on sm4 generic code Message-ID: References: <20210610134459.28541-1-tianjia.zhang@linux.alibaba.com> <20210610134459.28541-2-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_142327_109105_9F68EC2C X-CRM114-Status: GOOD ( 18.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 02, 2022 at 01:26:13AM +0100, Jason A. Donenfeld wrote: > On Wed, Mar 2, 2022 at 1:24 AM Herbert Xu wrote: > > > > On Tue, Mar 01, 2022 at 11:34:28AM +0100, Jason A. Donenfeld wrote: > > > > lib/crypto/Kconfig | 3 + > > > > lib/crypto/Makefile | 3 + > > > > lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++ > > > > > > If this is only used by the crypto API, it does not belong in > > > lib/crypto. > > > > Nope there is no such rule. lib/crypto is fine if you're adding > > code that is shared between crypto and arch/*/crypto. > > The sprawling madness continues then... Noted. I think it would make more sense for this code to be in crypto/, for the reason that Jason gave. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel