From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2AA0C433EF for ; Mon, 28 Feb 2022 21:08:13 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-n4kXybPQNreBertXn_o7Ew-1; Mon, 28 Feb 2022 16:08:09 -0500 X-MC-Unique: n4kXybPQNreBertXn_o7Ew-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16E38100C610; Mon, 28 Feb 2022 21:08:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83833305B4; Mon, 28 Feb 2022 21:08:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 856DD4A701; Mon, 28 Feb 2022 21:08:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21SL7j7R010436 for ; Mon, 28 Feb 2022 16:07:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7F4BB2026D69; Mon, 28 Feb 2022 21:07:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7ABFC2026D60 for ; Mon, 28 Feb 2022 21:07:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0DF22299E74B for ; Mon, 28 Feb 2022 21:07:35 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-393-pTlfM5R9PViA1nFgR60Qnw-1; Mon, 28 Feb 2022 16:07:33 -0500 X-MC-Unique: pTlfM5R9PViA1nFgR60Qnw-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A3C2B81626; Mon, 28 Feb 2022 20:59:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2DB6C340F1; Mon, 28 Feb 2022 20:59:10 +0000 (UTC) Date: Mon, 28 Feb 2022 21:59:08 +0100 From: Greg KH To: Giovanni Cabiddu Message-ID: References: <20220219210354.GF59715@dread.disaster.area> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: Herbert Xu , Dave Chinner , Linux-Kernal , qat-linux@intel.com, linux-xfs , device-mapper development , Kyle Sanderson , Linux Crypto Mailing List , Linus Torvalds Subject: Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Feb 28, 2022 at 08:39:11PM +0000, Giovanni Cabiddu wrote: > On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote: > > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > > > > > Makes sense - this kernel driver has been destroying users for many > > > years. I'm disappointed that this critical bricking failure isn't > > > searchable for others. > > > > It does sound like we should just disable that driver entirely until > > it is fixed. > > > > Or at least the configuration that can cause problems, if there is > > some particular sub-case. > The dm-crypt + QAT use-case is already disabled since kernel 5.10 due to > a different issue. > Is it an option to port those patches to stable till I provide a fix for > the driver? I drafted already few alternatives for the fix and I am aiming > for a final set by end of week. If the existing situation is broken, yes, those patches are fine for stable releases. thanks, greg k-h -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDFBC433F5 for ; Mon, 28 Feb 2022 20:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbiB1U7x (ORCPT ); Mon, 28 Feb 2022 15:59:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbiB1U7x (ORCPT ); Mon, 28 Feb 2022 15:59:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2469369F5; Mon, 28 Feb 2022 12:59:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 601AAB8165B; Mon, 28 Feb 2022 20:59:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2DB6C340F1; Mon, 28 Feb 2022 20:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646081951; bh=9DFC8+ejskEuUZnsxASmagFdYxR7Vh6yUJxTxyJU0xE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tzy0WmcNphDKxKnlaRvvOyPdgQBhuO0l/KoeJ7U6GP4aZf9Mh4WP7YcIkQdI9MFzh 49Z4FcShoqj5QXNuByQCBzPR3Zt9GN8p404dvaCWnNY4HP44O8BVnjQ40n5gYrBcrb WGe87xcp5dnQgIp90N36AsWlRfaCX5S6k4mhnq9U= Date: Mon, 28 Feb 2022 21:59:08 +0100 From: Greg KH To: Giovanni Cabiddu Cc: Linus Torvalds , Kyle Sanderson , Herbert Xu , Dave Chinner , qat-linux@intel.com, Linux-Kernal , linux-xfs , Linux Crypto Mailing List , device-mapper development Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Message-ID: References: <20220219210354.GF59715@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Feb 28, 2022 at 08:39:11PM +0000, Giovanni Cabiddu wrote: > On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote: > > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > > > > > Makes sense - this kernel driver has been destroying users for many > > > years. I'm disappointed that this critical bricking failure isn't > > > searchable for others. > > > > It does sound like we should just disable that driver entirely until > > it is fixed. > > > > Or at least the configuration that can cause problems, if there is > > some particular sub-case. > The dm-crypt + QAT use-case is already disabled since kernel 5.10 due to > a different issue. > Is it an option to port those patches to stable till I provide a fix for > the driver? I drafted already few alternatives for the fix and I am aiming > for a final set by end of week. If the existing situation is broken, yes, those patches are fine for stable releases. thanks, greg k-h