From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH nf] netfilter: fix use-after-free in __nf_register_net_hook()
Date: Mon, 28 Feb 2022 22:35:15 +0100 [thread overview]
Message-ID: <Yh1AEzg4OHvcCECE@salvia> (raw)
In-Reply-To: <20220227180141.931857-1-eric.dumazet@gmail.com>
On Sun, Feb 27, 2022 at 10:01:41AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> We must not dereference @new_hooks after nf_hook_mutex has been released,
> because other threads might have freed our allocated hooks already.
>
> BUG: KASAN: use-after-free in nf_hook_entries_get_hook_ops include/linux/netfilter.h:130 [inline]
> BUG: KASAN: use-after-free in hooks_validate net/netfilter/core.c:171 [inline]
> BUG: KASAN: use-after-free in __nf_register_net_hook+0x77a/0x820 net/netfilter/core.c:438
> Read of size 2 at addr ffff88801c1a8000 by task syz-executor237/4430
Applied, thanks.
prev parent reply other threads:[~2022-02-28 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 18:01 [PATCH nf] netfilter: fix use-after-free in __nf_register_net_hook() Eric Dumazet
2022-02-27 18:07 ` Florian Westphal
2022-02-28 21:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh1AEzg4OHvcCECE@salvia \
--to=pablo@netfilter.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.