From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nf-next PATCH] netfilter: conntrack: Relax helper auto-assignment warning for nftables
Date: Sat, 19 Feb 2022 15:02:54 +0100 [thread overview]
Message-ID: <YhD4jmfJE1MSdnzg@orbyte.nwl.cc> (raw)
In-Reply-To: <20220219134159.GB27537@breakpoint.cc>
On Sat, Feb 19, 2022 at 02:41:59PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > I tried, but nf_ct_pernet() is not usable from module context, or
> > actually symbol nf_conntrack_net_id. So I had to introduce a routine to
> > set the value. On the other hand I didn't like the fact that it would
> > permanently disable the warning even after 'nft flush ruleset'
> > (nit-picking).
> > I can recover that approach and send a v2 if you think (re-)using refcnt
> > is a bad idea here.
>
> I think its a good idea to add a helper function disable the warning.
>
> We can also call it from xt_CT.c.
OK, I'll prepare a v2. Thanks!
prev parent reply other threads:[~2022-02-19 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 13:20 [nf-next PATCH] netfilter: conntrack: Relax helper auto-assignment warning for nftables Phil Sutter
2022-02-19 13:25 ` Florian Westphal
2022-02-19 13:32 ` Phil Sutter
2022-02-19 13:41 ` Florian Westphal
2022-02-19 14:02 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhD4jmfJE1MSdnzg@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.