From: Eric Biggers <ebiggers@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 1/3] random: unify early init crng load accounting
Date: Sun, 20 Feb 2022 21:50:37 -0800 [thread overview]
Message-ID: <YhMoLad2U2zJVTyo@sol.localdomain> (raw)
In-Reply-To: <20220212231022.679926-2-Jason@zx2c4.com>
On Sun, Feb 13, 2022 at 12:10:20AM +0100, Jason A. Donenfeld wrote:
> -static size_t crng_fast_load(const void *cp, size_t len)
> +static size_t crng_pre_init_inject(const void *cp, size_t len,
> + bool fast, bool account)
This would be a good chance to rename 'cp' to something more usual, like 'in'.
Also, there's still a mention of "crng_{fast,slow}_load" in crng_make_state().
> + const u8 *src = cp;
> +
> + if (fast) {
> + if (!spin_trylock_irqsave(&base_crng.lock, flags))
> + return 0;
> + } else
> + spin_lock_irqsave(&base_crng.lock, flags);
Nit: the kernel coding style requires braces around the else clause here.
- Eric
next prev parent reply other threads:[~2022-02-21 5:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 23:10 [PATCH 0/3] cleanup init-time fast/slow key loading Jason A. Donenfeld
2022-02-12 23:10 ` [PATCH 1/3] random: unify early init crng load accounting Jason A. Donenfeld
2022-02-13 6:55 ` Dominik Brodowski
2022-02-13 10:56 ` Jason A. Donenfeld
2022-02-21 5:50 ` Eric Biggers [this message]
2022-02-21 15:22 ` Jason A. Donenfeld
2022-02-12 23:10 ` [PATCH 2/3] random: check for crng_init == 0, not crng_ready() in add_device_randomness() Jason A. Donenfeld
2022-02-13 6:55 ` Dominik Brodowski
2022-02-21 5:38 ` Eric Biggers
2022-02-12 23:10 ` [PATCH 3/3] random: use trylock in irq handler rather than spinning Jason A. Donenfeld
2022-02-13 6:55 ` Dominik Brodowski
2022-02-13 10:51 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhMoLad2U2zJVTyo@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.