From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Lucas Stach <l.stach@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH] soc: imx: gpcv2: Fix clock disabling imbalance in error path
Date: Mon, 21 Feb 2022 08:29:24 +0200 [thread overview]
Message-ID: <YhMxRB3sag1vcDOt@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220221055929.GM2249@dragon>
Hello Shawn,
On Mon, Feb 21, 2022 at 01:59:29PM +0800, Shawn Guo wrote:
> On Fri, Feb 18, 2022 at 11:57:20PM +0200, Laurent Pinchart wrote:
> > The imx_pgc_power_down() starts by enabling the domain clocks, and thus
> > disables them in the error path. Commit 18c98573a4cf ("soc: imx: gpcv2:
> > add domain option to keep domain clocks enabled") made the clock enable
> > conditional, but forgot to add the same condition to the error path.
> > This can result in a clock enable/disable imbalance. Fix it.
> >
> > Fixes: 18c98573a4cf ("soc: imx: gpcv2: add domain option to keep domain clocks enabled")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Applied, thanks!
Thank you.
I've noticed that Lucas' reviewed-by tag didn't end up in the commit in
your imx/fixes branch. Depending on your rebase policy with that branch,
you may want to ammend the commit.
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-21 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 21:57 [PATCH] soc: imx: gpcv2: Fix clock disabling imbalance in error path Laurent Pinchart
2022-02-18 22:55 ` Lucas Stach
2022-02-21 5:59 ` Shawn Guo
2022-02-21 6:29 ` Laurent Pinchart [this message]
2022-02-21 7:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhMxRB3sag1vcDOt@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.