From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0ED0C433F5 for ; Mon, 21 Feb 2022 15:57:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 55EF84B1D1; Mon, 21 Feb 2022 10:57:33 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lQfU6XCtLexc; Mon, 21 Feb 2022 10:57:32 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2BE274B133; Mon, 21 Feb 2022 10:57:32 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 362424B128 for ; Mon, 21 Feb 2022 10:57:31 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MCSyyrMRji90 for ; Mon, 21 Feb 2022 10:57:29 -0500 (EST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9EDA64B120 for ; Mon, 21 Feb 2022 10:57:29 -0500 (EST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1863EB81239; Mon, 21 Feb 2022 15:57:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C24BC340E9; Mon, 21 Feb 2022 15:57:23 +0000 (UTC) Date: Mon, 21 Feb 2022 15:57:20 +0000 From: Catalin Marinas To: Mark Brown Subject: Re: [PATCH v11 11/40] arm64/sme: Identify supported SME vector lengths at boot Message-ID: References: <20220207152109.197566-1-broonie@kernel.org> <20220207152109.197566-12-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220207152109.197566-12-broonie@kernel.org> Cc: Basant Kumar Dwivedi , Will Deacon , Luis Machado , Szabolcs Nagy , Marc Zyngier , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Alan Hayward , Shuah Khan , kvmarm@lists.cs.columbia.edu, Salil Akerkar X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Feb 07, 2022 at 03:20:40PM +0000, Mark Brown wrote: > @@ -977,6 +984,14 @@ void __init init_cpu_features(struct cpuinfo_arm64 *info) > vec_init_vq_map(ARM64_VEC_SVE); > } > > + if (id_aa64pfr1_sme(info->reg_id_aa64pfr1)) { > + init_cpu_ftr_reg(SYS_SMCR_EL1, info->reg_smcr); > + if (IS_ENABLED(CONFIG_ARM64_SME)) { > + sme_kernel_enable(NULL); > + vec_init_vq_map(ARM64_VEC_SME); > + } > + } Why do we need to call sme_kernel_enable() here? It's called again later via the cpufeature framework. I guess you need the CPACR_EL1 setup but we don't seem to do this for SVE. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10348C433EF for ; Mon, 21 Feb 2022 15:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379075AbiBUP5x (ORCPT ); Mon, 21 Feb 2022 10:57:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234184AbiBUP5w (ORCPT ); Mon, 21 Feb 2022 10:57:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93AFF25C4A for ; Mon, 21 Feb 2022 07:57:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3A7D9B8123F for ; Mon, 21 Feb 2022 15:57:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C24BC340E9; Mon, 21 Feb 2022 15:57:23 +0000 (UTC) Date: Mon, 21 Feb 2022 15:57:20 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v11 11/40] arm64/sme: Identify supported SME vector lengths at boot Message-ID: References: <20220207152109.197566-1-broonie@kernel.org> <20220207152109.197566-12-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207152109.197566-12-broonie@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Feb 07, 2022 at 03:20:40PM +0000, Mark Brown wrote: > @@ -977,6 +984,14 @@ void __init init_cpu_features(struct cpuinfo_arm64 *info) > vec_init_vq_map(ARM64_VEC_SVE); > } > > + if (id_aa64pfr1_sme(info->reg_id_aa64pfr1)) { > + init_cpu_ftr_reg(SYS_SMCR_EL1, info->reg_smcr); > + if (IS_ENABLED(CONFIG_ARM64_SME)) { > + sme_kernel_enable(NULL); > + vec_init_vq_map(ARM64_VEC_SME); > + } > + } Why do we need to call sme_kernel_enable() here? It's called again later via the cpufeature framework. I guess you need the CPACR_EL1 setup but we don't seem to do this for SVE. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4324BC433EF for ; Mon, 21 Feb 2022 15:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o3POTbCl/9MbatzTVT33GHGazvDpBNCktnEhhJ3QA+o=; b=iG6T6ve61kqoTk N0RtPETzCro4+J5uZsWZp81fbAtuacLWteIzNekuM18ChsKvfpgKm7HGpvvgcZJo81qAM45SoHUyW uQ9duwrOv7nIGQ0clD50HXGQQWp6+tBsp5YFAOf4pGOOllGDn79R7LQ3LiIAINuOGw1AymeraPPTI xENo9PQpAdpxHQZGfe3xhx6Huym0jVvy3xJhEzRG2v/kFtsSs/Jv9jGRBDs4VaKzgp2MAvtnYauC0 HxKu2qRdQwarwqvbMG7qseuRLjHGSCR6mY+FKCHZr32efVl+CJl6limtWS3qdhRuM8mUlcsFStST1 G7DJcXkGHNdRnP6kD/dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMB4D-006XGx-3K; Mon, 21 Feb 2022 15:57:37 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMB47-006XEj-2X for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 15:57:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1863EB81239; Mon, 21 Feb 2022 15:57:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C24BC340E9; Mon, 21 Feb 2022 15:57:23 +0000 (UTC) Date: Mon, 21 Feb 2022 15:57:20 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v11 11/40] arm64/sme: Identify supported SME vector lengths at boot Message-ID: References: <20220207152109.197566-1-broonie@kernel.org> <20220207152109.197566-12-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220207152109.197566-12-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_075731_318714_B79DE11B X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 07, 2022 at 03:20:40PM +0000, Mark Brown wrote: > @@ -977,6 +984,14 @@ void __init init_cpu_features(struct cpuinfo_arm64 *info) > vec_init_vq_map(ARM64_VEC_SVE); > } > > + if (id_aa64pfr1_sme(info->reg_id_aa64pfr1)) { > + init_cpu_ftr_reg(SYS_SMCR_EL1, info->reg_smcr); > + if (IS_ENABLED(CONFIG_ARM64_SME)) { > + sme_kernel_enable(NULL); > + vec_init_vq_map(ARM64_VEC_SME); > + } > + } Why do we need to call sme_kernel_enable() here? It's called again later via the cpufeature framework. I guess you need the CPACR_EL1 setup but we don't seem to do this for SVE. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel