From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6F3CC433F5 for ; Mon, 21 Feb 2022 12:43:12 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9BEDD3CA17E for ; Mon, 21 Feb 2022 13:43:10 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id B04F93C96D5 for ; Mon, 21 Feb 2022 13:43:01 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 700481001158 for ; Mon, 21 Feb 2022 13:42:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 561211F391; Mon, 21 Feb 2022 12:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645447379; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HAqGmbOcqPpLArVut/VQf0ussrFzfva7N/1NlmU3N3k=; b=0ImBIVKasqBwg0HqIyK8iNWtybv9IzkZtDzfFKhFvW3U5VeZdiNl22AztlDvTxO7Pa5hR2 HDYRiW87ZYVYf+uzLxfCDa+ig9F2CWkEl6sLuQ7B0uDzyBg35aRMWuFEB04QSFrie92Z56 ZwLrJz3loC9OSXPtb5v0WagNeVxENzY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645447379; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HAqGmbOcqPpLArVut/VQf0ussrFzfva7N/1NlmU3N3k=; b=V8YevgIasf1S3tyKrBcRu1S669cvaBTcg4+2GY+csfik62uGJRIgWcqxann12AYA4nz/Wm kpq6pYXZgIFxVaAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29BC913AC3; Mon, 21 Feb 2022 12:42:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W/enCNOIE2LaawAAMHmgww (envelope-from ); Mon, 21 Feb 2022 12:42:59 +0000 Date: Mon, 21 Feb 2022 13:42:57 +0100 From: Petr Vorel To: Richard Palethorpe Message-ID: References: <1645005868-2373-1-git-send-email-xuyang2018.jy@fujitsu.com> <1645005868-2373-4-git-send-email-xuyang2018.jy@fujitsu.com> <620F118E.3070306@fujitsu.com> <87k0dojy5j.fsf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87k0dojy5j.fsf@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 4/5] Add pidfd_getfd01 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Richie, > Hello Petr, > Petr Vorel writes: > > Hi Richie, Xu, > >> Hi Petr > >> > Hi Xu, > >> > ... > >> >> +++ b/testcases/kernel/syscalls/pidfd_getfd/pidfd_getfd01.c > >> > ... > >> >> + remotefd = TST_RET; > >> >> + flag = fcntl(remotefd, F_GETFD); > >> >> + if (flag == -1) > >> >> + tst_brk(TFAIL | TERRNO, "fcntl(F_GETFD) failed"); > >> > Just: > >> > flag = SAFE_FCNTL(remotefd, F_GETFD); > >> Yes, I almost forgot we have this macro. > > @Richie: It'd be useful if sparse checks would suggest to use SAFE_*() > > functions, but not sure if easily detectable. Something like setup() and > > cleanup() function and syscall followed by if (foo == -1) followed by tst_brk(). > > Kind regards, > > Petr > Yeah, this would be relatively simple in Coccinelle. In Sparse I'm not > sure, but it is one of the main use cases IMO. I remember few years ago (2017) metan did big cleanup with Coccinelle. If much simpler, we might want to introduce some basic scripts (without vendoring Coccinelle, it'd have to be installed). > Hopefully the IR produced by these code patterns is fairly stable. In > that case we can do some simple pattern matching. Frankly speaking, if ever implemented it's probably you who is going to implement it, thus your choice what you use :). Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp