From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [RFC??[DO_NOT_MERGE][PATCH v2 1/1] netstress: Fix race between SETSID() and exit(0)
Date: Mon, 21 Feb 2022 14:36:19 +0100 [thread overview]
Message-ID: <YhOVU92yOLJSWiV2@pevik> (raw)
In-Reply-To: <YhOTEWKaPpn9Z3yX@yuki>
Hi Cyril,
merged, thanks!
> > Yes, this looks like enough. Do you want me to merge this proposal with added
> > this change? Or you send a patch or just merge fix yourself?
> Just merge it all into a single patch.
Sure this was to go to single commit, just wasn't sure if you want to merge it.
> > > However the debugging took longer than I wanted to since the network
> > > tests are such a mess. The server does exit by TBROK (which looks like
> > > it's an expected behavior), only half of the sever log is printed on a
> > > failure, etc. These should really deserve some cleanups...
> > I'd say specifically tst_netload() (in tst_net.sh) and netstress.c deserve
> > cleanup. Also, as we noticed several times shell tests tends to be buggy,
> > specially in combination with C tests. But not sure if feasible to write
> > everything in C.
> I guess that we can do some minor fixes, but the whole codebase looks
> like it needs to be rethinked and redesigned...
+1
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-02-21 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 16:48 [LTP] [RFCŊ[DO_NOT_MERGE][PATCH v2 1/1] netstress: Fix race between SETSID() and exit(0) Petr Vorel
2022-02-18 17:28 ` Petr Vorel
2022-02-21 13:05 ` [LTP] [RFC??[DO_NOT_MERGE][PATCH " Cyril Hrubis
2022-02-21 13:13 ` Petr Vorel
2022-02-21 13:26 ` Cyril Hrubis
2022-02-21 13:36 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhOVU92yOLJSWiV2@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.