From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
Fernando Fernandez Mancera <ffmancera@riseup.net>
Subject: Re: [PATCH v3] netfilter: nf_tables: fix memory leak during stateful obj update
Date: Mon, 21 Feb 2022 15:51:13 +0100 [thread overview]
Message-ID: <YhOm4e8fdfZU9Qd5@salvia> (raw)
In-Reply-To: <20220221123149.11519-1-fw@strlen.de>
On Mon, Feb 21, 2022 at 01:31:49PM +0100, Florian Westphal wrote:
> stateful objects can be updated from the control plane.
> The transaction logic allocates a temporary object for this purpose.
>
> The ->init function was called for this object, so plain kfree() leaks
> resources. We must call ->destroy function of the object.
>
> nft_obj_destroy does this, but it also decrements the module refcount,
> but the update path doesn't increment it.
>
> To avoid special-casing the update object release, do module_get for
> the update case too and release it via nft_obj_destroy().
Also applied, thanks
next prev parent reply other threads:[~2022-02-21 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 12:31 [PATCH v3] netfilter: nf_tables: fix memory leak during stateful obj update Florian Westphal
2022-02-21 14:51 ` Pablo Neira Ayuso [this message]
2022-02-21 17:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhOm4e8fdfZU9Qd5@salvia \
--to=pablo@netfilter.org \
--cc=ffmancera@riseup.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.