All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Douglas Miller <dougmill@linux.vnet.ibm.com>
Cc: keyrings@vger.kernel.org, gjoyce@ibm.com, dhowells@redhat.com
Subject: Re: [PATCH RESEND 1/1] keys: Allow access to key_type_lookup()/key_type_put() within kernel.
Date: Mon, 21 Feb 2022 21:28:16 +0100	[thread overview]
Message-ID: <YhP14Flme60pk7Pu@iki.fi> (raw)
In-Reply-To: <YhP1xQLJgQAT0r9j@iki.fi>

On Mon, Feb 21, 2022 at 09:27:57PM +0100, Jarkko Sakkinen wrote:
> On Mon, Feb 21, 2022 at 08:44:24AM -0600, Douglas Miller wrote:
> > Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
> > ---
> >  include/linux/key-type.h | 2 ++
> >  security/keys/key.c      | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/include/linux/key-type.h b/include/linux/key-type.h
> > index 7d985a1dfe4a..868a6fb368f3 100644
> > --- a/include/linux/key-type.h
> > +++ b/include/linux/key-type.h
> > @@ -165,6 +165,8 @@ extern struct key_type key_type_keyring;
> >  
> >  extern int register_key_type(struct key_type *ktype);
> >  extern void unregister_key_type(struct key_type *ktype);
> > +extern struct key_type *key_type_lookup(const char *type);
> > +extern void key_type_put(struct key_type *ktype);
> >  
> >  extern int key_payload_reserve(struct key *key, size_t datalen);
> >  extern int key_instantiate_and_link(struct key *key,
> > diff --git a/security/keys/key.c b/security/keys/key.c
> > index c45afdd1dfbb..3091fd6d65a7 100644
> > --- a/security/keys/key.c
> > +++ b/security/keys/key.c
> > @@ -719,6 +719,7 @@ struct key_type *key_type_lookup(const char *type)
> >  found_kernel_type:
> >  	return ktype;
> >  }
> > +EXPORT_SYMBOL(key_type_lookup);
> >  
> >  void key_set_timeout(struct key *key, unsigned timeout)
> >  {
> > @@ -744,6 +745,7 @@ void key_type_put(struct key_type *ktype)
> >  {
> >  	up_read(&key_types_sem);
> >  }
> > +EXPORT_SYMBOL(key_type_put);
> >  
> >  /*
> >   * Attempt to update an existing key.
> > -- 
> > 2.27.0
> > 
> 
> This should be included with the changes that actually require this.

I.e. planned changes do not count.

BR, Jarkko

      reply	other threads:[~2022-02-21 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 14:44 [PATCH RESEND 0/1] keys: Allow access to key_type_lookup Douglas Miller
2022-02-21 14:44 ` [PATCH RESEND 1/1] keys: Allow access to key_type_lookup()/key_type_put() within kernel Douglas Miller
2022-02-21 20:27   ` Jarkko Sakkinen
2022-02-21 20:28     ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhP14Flme60pk7Pu@iki.fi \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=dougmill@linux.vnet.ibm.com \
    --cc=gjoyce@ibm.com \
    --cc=keyrings@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.