From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00778C433EF for ; Tue, 22 Feb 2022 07:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbiBVHnB (ORCPT ); Tue, 22 Feb 2022 02:43:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231266AbiBVHmw (ORCPT ); Tue, 22 Feb 2022 02:42:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37C5459A56; Mon, 21 Feb 2022 23:42:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C83FF61224; Tue, 22 Feb 2022 07:42:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2F5BC340E8; Tue, 22 Feb 2022 07:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645515746; bh=dBeDgEG5rHIyM94zUzickINy/WRIcWRAB6nD1Yps1Q0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mrEJXmP/SYcYGeltdY4YDilJhpCswQPVZNDGsHreyT49gk+uJjqBTLR4yjhBv404v C2CckRQ49qZWvWB+NiofVM6D0QOF9FZcYpXCjl2C5Qp1sHRuMqbK6KSXXcgcbsvnT/ H0FzQDSnMol40aft1+v0pM5tN7x0W95TMWJtqESs= Date: Tue, 22 Feb 2022 08:42:23 +0100 From: "gregkh@linuxfoundation.org" To: Ricky WU Cc: "ulf.hansson@linaro.org" , "kai.heng.feng@canonical.com" , "tommyhebb@gmail.com" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mmc: rtsx: add 74 Clocks in power on flow Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Tue, Feb 22, 2022 at 07:27:52AM +0000, Ricky WU wrote: > After 1ms stabilizing the voltage time > add "Host provides at least 74 Clocks > before issuing first command" that is > spec definition You do have 72 columns to use here, no need to wrap this so tightly. > > Signed-off-by: Ricky Wu > --- > drivers/mmc/host/rtsx_pci_sdmmc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c > index 2a3f14afe9f8..e016d720e453 100644 > --- a/drivers/mmc/host/rtsx_pci_sdmmc.c > +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c > @@ -940,10 +940,17 @@ static int sd_power_on(struct realtek_pci_sdmmc *host) > if (err < 0) > return err; > > + mdelay(1); What is this delay for? thanks, greg k-h