From: Jarkko Sakkinen <jarkko@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: "Mickaël Salaün" <mic@linux.microsoft.com>,
"open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>,
linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")?
Date: Wed, 23 Feb 2022 16:49:52 +0100 [thread overview]
Message-ID: <YhZXoPqSdfdXEfgx@iki.fi> (raw)
In-Reply-To: <CAKXUXMwrvq=aDWcZRKk-0UEiKQtywDbiVSJnsxnAc_sBoSNY6w@mail.gmail.com>
On Wed, Feb 23, 2022 at 02:50:42PM +0100, Lukas Bulwahn wrote:
> Dear Jarkko, dear Mickaël,
>
> The commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes
> are valid") adds a file entry for scripts/extract-cert.c in the
> CERTIFICATE HANDLING section in MAINTAINERS.
>
> Hence, ./scripts/get_maintainers.pl --self-test=patterns complains:
>
> warning: no file matches F: scripts/extract-cert.c
>
> I could not see that line being added in the original patch, i.e.,
> https://lore.kernel.org/all/20210712170313.884724-3-mic@digikod.net/,
> but it was only part of the context of that patch. In linux-next, it
> appears to be part of the commit above.
>
> That seems to be introduced while applying or rebasing the patch to
> some later version. If that is the case, you can probably just drop
> this line "F: scripts/extract-cert.c" in the MAINTAINERS file.
Thank you, I removed the entry. I had to solve a merge conflict with
this patch, and made a human error.
BR, Jarkko
prev parent reply other threads:[~2022-02-23 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:50 Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")? Lukas Bulwahn
2022-02-23 15:49 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhZXoPqSdfdXEfgx@iki.fi \
--to=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mic@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.