Re: [Buildroot] [PATCH v4 1/3] board/andes: rearrange andes folder structure

[Yu Chien Peter Lin <peterlin@andestech.com>]

Hi Giulio,

> > > > > > Changes v3 -> v4:
> > > > > >      - rename ae3xx folder to ae300
> > > > > >      - rename andes_ae3xx_defconfig to andes_ae300_defconfig
> > > > > >      - update readme.txt and item in DEVELOPERS
> > > > > 
> > > > > Some of these change ^^^ must have been moved to the single patch, like
> > > > > DEVELOPERS is updated in patch 3/3. I've also forgotten to point you to add
> > > > > a --cover-letter, so keep in mind both points for next time.
> > > > > 
> > > > > I've built tested both defconfig successfully, so:
> > > > > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > > > > Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > > > > [Giulio: build tested only]
> > > > > 
> > > > > And the other patches of this series is all reviewed, so to me it's ready to
> > > > > be committed, but this will happen after Buildroot 2022.02 is released,
> > > > > since between rc1 to the release Maintainers only accept fixes. Another
> > > > > possibility is that they will commit these patches to next branch.
> > > > > 
> > > > > Please remember to tag V3.

Oh, I thought you were refering to format-patch with v3, sorry.
I will mark the patch on patchwork to rejected state except the latest 
patch version.

> > > > > Thank you for your effort!
> > > > > 
> > > > > Best regards
> > > > > -- 
> > > > > Giulio Benetti
> > > > > Benetti Engineering sas
> > > 
> > > Thanks for reviewing my patches and the guidance.
> > 
> > You're welcome.
> > 
> > > I will make a new patch for the Config.in,
> > 
> > Which one? I only see:
> > toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in
> > 
> > Do you mean you will add an entry in DEVELOPERS for it?

I found the modifications on these files in Git history, usually have 
its own patch. So in PATCH v5, I will split [PATCH 1/3] to [PATCH 1/4] 
and [PATCH 2/4] for
toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in
other patches remain the same, and attach [PATCH 0/4] cover letter.

> > > The last question, is it tag V5 for the next submission?
> > 
> > It depends if you need to modify these patches. Or if you add a new patch
> > that depends on these patches, then yes, please send a V5 with all changes
> > moved to the different patches, including adding the patch if this is your
> > goal.
> > 
> > Best regards
> > -- 
> > Giulio Benetti
> > Benetti Engineering sas

Is there any the new comment?
Again, thanks for your help. :)

Best regards,
Yu Chien Peter Lin
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot