* [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5
@ 2022-02-24 3:45 Yifan Zhang
2022-02-24 3:47 ` Alex Deucher
2022-02-24 3:49 ` Huang Rui
0 siblings, 2 replies; 3+ messages in thread
From: Yifan Zhang @ 2022-02-24 3:45 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Yifan Zhang, Ray.Huang
SMU MSG index should be used as parameter.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
index 093b9144464b..8ee5bcb60370 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
@@ -245,14 +245,9 @@ static int smu_v13_0_5_post_smu_init(struct smu_context *smu)
static int smu_v13_0_5_mode_reset(struct smu_context *smu, int type)
{
- int ret = 0, index = 0;
-
- index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG,
- SMU_MSG_GfxDeviceDriverReset);
- if (index < 0)
- return index == -EACCES ? 0 : index;
+ int ret = 0;
- ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index, type, NULL);
+ ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_GfxDeviceDriverReset, type, NULL);
if (ret)
dev_err(smu->adev->dev, "Failed to mode reset!\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5
2022-02-24 3:45 [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5 Yifan Zhang
@ 2022-02-24 3:47 ` Alex Deucher
2022-02-24 3:49 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2022-02-24 3:47 UTC (permalink / raw)
To: Yifan Zhang; +Cc: Deucher, Alexander, Huang Rui, amd-gfx list
On Wed, Feb 23, 2022 at 10:46 PM Yifan Zhang <yifan1.zhang@amd.com> wrote:
>
> SMU MSG index should be used as parameter.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> index 093b9144464b..8ee5bcb60370 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> @@ -245,14 +245,9 @@ static int smu_v13_0_5_post_smu_init(struct smu_context *smu)
>
> static int smu_v13_0_5_mode_reset(struct smu_context *smu, int type)
> {
> - int ret = 0, index = 0;
> -
> - index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG,
> - SMU_MSG_GfxDeviceDriverReset);
> - if (index < 0)
> - return index == -EACCES ? 0 : index;
> + int ret = 0;
>
> - ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index, type, NULL);
> + ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_GfxDeviceDriverReset, type, NULL);
> if (ret)
> dev_err(smu->adev->dev, "Failed to mode reset!\n");
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5
2022-02-24 3:45 [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5 Yifan Zhang
2022-02-24 3:47 ` Alex Deucher
@ 2022-02-24 3:49 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Huang Rui @ 2022-02-24 3:49 UTC (permalink / raw)
To: Zhang, Yifan; +Cc: Deucher, Alexander, amd-gfx@lists.freedesktop.org
On Thu, Feb 24, 2022 at 11:45:43AM +0800, Zhang, Yifan wrote:
> SMU MSG index should be used as parameter.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> index 093b9144464b..8ee5bcb60370 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> @@ -245,14 +245,9 @@ static int smu_v13_0_5_post_smu_init(struct smu_context *smu)
>
> static int smu_v13_0_5_mode_reset(struct smu_context *smu, int type)
> {
> - int ret = 0, index = 0;
> -
> - index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG,
> - SMU_MSG_GfxDeviceDriverReset);
> - if (index < 0)
> - return index == -EACCES ? 0 : index;
> + int ret = 0;
>
> - ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index, type, NULL);
> + ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_GfxDeviceDriverReset, type, NULL);
> if (ret)
> dev_err(smu->adev->dev, "Failed to mode reset!\n");
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-24 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-24 3:45 [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5 Yifan Zhang
2022-02-24 3:47 ` Alex Deucher
2022-02-24 3:49 ` Huang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.