From: Thierry Reding <thierry.reding@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/5] tty: serial: make use of UART_LCR_WLEN() + tty_get_char_size()
Date: Thu, 24 Feb 2022 17:38:03 +0100 [thread overview]
Message-ID: <Yhe0a0RX8XTBF8BL@orome> (raw)
In-Reply-To: <20220224095558.30929-2-jslaby@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Thu, Feb 24, 2022 at 10:55:55AM +0100, Jiri Slaby wrote:
> Having a generic UART_LCR_WLEN() macro and the tty_get_char_size()
> helper, we can remove all those repeated switch-cases in drivers.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-tegra@vger.kernel.org
> ---
> drivers/tty/serial/8250/8250_omap.c | 16 +---------------
> drivers/tty/serial/8250/8250_port.c | 16 +---------------
> drivers/tty/serial/jsm/jsm_cls.c | 16 +---------------
> drivers/tty/serial/jsm/jsm_neo.c | 16 +---------------
> drivers/tty/serial/omap-serial.c | 16 +---------------
> drivers/tty/serial/pxa.c | 16 +---------------
> drivers/tty/serial/serial-tegra.c | 22 ++++------------------
> drivers/tty/serial/vr41xx_siu.c | 15 +--------------
> 8 files changed, 11 insertions(+), 122 deletions(-)
This would've been easier to review if I had this in my inbox, but I did
find it on lkml.org and this does look correct, so:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-24 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 9:55 [PATCH 0/5] UART_LCR_WLEN cleanups Jiri Slaby
2022-02-24 9:55 ` [PATCH 1/5] tty: serial: define UART_LCR_WLEN() macro Jiri Slaby
2022-02-24 9:55 ` [PATCH 2/5] tty: serial: make use of UART_LCR_WLEN() + tty_get_char_size() Jiri Slaby
2022-02-24 16:38 ` Thierry Reding [this message]
2022-02-24 9:55 ` [PATCH 3/5] USB: " Jiri Slaby
2022-02-24 9:55 ` [PATCH 4/5] sdio_uart: " Jiri Slaby
2022-02-28 16:16 ` Ulf Hansson
2022-02-24 9:55 ` [PATCH 5/5] mxser: " Jiri Slaby
2022-02-24 10:10 ` [PATCH 1/5] tty: serial: define UART_LCR_WLEN() macro Greg KH
2022-02-24 10:42 ` Jiri Slaby
2022-02-24 11:23 ` Greg KH
2022-02-25 9:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhe0a0RX8XTBF8BL@orome \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=jslaby@suse.cz \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.