From: Rob Herring <robh@kernel.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
jassisinghbrar@gmail.com, manivannan.sadhasivam@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: mailbox: Add binding for SDX65 APCS
Date: Thu, 24 Feb 2022 14:05:24 -0600 [thread overview]
Message-ID: <YhflBNX/iRsC8LBq@robh.at.kernel.org> (raw)
In-Reply-To: <1645420953-21176-2-git-send-email-quic_rohiagar@quicinc.com>
On Mon, Feb 21, 2022 at 10:52:27AM +0530, Rohit Agarwal wrote:
> Add devicetree YAML binding for SDX65 APCS GCC block. The APCS block
> acts as the mailbox controller and also provides a clock output and
> takes 3 clock sources (pll, aux, ref) as input.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 01e9d91..688ae8b 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -91,6 +91,7 @@ allOf:
> compatible:
> enum:
> - qcom,sdx55-apcs-gcc
> + - qcom,sdx65-apcs-gcc
Did you test this on your dts file? This doesn't work. You need to also
add the compatible to the main 'compatible' schema.
> then:
> properties:
> clocks:
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2022-02-24 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 5:22 [PATCH v3 0/7] Add APCS support for SDX65 Rohit Agarwal
2022-02-21 5:22 ` [PATCH v3 1/7] dt-bindings: mailbox: Add binding for SDX65 APCS Rohit Agarwal
2022-02-24 20:05 ` Rob Herring [this message]
2022-02-21 5:22 ` [PATCH v3 2/7] mailbox: qcom: Add support for SDX65 APCS IPC Rohit Agarwal
2022-02-21 5:35 ` Manivannan Sadhasivam
2022-02-21 7:29 ` Rohit Agarwal
2022-02-21 5:22 ` [PATCH v3 3/7] dt-bindings: clock: Add A7 PLL binding for SDX65 Rohit Agarwal
2022-02-21 5:22 ` [PATCH v3 4/7] clk: qcom: Add A7 PLL support " Rohit Agarwal
2022-02-21 5:40 ` Manivannan Sadhasivam
2022-02-21 7:27 ` Rohit Agarwal
2022-02-21 5:22 ` [PATCH v3 5/7] ARM: dts: qcom: sdx65: Add support for A7 PLL clock Rohit Agarwal
2022-02-21 5:22 ` [PATCH v3 6/7] ARM: dts: qcom: sdx65: Add support for APCS block Rohit Agarwal
2022-02-21 5:22 ` [PATCH v3 7/7] clk: qcom: Add SDX65 APCS clock controller support Rohit Agarwal
2022-02-21 5:36 ` Manivannan Sadhasivam
2022-02-21 5:44 ` [PATCH v3 0/7] Add APCS support for SDX65 Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhflBNX/iRsC8LBq@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_rohiagar@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.