From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Henry Lin <henryl@nvidia.com>
Cc: "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume
Date: Fri, 25 Feb 2022 07:49:06 +0100 [thread overview]
Message-ID: <Yhh74nrKH5XuRZ/U@kroah.com> (raw)
In-Reply-To: <CH0PR12MB5089EB28FAA6DF61F57F6D09AC3E9@CH0PR12MB5089.namprd12.prod.outlook.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Feb 25, 2022 at 06:40:53AM +0000, Henry Lin wrote:
> It fixes side effect from below change.
>
> commit a231ec41e6f6433daf4c693f169f6c5cfda8cb9d
> Author: Mathias Nyman <mathias.nyman@linux.intel.com>
> Date: Fri Dec 7 16:19:35 2018 +0200
>
> xhci: refactor U0 link state handling in get_port_status
>
> Move U0 link state handing to USB3 and USB2 specific functions
>
> Note that
> bus_state->resuming_ports:
> bus_state->resume_done[]:
> are only used for USB2, and don't need to cleared for USB3 ports
>
> No functional changes
>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Great, please add a "Fixes:" tag to the patch when resubmitting it.
And the "no functional changes" seems not to have been true, right?
Does this need to go into the stable kernels?
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-25 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 5:53 [PATCH] xhci: fix runtime PM imbalance in USB2 resume Henry Lin
2022-02-25 6:23 ` Greg Kroah-Hartman
2022-02-25 6:40 ` Henry Lin
2022-02-25 6:49 ` Greg Kroah-Hartman [this message]
2022-02-25 7:02 ` Henry Lin
2022-02-25 7:15 ` [PATCH v2] " Henry Lin
2022-02-25 9:16 ` Greg KH
2022-02-26 16:06 ` Henry Lin
2022-02-26 16:20 ` Henry Lin
2022-02-28 10:56 ` Mathias Nyman
2022-03-01 10:28 ` Henry Lin
2022-03-01 15:49 ` Mathias Nyman
2022-03-01 19:18 ` Henry Lin
2022-03-02 6:51 ` [PATCH v3] " Henry Lin
2022-03-02 9:16 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhh74nrKH5XuRZ/U@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=henryl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.