From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A071AC433F5 for ; Fri, 25 Feb 2022 11:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LryPXzLjN7S1Kd4NFit7pf7VlYzmGQ/nriZAGz459c0=; b=odqU30fWyTQkky yFflXJhOJjy9tnYOHnvGbKQ9QDWiESuEhrhDMqIWaKC21LlI2ZUb1qSpBn7dNmQNyN4lFzTpNfRog RwYBsEV0oAVD0V5MBIF2rUcG6D1QkX1hqDQCJ71+XkKc0rlHbrR5Z9jLKzMG/jUqIkhIZjadOctnT 67u/7b6JnAz5n1CP4MgTN38FL7hEFQLvxMBtJZ7TcTTZOQJgHp+Av6ERPfu8UQW5H6KfeRCfkEQZd uXxBkkvl44SDrjyEJdhH+WrZ1GFMV2CzKgQXM8OA679qIB7rTM1SLCdNYmJ659y1TWl+QH5HPbtaC 7/idxQ/rHawEgQWn+rgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNYWm-004dTJ-QQ; Fri, 25 Feb 2022 11:12:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNYWj-004dSZ-BW for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 11:12:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BEC2260E65; Fri, 25 Feb 2022 11:12:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9F15C340E7; Fri, 25 Feb 2022 11:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645787564; bh=xQ1H7/Dt7IWJD23VHNYn1uDXQpmUaBskwGY0Yu9Lz2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+T9L5XUbNcAQOMJkpbf85JiXq635m0rOcEz5Uxq6psM6vCsmQ9fPed7c8y8ppM/h JoiYnx91NxM+UbhmX6K4SDc9pJKxP54yHbBXZ5zhUiypE0Yzzc/5dzPe/quom5gCnw D1V929xMFDYqEu3AkQ9HdVbCPVJXcEU1xq6cTlcM= Date: Fri, 25 Feb 2022 12:12:41 +0100 From: Greg KH To: Ronak Jain Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org, rajan.vaja@xilinx.com, corbet@lwn.net, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, lakshmi.sai.krishna.potthuri@xilinx.com Subject: Re: [PATCH v5 3/3] firmware: xilinx: Add sysfs support for feature config Message-ID: References: <20220209082709.32378-1-ronak.jain@xilinx.com> <20220209082709.32378-4-ronak.jain@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220209082709.32378-4-ronak.jain@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_031245_463287_1970754E X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 12:27:09AM -0800, Ronak Jain wrote: > Add support for sysfs interface for runtime features configuration. > The user can configure the features at runtime. First, the user need > to select the config id of the supported features and then the user > can configure the parameters of the feature based on the config id. > > Signed-off-by: Ronak Jain You are adding new sysfs files, without any Documentation/ABI/ entries. That will cause errors when you run the scripts/get_abi.pl tool, right? Please fix. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF24C433F5 for ; Fri, 25 Feb 2022 11:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239976AbiBYLNT (ORCPT ); Fri, 25 Feb 2022 06:13:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239511AbiBYLNS (ORCPT ); Fri, 25 Feb 2022 06:13:18 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F6B1DCCC6 for ; Fri, 25 Feb 2022 03:12:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D752B82D7C for ; Fri, 25 Feb 2022 11:12:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9F15C340E7; Fri, 25 Feb 2022 11:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645787564; bh=xQ1H7/Dt7IWJD23VHNYn1uDXQpmUaBskwGY0Yu9Lz2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+T9L5XUbNcAQOMJkpbf85JiXq635m0rOcEz5Uxq6psM6vCsmQ9fPed7c8y8ppM/h JoiYnx91NxM+UbhmX6K4SDc9pJKxP54yHbBXZ5zhUiypE0Yzzc/5dzPe/quom5gCnw D1V929xMFDYqEu3AkQ9HdVbCPVJXcEU1xq6cTlcM= Date: Fri, 25 Feb 2022 12:12:41 +0100 From: Greg KH To: Ronak Jain Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org, rajan.vaja@xilinx.com, corbet@lwn.net, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, lakshmi.sai.krishna.potthuri@xilinx.com Subject: Re: [PATCH v5 3/3] firmware: xilinx: Add sysfs support for feature config Message-ID: References: <20220209082709.32378-1-ronak.jain@xilinx.com> <20220209082709.32378-4-ronak.jain@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209082709.32378-4-ronak.jain@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 09, 2022 at 12:27:09AM -0800, Ronak Jain wrote: > Add support for sysfs interface for runtime features configuration. > The user can configure the features at runtime. First, the user need > to select the config id of the supported features and then the user > can configure the parameters of the feature based on the config id. > > Signed-off-by: Ronak Jain You are adding new sysfs files, without any Documentation/ABI/ entries. That will cause errors when you run the scripts/get_abi.pl tool, right? Please fix. thanks, greg k-h