From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E0BBC433F5 for ; Fri, 25 Feb 2022 13:25:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CD17D1F16; Fri, 25 Feb 2022 14:24:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CD17D1F16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1645795505; bh=Xwz9kLVHyWZsdxcrnoF/sDH7jLbV2c8FkOg5piNNcDw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tGbRJ8lwYPOaT6htQu6m+N9rYcFvSdx6jnQVpMZSraOroAFDYkRr0zh4f05jFbCGC qMNzuXeKT62hJIWqNdM+cxXnxSeoCUulZJN4HrspNA7SsvctZceEITloWrt8McQOSn A3Idk2nkslznMiRbqAK4yRwA9BNiWb4kqJamFMrM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 50567F8051E; Fri, 25 Feb 2022 14:12:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E869CF80673; Fri, 25 Feb 2022 14:12:29 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AFDF4F80159 for ; Fri, 25 Feb 2022 14:12:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AFDF4F80159 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CTFtdiB9" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E3DC61C41; Fri, 25 Feb 2022 13:12:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5131EC340F1; Fri, 25 Feb 2022 13:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645794742; bh=Xwz9kLVHyWZsdxcrnoF/sDH7jLbV2c8FkOg5piNNcDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CTFtdiB9m3XjyyYr8JjVYHKb9pQ3sUnnAR1ggZoDV1hOgCnkZ85bbVT4OWVWvSVQy QqF8NxW16fMzL1vjsS7LF1elOCvJv9ax/XoBcre5bpmQlXQR7yxdczCTR5Ie5RxiNR 9VwuFLUg2xgTKPGoS436tRrTTbuB+99BQ32k1w8dBQqoc22Vc/VzV+KgEV5ePE4pKq 7v4yFGDmIE82udHcoP4QEIZr87D89BpDnDeak1+Z08Qrp9+0doivOcwfNcHjsUrx51 Y57zCzUSAeeVGeJr86A6fpC4wc2cORjP8tpjnov680IfsJkSQZ2k1fCimue8Z0vNer JCPHgaZxY4ioQ== Date: Fri, 25 Feb 2022 13:12:18 +0000 From: Mark Brown To: Meng Tang Subject: Re: [PATCH] sound/soc/amd: Use platform_get_irq_byname() to get the interrupt Message-ID: References: <20220225112358.19403-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ni88dYQ52S44UoyN" Content-Disposition: inline In-Reply-To: <20220225112358.19403-1-tangmeng@uniontech.com> X-Cookie: I smell a wumpus. Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --Ni88dYQ52S44UoyN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 25, 2022 at 07:23:58PM +0800, Meng Tang wrote: > platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. --Ni88dYQ52S44UoyN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIY1bEACgkQJNaLcl1U h9CMsgf9HCDinfY/9LwPrkDH7m1gZJCWHoophXU3Zw9m91QZ/bwR9Bet0Rnm2mQy 8KCTy5XiW+h0GZ7SyHoHCoFMiKbWOupxRlOb7beVOP13RzlaP9r0DrpgCfva3grA F05FNqMTHslXk1K9iBWZ0B82flpp5XvxWfeQ7K8ZclNrZ/l5qf22/gLOLN5zE+qG rFT41o3+q4n5KD+4hwv4fcRh1/y73rkIDy+YY4enI4yU59voiPQ5B+jMxMU/beo7 jfB4t7sAgys3W+LSvd9nCDuC9K8U2vsS286shhMUvkCtyzduyVeSMkCb+Ah+Ocia 8SwFT8rD1dHuhvNDZrb3L2qNoIc8+g== =XUgy -----END PGP SIGNATURE----- --Ni88dYQ52S44UoyN-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25014C433F5 for ; Fri, 25 Feb 2022 13:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241004AbiBYNNE (ORCPT ); Fri, 25 Feb 2022 08:13:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241024AbiBYNMz (ORCPT ); Fri, 25 Feb 2022 08:12:55 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB016181E55 for ; Fri, 25 Feb 2022 05:12:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55D5961C54 for ; Fri, 25 Feb 2022 13:12:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5131EC340F1; Fri, 25 Feb 2022 13:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645794742; bh=Xwz9kLVHyWZsdxcrnoF/sDH7jLbV2c8FkOg5piNNcDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CTFtdiB9m3XjyyYr8JjVYHKb9pQ3sUnnAR1ggZoDV1hOgCnkZ85bbVT4OWVWvSVQy QqF8NxW16fMzL1vjsS7LF1elOCvJv9ax/XoBcre5bpmQlXQR7yxdczCTR5Ie5RxiNR 9VwuFLUg2xgTKPGoS436tRrTTbuB+99BQ32k1w8dBQqoc22Vc/VzV+KgEV5ePE4pKq 7v4yFGDmIE82udHcoP4QEIZr87D89BpDnDeak1+Z08Qrp9+0doivOcwfNcHjsUrx51 Y57zCzUSAeeVGeJr86A6fpC4wc2cORjP8tpjnov680IfsJkSQZ2k1fCimue8Z0vNer JCPHgaZxY4ioQ== Date: Fri, 25 Feb 2022 13:12:18 +0000 From: Mark Brown To: Meng Tang Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/soc/amd: Use platform_get_irq_byname() to get the interrupt Message-ID: References: <20220225112358.19403-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ni88dYQ52S44UoyN" Content-Disposition: inline In-Reply-To: <20220225112358.19403-1-tangmeng@uniontech.com> X-Cookie: I smell a wumpus. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ni88dYQ52S44UoyN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 25, 2022 at 07:23:58PM +0800, Meng Tang wrote: > platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. --Ni88dYQ52S44UoyN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIY1bEACgkQJNaLcl1U h9CMsgf9HCDinfY/9LwPrkDH7m1gZJCWHoophXU3Zw9m91QZ/bwR9Bet0Rnm2mQy 8KCTy5XiW+h0GZ7SyHoHCoFMiKbWOupxRlOb7beVOP13RzlaP9r0DrpgCfva3grA F05FNqMTHslXk1K9iBWZ0B82flpp5XvxWfeQ7K8ZclNrZ/l5qf22/gLOLN5zE+qG rFT41o3+q4n5KD+4hwv4fcRh1/y73rkIDy+YY4enI4yU59voiPQ5B+jMxMU/beo7 jfB4t7sAgys3W+LSvd9nCDuC9K8U2vsS286shhMUvkCtyzduyVeSMkCb+Ah+Ocia 8SwFT8rD1dHuhvNDZrb3L2qNoIc8+g== =XUgy -----END PGP SIGNATURE----- --Ni88dYQ52S44UoyN--