From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com,
yoshihiro.shimoda.uh@renesas.com, adrian.hunter@intel.com,
swboyd@chromium.org, dev@lynxeye.de, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: core: check the return value of wakeup_source_register()
Date: Fri, 25 Feb 2022 18:54:17 +0200 [thread overview]
Message-ID: <YhkJuZb7PfGvmRTY@smile.fi.intel.com> (raw)
In-Reply-To: <20220225121858.25638-1-baijiaju1990@gmail.com>
On Fri, Feb 25, 2022 at 04:18:58AM -0800, Jia-Ju Bai wrote:
> The function wakeup_source_register() in mmc_alloc_host() can fail, so
> its return value should be checked.
NAK.
This doesn't explain why this resource must be non-optional.
One should not dumbly use the robots.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-02-25 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 12:18 [PATCH] mmc: core: check the return value of wakeup_source_register() Jia-Ju Bai
2022-02-25 16:54 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhkJuZb7PfGvmRTY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=baijiaju1990@gmail.com \
--cc=dev@lynxeye.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.