All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH V2 3/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with quad mode
Date: Fri, 25 Feb 2022 13:01:44 -0600	[thread overview]
Message-ID: <YhknmEtjpN7Lmoru@robh.at.kernel.org> (raw)
In-Reply-To: <20220221040717.3729-4-leilk.liu@mediatek.com>

On Mon, Feb 21, 2022 at 12:07:14PM +0800, Leilk Liu wrote:
> This patch adds dt-binding documentation for Mediatek SPI IPM IP with
> quad mode.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index 0a2fc0404cb3..241c0f5880d3 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -42,6 +42,7 @@ properties:
>                - mediatek,mt8173-spi
>                - mediatek,mt8183-spi
>                - mediatek,ipm-spi-single
> +              - mediatek,ipm-spi-quad

Can't you use the existing width properties to distinguish? Or is the 
programming not a superset?

Is 'ipm' an SoC? If not, these need to be SoC specific.

Rob

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH V2 3/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with quad mode
Date: Fri, 25 Feb 2022 13:01:44 -0600	[thread overview]
Message-ID: <YhknmEtjpN7Lmoru@robh.at.kernel.org> (raw)
In-Reply-To: <20220221040717.3729-4-leilk.liu@mediatek.com>

On Mon, Feb 21, 2022 at 12:07:14PM +0800, Leilk Liu wrote:
> This patch adds dt-binding documentation for Mediatek SPI IPM IP with
> quad mode.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index 0a2fc0404cb3..241c0f5880d3 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -42,6 +42,7 @@ properties:
>                - mediatek,mt8173-spi
>                - mediatek,mt8183-spi
>                - mediatek,ipm-spi-single
> +              - mediatek,ipm-spi-quad

Can't you use the existing width properties to distinguish? Or is the 
programming not a superset?

Is 'ipm' an SoC? If not, these need to be SoC specific.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH V2 3/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with quad mode
Date: Fri, 25 Feb 2022 13:01:44 -0600	[thread overview]
Message-ID: <YhknmEtjpN7Lmoru@robh.at.kernel.org> (raw)
In-Reply-To: <20220221040717.3729-4-leilk.liu@mediatek.com>

On Mon, Feb 21, 2022 at 12:07:14PM +0800, Leilk Liu wrote:
> This patch adds dt-binding documentation for Mediatek SPI IPM IP with
> quad mode.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index 0a2fc0404cb3..241c0f5880d3 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -42,6 +42,7 @@ properties:
>                - mediatek,mt8173-spi
>                - mediatek,mt8183-spi
>                - mediatek,ipm-spi-single
> +              - mediatek,ipm-spi-quad

Can't you use the existing width properties to distinguish? Or is the 
programming not a superset?

Is 'ipm' an SoC? If not, these need to be SoC specific.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-25 19:02 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21  4:07 [PATCH V2 0/6] spi: mediatek: add single/quad mode support Leilk Liu
2022-02-21  4:07 ` Leilk Liu
2022-02-21  4:07 ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 1/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with single mode Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-25 18:57   ` Rob Herring
2022-02-25 18:57     ` Rob Herring
2022-02-25 18:57     ` Rob Herring
2022-02-21  4:07 ` [PATCH V2 2/6] spi: mediatek: add IPM single mode design support Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-22 10:09   ` AngeloGioacchino Del Regno
2022-02-22 10:09     ` AngeloGioacchino Del Regno
2022-02-22 10:09     ` AngeloGioacchino Del Regno
2022-02-23  1:51     ` Leilk Liu
2022-02-23  1:51       ` Leilk Liu
2022-02-23  1:51       ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 3/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with quad mode Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-25 19:01   ` Rob Herring [this message]
2022-02-25 19:01     ` Rob Herring
2022-02-25 19:01     ` Rob Herring
2022-02-26  3:24     ` Leilk Liu
2022-02-26  3:24       ` Leilk Liu
2022-02-26  3:24       ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 4/6] spi: mediatek: add spi memory support Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-22 10:49   ` AngeloGioacchino Del Regno
2022-02-22 10:49     ` AngeloGioacchino Del Regno
2022-02-22 10:49     ` AngeloGioacchino Del Regno
2022-02-23  1:59     ` Leilk Liu
2022-02-23  1:59       ` Leilk Liu
2022-02-23  1:59       ` Leilk Liu
2022-03-05  8:22       ` Leilk Liu
2022-03-05  8:22         ` Leilk Liu
2022-03-05  8:22         ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 5/6] dt-bindings: spi: support spi-hclk Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-25 19:03   ` Rob Herring
2022-02-25 19:03     ` Rob Herring
2022-02-25 19:03     ` Rob Herring
2022-02-26  3:14     ` Leilk Liu
2022-02-26  3:14       ` Leilk Liu
2022-02-26  3:14       ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 6/6] spi: mediatek: " Leilk Liu
2022-02-21  4:07   ` Leilk Liu
2022-02-21  4:07   ` Leilk Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhknmEtjpN7Lmoru@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leilk.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.