From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FC15C433F5 for ; Mon, 28 Feb 2022 13:16:57 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CA1013CA249 for ; Mon, 28 Feb 2022 14:16:55 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 6BD4A3C4BDC for ; Mon, 28 Feb 2022 14:16:45 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D704320009C for ; Mon, 28 Feb 2022 14:16:44 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0B5601F899; Mon, 28 Feb 2022 13:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646054204; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TpEi8GfDn5QvLKkRTXVNzNJXhwH1krD9e6EHVqdLuSk=; b=zlTx6RSH71h0SZqPA0pZ/vlZTThH66HQM1snyOgW6z9t++1vfJIOIlZRZpZkh/OEeMntlF dPTxcPyUcIeJR71U4nuAIrdW+FxAWPOyDBykv6mlBC2Ry5gzXHZdez7FPcmiFeV2bBv2Ui Zf7Vu1PntBBYRkyO7nyZ0GwUlFMgioo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646054204; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TpEi8GfDn5QvLKkRTXVNzNJXhwH1krD9e6EHVqdLuSk=; b=CH97IBizVT/htnYjmy3I65BJpdCF3VJMG9+4R9YaiTljaOVYQDuU3OAb1bzgF3F4zjr8yy 1ZlRlEBxVSxrjCCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CC79713C3E; Mon, 28 Feb 2022 13:16:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0dI5MDvLHGLWPQAAMHmgww (envelope-from ); Mon, 28 Feb 2022 13:16:43 +0000 Date: Mon, 28 Feb 2022 14:16:42 +0100 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20220228094659.21959-1-chrubis@suse.cz> <20220228094659.21959-3-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220228094659.21959-3-chrubis@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 2/2] ksm06: lock memory about to be merged X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Cyril, Reviewed-by: Petr Vorel Good catch! > Signed-off-by: Cyril Hrubis > --- > testcases/kernel/mem/lib/mem.c | 3 +++ > 1 file changed, 3 insertions(+) > diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c > index 39e3f1791..f1756b34a 100644 > --- a/testcases/kernel/mem/lib/mem.c > +++ b/testcases/kernel/mem/lib/mem.c > @@ -565,6 +565,9 @@ void test_ksm_merge_across_nodes(unsigned long nr_pages) > #endif > memset(memory[i], 10, length); > + > + if (mlock(memory[i], length)) > + tst_res(TINFO | TERRNO, "mlock() failed"); I'd consider using TWARN. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp