From: Josef Bacik <josef@toxicpanda.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] fstests: delete the cross-vfsmount reflink tests
Date: Mon, 14 Mar 2022 18:48:03 -0400 [thread overview]
Message-ID: <Yi/GIxdFzfmzxdD2@localhost.localdomain> (raw)
In-Reply-To: <20220314043724.GP661808@dread.disaster.area>
On Mon, Mar 14, 2022 at 03:37:24PM +1100, Dave Chinner wrote:
> On Fri, Mar 11, 2022 at 11:20:53AM -0500, Josef Bacik wrote:
> > Cross vfsmount reflink's are now allowed, the patch is in linux-next and
> > will go to linus soon. Remove these tests so nobody freaks out when
> > they start failing.
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>
> Shouldn't these tests be converted to test that cross-vfsmount
> reflinks now actually work?
>
> i.e. it's all well and good to remove tests of behaviour we no
> longer enforce, but to then not test the new behaviour we allow is
> actually working properly....
>
Sure, I'll fix it up and run it through a night of our CI tests and then send
the updated patches. Thanks,
Josef
next prev parent reply other threads:[~2022-03-14 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 16:20 [PATCH 0/2] fstests: test adjustments for the reflink behavior change Josef Bacik
2022-03-11 16:20 ` [PATCH 1/2] fstests: delete the cross-vfsmount reflink tests Josef Bacik
2022-03-14 4:37 ` Dave Chinner
2022-03-14 22:48 ` Josef Bacik [this message]
2022-03-11 16:20 ` [PATCH 2/2] fstests: btrfs/029: delete the cross vfsmount checks Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi/GIxdFzfmzxdD2@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.