From: Greg KH <gregkh@linuxfoundation.org>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: kintegrityd workqueue fix backported, but only to some LTS
Date: Mon, 14 Mar 2022 13:28:38 +0100 [thread overview]
Message-ID: <Yi809h0I28SN0qG8@kroah.com> (raw)
In-Reply-To: <Yi8r+UyK092FE12X@x1-carbon>
On Mon, Mar 14, 2022 at 11:50:18AM +0000, Niklas Cassel wrote:
> Hello Christoph, stable,
>
> I recently saw a crash caused by the kintegrityd workqueue that could only
> be reproduced on older kernels.
> A null pointer dereference in function bio_integrity_verify_fn.
>
> The fix in Linus's tree for this:
> 3df49967f6f1 ("block: flush the integrity workqueue in blk_integrity_unregister")
> was first merged in v5.15.
>
> The fix has been backported to v5.10 LTS branch in:
> 1ef68b84bc11 ("block: flush the integrity workqueue in blk_integrity_unregister")
>
> The fix doesn't have a fixes tag, but from inspecting the code,
> I don't understand why this was only backported to v5.10, AFAICT it should
> at least have been backported to v5.4, v4.19 and v4.14 LTS as well.
>
> Original series:
> https://lore.kernel.org/all/20210914070657.87677-3-hch@lst.de/
>
> The blk_flush_integrity() call that actually fixes the crash should be
> trivial to backport/add before clearing the flag and doing the memset.
A backported patch series would be great to have, to show that you have
tested that it works properly.
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-14 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 11:50 kintegrityd workqueue fix backported, but only to some LTS Niklas Cassel
2022-03-14 12:28 ` Greg KH [this message]
2022-03-14 13:08 ` Niklas Cassel
2022-03-14 13:54 ` Greg KH
2022-03-14 15:48 ` Niklas Cassel
2022-03-16 14:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi809h0I28SN0qG8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Niklas.Cassel@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.