From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0809E7A for ; Mon, 14 Mar 2022 17:31:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E6B9C340E9; Mon, 14 Mar 2022 17:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647279081; bh=hX9Tqyy6vxbu6BVOcnzI3a9SafOh9xeUfxbU1OKEzW8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HvCr6fPJpW2TN8UmjlWrLR/7KrPpDjyCFKfVCoFxaMZcipnssEs/dzZML+gzbX/NW T+nQ77peJ6ElKCXxQz3MyYqN3zLeJU+goeXfETaPFVGG86Nv9npx3RLOaprd7XKnuo UgrMydSklX+rv1pBjgxdZm0xVvB/p+EhmydGduAI= Date: Mon, 14 Mar 2022 18:30:27 +0100 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] staging: r8188eu: some rx cleanups Message-ID: References: <20220305185351.1409232-1-martin@kaiser.cx> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220305185351.1409232-1-martin@kaiser.cx> On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote: > Here's another set with simple cleanups in the code for receiving frames. > > Martin Kaiser (6): > staging: r8188eu: remove unnecessary initializations > staging: r8188eu: remove three unused receive defines > staging: r8188eu: remove unused function prototype > staging: r8188eu: make rtl8188e_process_phy_info static > staging: r8188eu: remove some unused local ieee80211 macros > staging: r8188eu: remove local BIT macro > > drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 6 +--- > .../staging/r8188eu/include/rtl8188e_recv.h | 6 ---- > drivers/staging/r8188eu/include/wifi.h | 34 +------------------ > 3 files changed, 2 insertions(+), 44 deletions(-) > > -- > 2.30.2 > > This series breaks the build: drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’: drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow] 1279 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow] 1285 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors I'm going to drop it from my queue now. thanks, greg k-h