From: Greg KH <gregkh@linuxfoundation.org>
To: Song Chen <chensong_2000@189.cn>
Cc: johan@kernel.org, elder@kernel.org, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
elder@ieee.org
Subject: Re: [PATCH v4] staging: greybus: introduce pwm_ops::apply
Date: Mon, 14 Mar 2022 16:03:41 +0100 [thread overview]
Message-ID: <Yi9ZTdcZsdDjecC3@kroah.com> (raw)
In-Reply-To: <1646791174-30557-1-git-send-email-chensong_2000@189.cn>
On Wed, Mar 09, 2022 at 09:59:34AM +0800, Song Chen wrote:
> Introduce newer .apply function in pwm_ops to
> replace legacy operations,like enable, disable,
> config and set_polarity.
You can use the full 72 columns please.
> This guarantees atomic changes of the pwm
> controller configuration and also reduces the
> size of the driver.
The driver is bigger (more lines) with this change, so why do you say it
is smaller?
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-14 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 1:59 [PATCH v4] staging: greybus: introduce pwm_ops::apply Song Chen
2022-03-14 15:03 ` Greg KH [this message]
2022-03-16 1:35 ` Song Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi9ZTdcZsdDjecC3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chensong_2000@189.cn \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.