Re: [PATCH] leds: add new functions for mobile routers

[Rob Herring <robh@kernel.org>]

On Fri, Feb 18, 2022 at 09:50:02AM +0100, Pawel Dembicki wrote:
> 2G/2G/4G routers have some special leds functions:
>   - signal strength, which shows info about signal status.
>     Some devices have multicolor indication (e.g. D-Link DWR-960)
>     other use multiple leds for different levels (e.g. Cell-C RTL30VW)
>   - connection status, which shows if connection is active. Some devices
>     have multiple leds for different bands (e.g. D-Link DWR-960).
>   - sms indicator
> 
> This patch adds new LED_FUNCTION_* defines of them.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
> ---
>  Documentation/leds/well-known-leds.txt | 9 +++++++++
>  include/dt-bindings/leds/common.h      | 5 +++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/leds/well-known-leds.txt b/Documentation/leds/well-known-leds.txt
> index 2160382c86be..677cf7e57a76 100644
> --- a/Documentation/leds/well-known-leds.txt
> +++ b/Documentation/leds/well-known-leds.txt
> @@ -16,6 +16,15 @@ but then try the legacy ones, too.
>  
>  Notice there's a list of functions in include/dt-bindings/leds/common.h .
>  
> +* 4G/3G/2G routers
> +
> +Cellular routers use LEDs for signal strength identification and connection
> +status. Some models also have incoming SMS indicator.
> +
> +Good: "*:connection"
> +Good: "*:signal"
> +Good: "*:sms"
> +
>  * Gamepads and joysticks
>  
>  Game controllers may feature LEDs to indicate a player number. This is commonly
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 3be89a7c20a9..3adfa120353e 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -60,6 +60,11 @@
>  #define LED_FUNCTION_MICMUTE "micmute"
>  #define LED_FUNCTION_MUTE "mute"
>  
> +/* Used for 4G/3G/2G routers. */
> +#define LED_FUNCTION_CONNECTION "connection"

wan?

> +#define LED_FUNCTION_SIGNAL "signal"
> +#define LED_FUNCTION_SMS "sms"

mail?

The whole idea with defining the names was to not create different names 
for roughly the same thing.

Rob