From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55102C433EF for ; Thu, 3 Mar 2022 14:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbiCCORB (ORCPT ); Thu, 3 Mar 2022 09:17:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232647AbiCCORA (ORCPT ); Thu, 3 Mar 2022 09:17:00 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 631EC18CC67; Thu, 3 Mar 2022 06:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646316974; x=1677852974; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ynRuusHJD/05mmCsacrrHzXmY4ZK7oPmKnF+sWwUGc0=; b=ad3FVEqRnM1S71RjthFR8oAZGtR1oAaiWno5wPDeEJYdH94Tk/yNFryz BOIE1Ho9+E5QpXR0NiyFmA98r/06rlHo2pN6G4IEAfaw0Oy5l+WmUXexj lxZ9smG5BrPxIU0rEn8v2Zot2xy6qGcJTJErrTMAAkaMvq3VFGjWahNIm kpcEeQnrUKpxt7112/XOCfOh2/rpK+K3DZaVyuukzV0jtiDpjFdao2CpL nSHaVcK5a8Xj2flSJ9fnEtWwFk8/coRyilDkldsHp+p8gSXbhD/ikQAI7 oX6j1trALy3VUlysw4M3PexiI8UDjbE1LzidPoVqSKLcvo0Avk2+nR/ky g==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="253614680" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="253614680" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 06:16:12 -0800 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="545876842" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 06:16:05 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nPmEg-00ApL3-8j; Thu, 03 Mar 2022 16:15:18 +0200 Date: Thu, 3 Mar 2022 16:15:18 +0200 From: Andy Shevchenko To: Tali Perry Cc: Tyrone Ting , avifishman70@gmail.com, Tomer Maimon , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , yangyicong@hisilicon.com, semen.protsenko@linaro.org, Wolfram Sang , jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, Tali Perry , Avi Fishman , tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, OpenBMC Maillist , Linux I2C , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH v3 08/11] i2c: npcm: Correct register access width Message-ID: References: <20220303083141.8742-1-warp5tw@gmail.com> <20220303083141.8742-9-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Mar 03, 2022 at 02:54:27PM +0200, Tali Perry wrote: > > On Thu, Mar 03, 2022 at 04:31:38PM +0800, Tyrone Ting wrote: > > > From: Tyrone Ting > > > > > > Use ioread8 instead of ioread32 to access the SMBnCTL3 register since > > > the register is only 8-bit wide. > > > > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") > > > > No, this is bad commit message, since you have bitwise masks and there is > > nothing to fix from functional point of view. So, why is this a fix? > > > > The next gen of this device is a 64 bit cpu. > The module is and was 8 bit. > > The ioread32 that seemed to work smoothly on a 32 bit machine > was causing a panic on a 64 bit machine. > since the module is 8 bit we changed to ioread8. > This is working both for the 32 and 64 CPUs with no issue. Then the commit message is completely wrong here. And provide necessary (no need to have noisy commit messages) bits of the oops to show what's going on -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 600E3C433EF for ; Thu, 3 Mar 2022 14:17:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K8Y3j6QjXz3c3k for ; Fri, 4 Mar 2022 01:17:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cxY9RDR0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cxY9RDR0; dkim-atps=neutral Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4K8Y2x1cLdz3bvP for ; Fri, 4 Mar 2022 01:17:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646317034; x=1677853034; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ynRuusHJD/05mmCsacrrHzXmY4ZK7oPmKnF+sWwUGc0=; b=cxY9RDR0wdYc3Is4aSRDGhXaQfrBC1tFB/q28h6v0gYHtSjdEQAUmUy5 uEvHb1IfpXGkHTJaBS6ZUIub1hheAgq6n7DCv+5kCCSeZZZ/k8V0ik5BV 7TOgp5my7rOku3u3gQNK6zZWjuS5BBIGE3w0Xia5CjyktmPk5lft4AsFm FFKFvOGYdTJr2KYkBYN1Jqsyth0bbAdiKbpEEJ9BJJcXMZaHkhV6rUiNo K4FFRWtk6V8c96N4nPnaQSN4wLdkxC0hFvKGk2SGYduvmF5IGNDm2qm33 xIcc5q9bxB39Md4gAljak0JSW6Ao+/Zd/4LnwR6Px00L+6en/PG/h0IJd w==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="253878175" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="253878175" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 06:16:11 -0800 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="545876842" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 06:16:05 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nPmEg-00ApL3-8j; Thu, 03 Mar 2022 16:15:18 +0200 Date: Thu, 3 Mar 2022 16:15:18 +0200 From: Andy Shevchenko To: Tali Perry Subject: Re: [PATCH v3 08/11] i2c: npcm: Correct register access width Message-ID: References: <20220303083141.8742-1-warp5tw@gmail.com> <20220303083141.8742-9-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomer Maimon , devicetree , yangyicong@hisilicon.com, Linux I2C , Benjamin Fair , Krzysztof Kozlowski , OpenBMC Maillist , JJLIU0@nuvoton.com, lukas.bulwahn@gmail.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, bence98@sch.bme.hu, arnd@arndb.de, sven@svenpeter.dev, Rob Herring , Avi Fishman , Tyrone Ting , semen.protsenko@linaro.org, jie.deng@intel.com, avifishman70@gmail.com, Patrick Venture , Linux Kernel Mailing List , Wolfram Sang , kfting@nuvoton.com, Tali Perry , olof@lixom.net Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Mar 03, 2022 at 02:54:27PM +0200, Tali Perry wrote: > > On Thu, Mar 03, 2022 at 04:31:38PM +0800, Tyrone Ting wrote: > > > From: Tyrone Ting > > > > > > Use ioread8 instead of ioread32 to access the SMBnCTL3 register since > > > the register is only 8-bit wide. > > > > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") > > > > No, this is bad commit message, since you have bitwise masks and there is > > nothing to fix from functional point of view. So, why is this a fix? > > > > The next gen of this device is a 64 bit cpu. > The module is and was 8 bit. > > The ioread32 that seemed to work smoothly on a 32 bit machine > was causing a panic on a 64 bit machine. > since the module is 8 bit we changed to ioread8. > This is working both for the 32 and 64 CPUs with no issue. Then the commit message is completely wrong here. And provide necessary (no need to have noisy commit messages) bits of the oops to show what's going on -- With Best Regards, Andy Shevchenko