From: Leon Romanovsky <leon@kernel.org>
To: Shangyan Zhou <sy.zhou@hotmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] rdma: Fix res_print_uint()
Date: Fri, 4 Mar 2022 09:02:37 +0200 [thread overview]
Message-ID: <YiG5jQHDA7HuGjrO@unreal> (raw)
In-Reply-To: <OSAPR01MB75677A8532242F986A967C9DE3059@OSAPR01MB7567.jpnprd01.prod.outlook.com>
On Fri, Mar 04, 2022 at 11:00:28AM +0800, Shangyan Zhou wrote:
> Print unsigned int64 should use print_color_u64() and fmt string should be "%" PRIu64.
>
> Signed-off-by: Shangyan Zhou <sy.zhou@hotmail.com>
> ---
> rdma/res.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rdma/res.c b/rdma/res.c
> index 21fef9bd..1af61aa6 100644
> --- a/rdma/res.c
> +++ b/rdma/res.c
> @@ -214,7 +214,7 @@ void res_print_uint(struct rd *rd, const char *name, uint64_t val,
> if (!nlattr)
> return;
> print_color_uint(PRINT_ANY, COLOR_NONE, name, name, val);
> - print_color_uint(PRINT_FP, COLOR_NONE, NULL, " %d ", val);
> + print_color_u64(PRINT_FP, COLOR_NONE, NULL, " %" PRIu64 " ", val);
> }
Except the res_print_uint() that should be changed too, the patch LGTM.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-03-04 7:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 3:06 [PATCH] rdma: Fix res_print_uint() Shangyan Zhou
2022-03-03 18:44 ` Leon Romanovsky
2022-03-04 3:17 ` Shangyan Zhou
2022-03-04 3:00 ` [PATCH v2] " Shangyan Zhou
2022-03-04 7:02 ` Leon Romanovsky [this message]
2022-03-04 12:47 ` Shangyan Zhou
2022-03-04 12:46 ` [PATCH v3] rdma: Fix res_print_uint() and add res_print_u64() Shangyan Zhou
2022-03-04 17:33 ` Leon Romanovsky
2022-03-06 7:00 ` Shangyan Zhou
2022-03-06 6:56 ` [PATCH v4] rdma: Fix the logic to print unsigned int Shangyan Zhou
2022-03-07 12:49 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiG5jQHDA7HuGjrO@unreal \
--to=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sy.zhou@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.