From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org, colin.foster@in-advantage.com
Subject: Re: [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing
Date: Fri, 4 Mar 2022 14:41:06 +0200 [thread overview]
Message-ID: <YiII4mMembqLiX5D@smile.fi.intel.com> (raw)
In-Reply-To: <YiIIxXemSB8LIq8L@smile.fi.intel.com>
On Fri, Mar 04, 2022 at 02:40:38PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 03, 2022 at 09:37:16PM +0100, Horatiu Vultur wrote:
> > In the blamed commit, it removes the duplicate of_node assignment in the
> > driver. But the driver uses this before calling into of_gpio_dev_init to
> > determine if it needs to assign an IRQ chip to the GPIO. The fixes
> > consists in using of_node from dev.
>
> ...
>
> > - irq = irq_of_parse_and_map(gc->of_node, 0);
> > + irq = irq_of_parse_and_map(info->dev->of_node, 0);
>
> Why platform_get_irq() can't be used?
Or actually _optional() variant of it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-04 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 20:37 [PATCH 0/2] pinctrl: ocelot: Add fixes for ocelot driver Horatiu Vultur
2022-03-03 20:37 ` [PATCH 1/2] pinctrl: ocelot: Fix the pincfg resource Horatiu Vultur
2022-03-03 21:28 ` Colin Foster
2022-03-03 20:37 ` [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing Horatiu Vultur
2022-03-04 12:40 ` Andy Shevchenko
2022-03-04 12:41 ` Andy Shevchenko [this message]
2022-03-04 14:26 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiII4mMembqLiX5D@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=colin.foster@in-advantage.com \
--cc=horatiu.vultur@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.