From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v3 3/6] typec: mux: Introduce indirection
Date: Fri, 4 Mar 2022 14:58:02 +0200 [thread overview]
Message-ID: <YiIM2rBHcyRAIY0y@smile.fi.intel.com> (raw)
In-Reply-To: <20220303223351.141238-3-bjorn.andersson@linaro.org>
On Thu, Mar 03, 2022 at 02:33:48PM -0800, Bjorn Andersson wrote:
> Rather than directly exposing the implementation's representation of the
> typec muxes to the controller/clients, introduce an indirection object.
>
> This enables the introduction of turning this relationship into a
> one-to-many in the following patch.
...
> + dev_set_name(&sw_dev->dev, "%s-switch",
> desc->name ? desc->name : dev_name(parent));
Besides a possible shorten form of
dev_set_name(&sw_dev->dev, "%s-switch", desc->name ?: dev_name(parent));
this lacks of the error checking (it seems in original code like this and
should be fixed as preparatory patch for easy backporting).
...
> + dev_set_name(&mux_dev->dev, "%s-mux",
> desc->name ? desc->name : dev_name(parent));
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-04 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 22:33 [PATCH v3 1/6] device property: Helper to match multiple connections Bjorn Andersson
2022-03-03 22:33 ` [PATCH v3 2/6] device property: Use multi-connection matchers for single case Bjorn Andersson
2022-03-04 12:54 ` Andy Shevchenko
2022-03-03 22:33 ` [PATCH v3 3/6] typec: mux: Introduce indirection Bjorn Andersson
2022-03-04 12:58 ` Andy Shevchenko [this message]
2022-03-03 22:33 ` [PATCH v3 4/6] typec: mux: Allow multiple mux_devs per mux Bjorn Andersson
2022-03-04 13:54 ` Andy Shevchenko
2022-03-07 3:09 ` Bjorn Andersson
2022-03-03 22:33 ` [PATCH v3 5/6] dt-bindings: usb: Add binding for fcs,fsa4480 Bjorn Andersson
2022-03-03 22:33 ` [PATCH v3 6/6] usb: typec: mux: Add On Semi fsa4480 driver Bjorn Andersson
2022-03-04 12:54 ` [PATCH v3 1/6] device property: Helper to match multiple connections Andy Shevchenko
2022-03-04 13:41 ` Sakari Ailus
2022-03-04 13:52 ` Andy Shevchenko
2022-03-07 2:18 ` Bjorn Andersson
2022-03-07 9:31 ` Andy Shevchenko
2022-03-07 2:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiIM2rBHcyRAIY0y@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.