From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABDFC433F5 for ; Fri, 4 Mar 2022 13:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233469AbiCDNmQ (ORCPT ); Fri, 4 Mar 2022 08:42:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231901AbiCDNmQ (ORCPT ); Fri, 4 Mar 2022 08:42:16 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB8C21B6E3C for ; Fri, 4 Mar 2022 05:41:27 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1nQ8BR-0004pd-If; Fri, 04 Mar 2022 14:41:25 +0100 Date: Fri, 4 Mar 2022 14:41:25 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] evaluate: init cmd pointer for new on-stack context Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org References: <20220304103634.13160-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Mar 04, 2022 at 11:54:39AM +0100, Pablo Neira Ayuso wrote: > On Fri, Mar 04, 2022 at 11:36:34AM +0100, Florian Westphal wrote: > > else, this will segfault when trying to print the > > "table 'x' doesn't exist" error message. > > LGTM, thanks. One nitpick below: This also fixes the segfault I was trying to avoid with my patch for string_misspell_update(). I had definitely tried Florian's solution, but it didn't work for me. Guess there's a bug in my test env or something. :( Thanks, Phil