From: "Daniel P. Berrangé" <berrange@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Cleber Rosa <crosa@redhat.com>,
qemu-devel@nongnu.org, Beraldo Leal <bleal@redhat.com>
Subject: Re: [PATCH 04/10] python/aqmp: split _client_connected_cb() out as _incoming()
Date: Fri, 4 Mar 2022 17:53:00 +0000 [thread overview]
Message-ID: <YiJR/OL2BGngiBWq@redhat.com> (raw)
In-Reply-To: <20220225205948.3693480-5-jsnow@redhat.com>
On Fri, Feb 25, 2022 at 03:59:42PM -0500, John Snow wrote:
> As part of disentangling the monolithic nature of _do_accept(), split
> out the incoming callback to prepare for factoring out the "wait for a
> peer" step. Namely, this means using an event signal we can wait on from
> outside of this method.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/aqmp/protocol.py | 83 +++++++++++++++++++++++++-----------
> 1 file changed, 58 insertions(+), 25 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-03-04 18:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 20:59 [PATCH 00/10] Python: Fix qmp race condition on accept() John Snow
2022-02-25 20:59 ` [PATCH 01/10] python/aqmp: add _session_guard() John Snow
2022-03-04 17:34 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 02/10] python/aqmp: rename 'accept()' to 'start_server_and_accept()' John Snow
2022-03-04 17:48 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 03/10] python/aqmp: remove _new_session and _establish_connection John Snow
2022-03-04 17:50 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 04/10] python/aqmp: split _client_connected_cb() out as _incoming() John Snow
2022-03-04 17:53 ` Daniel P. Berrangé [this message]
2022-02-25 20:59 ` [PATCH 05/10] python/aqmp: squelch pylint warning for too many lines John Snow
2022-03-04 17:55 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 06/10] python/aqmp: refactor _do_accept() into two distinct steps John Snow
2022-03-04 17:57 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 07/10] python/aqmp: stop the server during disconnect() John Snow
2022-03-04 17:57 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 08/10] python/aqmp: add start_server() and accept() methods John Snow
2022-03-04 17:59 ` Daniel P. Berrangé
2022-02-25 20:59 ` [PATCH 09/10] python/aqmp: fix race condition in legacy.py John Snow
2022-03-04 18:01 ` Daniel P. Berrangé
2022-03-04 18:23 ` John Snow
2022-02-25 20:59 ` [PATCH 10/10] python/aqmp: drop _bind_hack() John Snow
2022-03-04 18:03 ` Daniel P. Berrangé
2022-03-03 22:37 ` [PATCH 00/10] Python: Fix qmp race condition on accept() John Snow
2022-03-04 17:49 ` Kevin Wolf
2022-03-04 18:28 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiJR/OL2BGngiBWq@redhat.com \
--to=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.