From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69F2C433EF for ; Fri, 4 Mar 2022 19:01:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 53EE649B0C; Fri, 4 Mar 2022 14:01:49 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LgCipz2i4J6S; Fri, 4 Mar 2022 14:01:48 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2DFD549DF6; Fri, 4 Mar 2022 14:01:48 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D469E4291D for ; Fri, 4 Mar 2022 14:01:46 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OkZ99RjSYomT for ; Fri, 4 Mar 2022 14:01:45 -0500 (EST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A6D4740D26 for ; Fri, 4 Mar 2022 14:01:45 -0500 (EST) Received: by mail-pj1-f41.google.com with SMTP id z12-20020a17090ad78c00b001bf022b69d6so7640502pju.2 for ; Fri, 04 Mar 2022 11:01:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=aWtPp9gHavbCe/72TWGgyPSN8olgIQaG6jqiqoJFlvo=; b=T6cZTeQpCWywuAIUeZSbXRXspUMqzhtz/6tGTT/oMw4QxfOPTtToFpWO+keRiJvHqF 8JSl2KEqr7eM0ff447jt4in3NZLFaKYH+way7DVAbtyykbxIOezHLNgL/07Lq4W38S8x 7QJOvo7D+dtfY62vdxaeSa5832NDBy1wcRtoSpTKpMpnrvIGDHb4yEZa485WSraY1Mis K9sDj747pso9N9WHul3YQ6TO3HWakI6UTzZIX/3EStFZOurxJzKWzOy9Mogkf/7RTzKA CLgt0ljFTI8ZuzSSnwmhygmATrSeHYYPBA+6opn5ARig/FsZtyz9oAR2SZmJcDYjHsW8 1qiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aWtPp9gHavbCe/72TWGgyPSN8olgIQaG6jqiqoJFlvo=; b=BBEcBNcJCy9UsI/ewIfCA/LTosoqDEOW98av42Dq24mN6y0KdUVWDeLWTnzT0r0aL1 j7hiTdGJQbOkU/qwmtRwwdvs+pkFi+tLj3NjmhUgfQnrZvb/j2O3qKIA+K5a5T1k61QK 4/MbLQ2YkNgT+AHdOQYYVRUPpBqc8oUdQDC6GN4p+o4OSaISh2FafnJIuKfVqLuuF39x GGCC4944hwdE8lVagfO1RiJut5qCs4vMAKklbBPGhRPq/YJvNzce/EocQ5u2x6ljFRol CWINpQHCS1PVPzu3urvUxLOoU+ZEf1Wfv6ZpyVjhv8hbo+KwDFdAhUFIHMtenKtjmQmi 6SvQ== X-Gm-Message-State: AOAM530b/N073wNLaoRyvKLnGBlINOrFRZXj14QkjcJnmjxEcNtwp8ao 2fLnyYPuGdVtQlhJhbKFEWnArMNuf9DHvw== X-Google-Smtp-Source: ABdhPJwIYIZYgdYmZztlZdIGYIS82jCeVXSf1N3R2HJLRYsb6Fdyu/sqywudX8SMQNietyqX8pg5fQ== X-Received: by 2002:a17:90b:350c:b0:1bf:1dc5:1c3d with SMTP id ls12-20020a17090b350c00b001bf1dc51c3dmr7361081pjb.53.1646420504531; Fri, 04 Mar 2022 11:01:44 -0800 (PST) Received: from google.com (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with ESMTPSA id z2-20020a17090a170200b001bf2d530d64sm2136862pjd.2.2022.03.04.11.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 11:01:43 -0800 (PST) Date: Fri, 4 Mar 2022 11:01:40 -0800 From: Ricardo Koller To: Marc Zyngier Subject: Re: [PATCH 2/3] KVM: arm64: selftests: add arch_timer_edge_cases Message-ID: References: <20220302172144.2734258-1-ricarkol@google.com> <20220302172144.2734258-3-ricarkol@google.com> <87h78etasf.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87h78etasf.wl-maz@kernel.org> Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gRnJpLCBNYXIgMDQsIDIwMjIgYXQgMDc6NTI6MDBBTSArMDAwMCwgTWFyYyBaeW5naWVyIHdy b3RlOgo+IE9uIFdlZCwgMDIgTWFyIDIwMjIgMjE6MjU6MjggKzAwMDAsCj4gUmljYXJkbyBLb2xs ZXIgPHJpY2Fya29sQGdvb2dsZS5jb20+IHdyb3RlOgo+ID4gCj4gPiBIaSBPbGl2ZXIsCj4gPiAK PiA+IE9uIFdlZCwgTWFyIDAyLCAyMDIyIGF0IDA4OjQ1OjUzUE0gKzAwMDAsIE9saXZlciBVcHRv biB3cm90ZToKPiA+ID4gSGkgUmljYXJkbywKPiA+ID4gCj4gPiA+IE9uIFdlZCwgTWFyIDAyLCAy MDIyIGF0IDA5OjIxOjQzQU0gLTA4MDAsIFJpY2FyZG8gS29sbGVyIHdyb3RlOgo+ID4gPiA+IEFk ZCBhbiBhcmNoX3RpbWVyIGVkZ2UtY2FzZXMgc2VsZnRlc3QuIEZvciBub3csIGp1c3QgYWRkIHNv bWUgYmFzaWMKPiA+ID4gPiBzYW5pdHkgY2hlY2tzLCBhbmQgc29tZSBzdHJlc3MgY29uZGl0aW9u cyAobGlrZSB3YWl0aW5nIGZvciB0aGUgdGltZXJzCj4gPiA+ID4gd2hpbGUgcmUtc2NoZWR1bGlu ZyB0aGUgdmNwdSkuIFRoZSBuZXh0IGNvbW1pdCB3aWxsIGFkZCB0aGUgYWN0dWFsIGVkZ2UKPiA+ ID4gPiBjYXNlIHRlc3RzLgo+ID4gPiA+IAo+ID4gPiA+IFRoaXMgdGVzdCBmYWlscyB3aXRob3V0 IGE4NjdlOWQwY2MxICJLVk06IGFybTY0OiBEb24ndCBtaXNzIHBlbmRpbmcKPiA+ID4gPiBpbnRl cnJ1cHRzIGZvciBzdXNwZW5kZWQgdkNQVSIuCj4gPiA+ID4gCj4gPiA+IAo+ID4gPiBUZXN0aW5n IHRpbWVyIGNvcnJlY3RuZXNzIGlzIGV4dHJlbWVseSBjaGFsbGVuZ2luZyB0byBkbyB3aXRob3V0 Cj4gPiA+IGluaGVyZW50IGZsYWtpbmVzcy4gSSBoYXZlIHNvbWUgY29uY2VybnMgYWJvdXQgdGhl IGV4cGVjdGF0aW9ucyB0aGF0IGEKPiA+ID4gdGltZXIgSVJRIHNob3VsZCBmaXJlIGluIGEgZ2l2 ZW4gYW1vdW50IG9mIHRpbWUsIGFzIGl0IGlzIHBvc3NpYmxlIHRvCj4gPiA+IGZsYWtlIGZvciBh bnkgbnVtYmVyIG9mIGJlbmlnbiByZWFzb25zIChzdWNoIGFzIGhpZ2ggQ1BVIGxvYWQgaW4gdGhl Cj4gPiA+IGhvc3QpLgo+ID4gPiAKPiA+ID4gV2hpbGUgdGhlIGFyY2hpdGVjdHVyZSBtYXkgc3Vn Z2VzdCB0aGF0IHRoZSB0aW1lciBzaG91bGQgZmlyZSBhcyBzb29uIGFzCj4gPiA+IENWQUwgaXMg bWV0Ogo+ID4gPiAKPiA+ID4gICBUaW1lckNvbmRpdGlvbk1ldCA9ICgoKENvdW50ZXJbNjM6MF0g 4oCTIE9mZnNldFs2MzowXSlbNjM6MF0gLSBDb21wYXJlVmFsdWVbNjM6MF0pID49IDApCj4gPiA+ IAo+ID4gPiBIb3dldmVyLCB0aGUgYXJjaGl0ZWN0dXJlIGlzIGV4dHJlbWVseSBpbXByZWNpc2Ug YXMgdG8gd2hlbiBhbiBpbnRlcnJ1cHQKPiA+ID4gc2hvdWxkIGJlIHRha2VuOgo+ID4gPiAKPiA+ ID4gICBJbiB0aGUgYWJzZW5jZSBvZiBhIHNwZWNpZmljIHJlcXVpcmVtZW50IHRvIHRha2UgYW4g aW50ZXJydXB0LCB0aGUKPiA+ID4gICBhcmNoaXRlY3R1cmUgb25seSByZXF1aXJlcyB0aGF0IHVu bWFza2VkIHBlbmRpbmcgaW50ZXJydXB0cyBhcmUgdGFrZW4KPiA+ID4gICBpbiBmaW5pdGUgdGlt ZS4gW0RESTA0ODdHLmIgRDEuMTMuNCAiUHJpb3JpdGl6YXRpb24gYW5kIHJlY29nbml0aW9uIG9m Cj4gPiA+ICAgaW50ZXJydXB0cyJdCj4gPiA+IAo+ID4gPiBJdCBzZWVtcyB0byBtZSB0aGF0IHRo ZSBvbmx5IHRoaW5nIHdlIGNhbiBwb3NpdGl2ZWx5IGFzc2VydCBpcyB0aGF0IGEKPiA+ID4gdGlt ZXIgaW50ZXJydXB0IHNob3VsZCBuZXZlciBiZSB0YWtlbiBlYXJseS4gTm93IC0tIEkgYWdyZWUg dGhhdCB0aGVyZQo+ID4gPiBpcyB2YWx1ZSBpbiB0ZXN0aW5nIHRoYXQgdGhlIGludGVycnVwdCBi ZSB0YWtlbiBpbiBib3VuZGVkIHRpbWUsIGJ1dCBpdHMKPiA+ID4gaGFyZCB0byBwaWNrIGEgZ29v ZCB2YWx1ZSBmb3IgaXQuCj4gPiAKPiA+IFllcywgYSB0aW1lciB0aGF0IG5ldmVyIGZpcmVzIHBh c3NlcyB0aGUgdGVzdCwgYnV0IGl0J3Mgbm90IHZlcnkgdXNlZnVsLgo+ID4gCj4gPiBJIHNhdyBk ZWxheSBpc3N1ZXMgaW1tZWRpYXRlbHkgYWZ0ZXIgdGVzdGluZyB3aXRoIFFFTVUuIEkndmUgYmVl biBwbGF5ZWQKPiA+IHdpdGggdmFsdWVzIGFuZCBmb3VuZCB0aGF0IDFtcyBpcyBlbm91Z2ggZm9y IGFsbCBvZiBteSBydW5zIChRRU1VCj4gPiBpbmNsdWRlZCkgdG8gcGFzcyAoMTAwMDAgaXRlcmF0 aW9ucyBjb25jdXJyZW50bHkgb24gYWxsIG15IDY0IGNwdXMpLiBJCj4gPiBqdXN0IGNoZWNrZWQg aW4gdGhlIGZhc3QgbW9kZWwgYW5kIDFtcyBzZWVtcyB0byBiZSBlbm91Z2ggYXMgd2VsbAo+ID4g KGFsdGhvdWdoIEkgZGlkbid0IGNoZWNrIGZvciBzbyBsb25nKS4KPiA+IAo+ID4gCS8qIDFtcyBz b3VuZHMgYSBiaXQgZXhjZXNzaXZlLCBidXQgUUVNVS1UQ0cgaXMgc2xvdy4gKi8KPiA+IAkjZGVm aW5lIFRFU1RfTUFSR0lOX1VTCQkJMTAwMFVMTAo+IAo+IEknbSBub3Qgc3VyZSB0aGF0J3MgZXZl biByZWFsaXN0aWMuIEkgY2FuIGFyYml0cmFyeSBkZWxheSB0aG9zZSBieQo+IG92ZXJzdWJzY3Jp YmluZyB0aGUgc3lzdGVtLgo+IAo+ID4gCj4gPiA+IAo+ID4gPiBQZXJoYXBzIGRvY3VtZW50aW5n IHRoZSBwb3NzaWJpbGl0eSBvZiBmbGFrZXMgaW4gdGhlIHRlc3QgaXMgd2FycmFudGVkLAo+ID4g PiBhbG9uZyB3aXRoIHNvbWUga25vYnMgdG8gYWRqdXN0IHRoZXNlIHZhbHVlcyBmb3IgYW55IHBh cnRpY3VsYXJseSBiYWQKPiA+ID4gaW1wbGVtZW50YXRpb24uCj4gPiAKPiA+IFdoYXQgYWJvdXQg aGF2aW5nIGEgY21kbGluZSBhcmcgdG8gZW5hYmxlIHRob3NlIHRlc3RzPwo+IAo+IEhvdyBpcyB0 aGF0IGhhbmRsZWQgaW4ga3ZtLXVuaXQtdGVzdHM/IEknZCByYXRoZXIgYXZvaWQgc3BlY2lhbAo+ IGFyZ3VtZW50cywgYXMgdGhleSB3aWxsIG5ldmVyIGJlIHNldC4gQWxsIHRlc3RzIHNob3VsZCBy dW4gYnkgZGVmYXVsdC4KClRoZXJlJ3MgdGhpcyBsYXRlbmN5IHRlc3QgdGhhdCBjaGVja3MgdGhh dCB0aGUgbGF0ZW5jeSBmb3IgYSAxMG1zIHRpbWVyCmlzIG5vdCBkZWxheWVkIGJ5IG1vcmUgdGhh biAxMG1zIChhZnRlciB0aGUgZmlyc3QgMTBtcyk6CgoJcmVwb3J0KHRlc3RfY3ZhbF8xMG1zZWMo aW5mbyksICJsYXRlbmN5IHdpdGhpbiAxMCBtcyIpOwoKSnVzdCB0byBiZSBzYWZlIEkgd2lsbCBq dXN0IHJlbW92ZSB0aGUgY2hlY2tzIGZvciB0aW1lcnMgZmlyaW5nIGJlZm9yZQpzb21lIG1hcmdp biAobm90IGV2ZW4gd2l0aCBhIHNwZWNpYWwgYXJndW1lbnQpLgoKVGhhbmtzLApSaWNhcmRvCgo+ IAo+IAlNLgo+IAo+IC0tIAo+IFdpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dy ZXNzIGlzIG5vdCBwb3NzaWJsZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEu ZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJt Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91704C433F5 for ; Fri, 4 Mar 2022 19:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbiCDTCg (ORCPT ); Fri, 4 Mar 2022 14:02:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbiCDTCf (ORCPT ); Fri, 4 Mar 2022 14:02:35 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C4F41DCCE9 for ; Fri, 4 Mar 2022 11:01:45 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso8760807pjo.5 for ; Fri, 04 Mar 2022 11:01:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=aWtPp9gHavbCe/72TWGgyPSN8olgIQaG6jqiqoJFlvo=; b=T6cZTeQpCWywuAIUeZSbXRXspUMqzhtz/6tGTT/oMw4QxfOPTtToFpWO+keRiJvHqF 8JSl2KEqr7eM0ff447jt4in3NZLFaKYH+way7DVAbtyykbxIOezHLNgL/07Lq4W38S8x 7QJOvo7D+dtfY62vdxaeSa5832NDBy1wcRtoSpTKpMpnrvIGDHb4yEZa485WSraY1Mis K9sDj747pso9N9WHul3YQ6TO3HWakI6UTzZIX/3EStFZOurxJzKWzOy9Mogkf/7RTzKA CLgt0ljFTI8ZuzSSnwmhygmATrSeHYYPBA+6opn5ARig/FsZtyz9oAR2SZmJcDYjHsW8 1qiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aWtPp9gHavbCe/72TWGgyPSN8olgIQaG6jqiqoJFlvo=; b=dR6QNkfQWbKIDLGWWwnap50ShXEt/xYFisNNnpAs8deTzlcVU5zVaiCs5Q3aMgY4u4 NawFEON505vkz8OKZ87ATY1gKiOHE5Af4umL7kYrBInpe1Fl7ymP2mj8GyMZ2t54cwLL xkjKwHIaCRO/YJRP3NLQbMhQthGpti3G9Db482GA1omhlJxYC4RvumJiixyOr+Cuj70+ gM1VIl08XOQaPn/h6bE6xdV3H2QyX1oWNiqp9p1uxvVGEgMen71DSF5mizpDBYCAv1e2 4CLAGGhG0L8gz5vfbRG6YrZKW3H3vA3A0RGkh9wL6+3BgO2m7W55tF3bra71hTCFcSlF m2EA== X-Gm-Message-State: AOAM531iluuoJGe1+vZ7vZ7Xf+gcczN5PPxPo/iLugpSH2DaXELRKKWP d0V4N+YnLhvoSnC4Drb5LECnOw== X-Google-Smtp-Source: ABdhPJwIYIZYgdYmZztlZdIGYIS82jCeVXSf1N3R2HJLRYsb6Fdyu/sqywudX8SMQNietyqX8pg5fQ== X-Received: by 2002:a17:90b:350c:b0:1bf:1dc5:1c3d with SMTP id ls12-20020a17090b350c00b001bf1dc51c3dmr7361081pjb.53.1646420504531; Fri, 04 Mar 2022 11:01:44 -0800 (PST) Received: from google.com (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with ESMTPSA id z2-20020a17090a170200b001bf2d530d64sm2136862pjd.2.2022.03.04.11.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 11:01:43 -0800 (PST) Date: Fri, 4 Mar 2022 11:01:40 -0800 From: Ricardo Koller To: Marc Zyngier Cc: Oliver Upton , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, drjones@redhat.com, pbonzini@redhat.com, alexandru.elisei@arm.com, eric.auger@redhat.com, reijiw@google.com, rananta@google.com Subject: Re: [PATCH 2/3] KVM: arm64: selftests: add arch_timer_edge_cases Message-ID: References: <20220302172144.2734258-1-ricarkol@google.com> <20220302172144.2734258-3-ricarkol@google.com> <87h78etasf.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h78etasf.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Mar 04, 2022 at 07:52:00AM +0000, Marc Zyngier wrote: > On Wed, 02 Mar 2022 21:25:28 +0000, > Ricardo Koller wrote: > > > > Hi Oliver, > > > > On Wed, Mar 02, 2022 at 08:45:53PM +0000, Oliver Upton wrote: > > > Hi Ricardo, > > > > > > On Wed, Mar 02, 2022 at 09:21:43AM -0800, Ricardo Koller wrote: > > > > Add an arch_timer edge-cases selftest. For now, just add some basic > > > > sanity checks, and some stress conditions (like waiting for the timers > > > > while re-scheduling the vcpu). The next commit will add the actual edge > > > > case tests. > > > > > > > > This test fails without a867e9d0cc1 "KVM: arm64: Don't miss pending > > > > interrupts for suspended vCPU". > > > > > > > > > > Testing timer correctness is extremely challenging to do without > > > inherent flakiness. I have some concerns about the expectations that a > > > timer IRQ should fire in a given amount of time, as it is possible to > > > flake for any number of benign reasons (such as high CPU load in the > > > host). > > > > > > While the architecture may suggest that the timer should fire as soon as > > > CVAL is met: > > > > > > TimerConditionMet = (((Counter[63:0] – Offset[63:0])[63:0] - CompareValue[63:0]) >= 0) > > > > > > However, the architecture is extremely imprecise as to when an interrupt > > > should be taken: > > > > > > In the absence of a specific requirement to take an interrupt, the > > > architecture only requires that unmasked pending interrupts are taken > > > in finite time. [DDI0487G.b D1.13.4 "Prioritization and recognition of > > > interrupts"] > > > > > > It seems to me that the only thing we can positively assert is that a > > > timer interrupt should never be taken early. Now -- I agree that there > > > is value in testing that the interrupt be taken in bounded time, but its > > > hard to pick a good value for it. > > > > Yes, a timer that never fires passes the test, but it's not very useful. > > > > I saw delay issues immediately after testing with QEMU. I've been played > > with values and found that 1ms is enough for all of my runs (QEMU > > included) to pass (10000 iterations concurrently on all my 64 cpus). I > > just checked in the fast model and 1ms seems to be enough as well > > (although I didn't check for so long). > > > > /* 1ms sounds a bit excessive, but QEMU-TCG is slow. */ > > #define TEST_MARGIN_US 1000ULL > > I'm not sure that's even realistic. I can arbitrary delay those by > oversubscribing the system. > > > > > > > > > Perhaps documenting the possibility of flakes in the test is warranted, > > > along with some knobs to adjust these values for any particularly bad > > > implementation. > > > > What about having a cmdline arg to enable those tests? > > How is that handled in kvm-unit-tests? I'd rather avoid special > arguments, as they will never be set. All tests should run by default. There's this latency test that checks that the latency for a 10ms timer is not delayed by more than 10ms (after the first 10ms): report(test_cval_10msec(info), "latency within 10 ms"); Just to be safe I will just remove the checks for timers firing before some margin (not even with a special argument). Thanks, Ricardo > > M. > > -- > Without deviation from the norm, progress is not possible.