All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	agross@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, shawn.guo@linaro.org,
	vkoul@kernel.org, linux-phy@lists.infradead.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly
Date: Fri, 4 Mar 2022 17:58:57 -0600	[thread overview]
Message-ID: <YiKnwTZXev/ciErl@robh.at.kernel.org> (raw)
In-Reply-To: <20220228123019.382037-8-bhupesh.sharma@linaro.org>

On Mon, Feb 28, 2022 at 06:00:18PM +0530, Bhupesh Sharma wrote:
> Currently the qcom,qmp-phy dt-binding doesn't describe
> the 'reg' and '#phy-cells' properties for the phy@ subnode.
> 
> Fix the same.
> 
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 70e7cd75e173..f8a43acd229a 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -115,6 +115,13 @@ patternProperties:
>        Each device node of QMP phy is required to have as many child nodes as
>        the number of lanes the PHY has.
>      properties:
> +      reg:
> +        minItems: 1
> +        maxItems: 6

You need to define what each entry is.

> +
> +      "#phy-cells":
> +        const: 0
> +
>        "#clock-cells":
>          enum: [ 0, 1, 2 ]
>  
> -- 
> 2.35.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	agross@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, shawn.guo@linaro.org,
	vkoul@kernel.org, linux-phy@lists.infradead.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: Describe phy@ subnode properly
Date: Fri, 4 Mar 2022 17:58:57 -0600	[thread overview]
Message-ID: <YiKnwTZXev/ciErl@robh.at.kernel.org> (raw)
In-Reply-To: <20220228123019.382037-8-bhupesh.sharma@linaro.org>

On Mon, Feb 28, 2022 at 06:00:18PM +0530, Bhupesh Sharma wrote:
> Currently the qcom,qmp-phy dt-binding doesn't describe
> the 'reg' and '#phy-cells' properties for the phy@ subnode.
> 
> Fix the same.
> 
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 70e7cd75e173..f8a43acd229a 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -115,6 +115,13 @@ patternProperties:
>        Each device node of QMP phy is required to have as many child nodes as
>        the number of lanes the PHY has.
>      properties:
> +      reg:
> +        minItems: 1
> +        maxItems: 6

You need to define what each entry is.

> +
> +      "#phy-cells":
> +        const: 0
> +
>        "#clock-cells":
>          enum: [ 0, 1, 2 ]
>  
> -- 
> 2.35.1
> 
> 

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2022-03-04 23:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 12:30 [PATCH v2 0/8] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma
2022-02-28 12:30 ` Bhupesh Sharma
2022-02-28 12:30 ` [PATCH v2 1/8] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 1/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  3:55   ` [PATCH v2 1/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  3:55     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 2/8] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 2/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  4:15   ` [PATCH v2 2/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  4:15     ` Shawn Guo
2022-03-04 23:58   ` Rob Herring
2022-03-04 23:58     ` Rob Herring
2022-02-28 12:30 ` [PATCH v2 3/8] arm64: dts: qcom: msm8996-xiaomi: Drop max-microamp and vddp-ref-clk properties from QMP PHY Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:22   ` Shawn Guo
2022-03-01  4:22     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 4/8] arm64: dts: qcom: sc7280: Fix qmp phy node (use phy@ instead of lanes@) Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:09   ` Shawn Guo
2022-03-01  4:09     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 5/8] arm64: dts: qcom: sm8450: Fix qmp ufs " Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:10   ` Shawn Guo
2022-03-01  4:10     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:11   ` Shawn Guo
2022-03-01  4:11     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  4:07   ` [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  4:07     ` [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: " Shawn Guo
2022-03-04 23:58   ` Rob Herring [this message]
2022-03-04 23:58     ` Rob Herring
2022-02-28 12:30 ` [PATCH v2 8/8] dt-bindings: phy: qcom,qmp: Mark 'vdda-pll-supply' & 'vdda-phy-supply' as optional Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 8/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  3:39   ` [PATCH v2 8/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  3:39     ` Shawn Guo
2022-03-01  3:47   ` Bjorn Andersson
2022-03-01  3:47     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiKnwTZXev/ciErl@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bhupesh.sharma@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=shawn.guo@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.