From: Huang Rui <ray.huang@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"srinivas.pandruvada@linux.intel.com"
<srinivas.pandruvada@linux.intel.com>,
"dsmythies@telus.net" <dsmythies@telus.net>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"todd.e.brandt@linux.intel.com" <todd.e.brandt@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"Yuan, Perry" <Perry.Yuan@amd.com>,
"Meng, Li (Jassmine)" <Li.Meng@amd.com>
Subject: Re: [PATCH V2 1/4] cpufreq: amd-pstate: Add more tracepoint for AMD P-State module
Date: Mon, 7 Mar 2022 10:53:38 +0800 [thread overview]
Message-ID: <YiVzssDCijRWZLoK@amd.com> (raw)
In-Reply-To: <CAJZ5v0jG2uodQGrWv01xLcDLgdU1MRs5vyJ5s+E4L0U4-GuR0g@mail.gmail.com>
On Sat, Mar 05, 2022 at 02:49:51AM +0800, Rafael J. Wysocki wrote:
> On Fri, Mar 4, 2022 at 7:42 AM Huang Rui <ray.huang@amd.com> wrote:
> >
> > On Fri, Mar 04, 2022 at 02:07:21PM +0800, Su, Jinzhou (Joe) wrote:
> > > Add frequency, mperf, aperf and tsc in the trace. This can be used
> > > to debug and tune the performance of AMD P-state driver.
> > >
> > > Use the time difference between amd_pstate_update to calculate CPU
> > > frequency. There could be sleep in arch_freq_get_on_cpu, so do not
> > > use it here.
> > >
> > > Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>
> > > Co-developed-by: Huang Rui <ray.huang@amd.com>
> > > Signed-off-by: Huang Rui <ray.huang@amd.com>
> >
> > Let's remove "Signed-off-by" of me, just leave "Co-developed-by".
>
> Actually, they both need to be present (the C-d-b clarifies the S-o-b
> meaning), so the above is correct.
>
OK, I see. Thanks to clarify this.
Best Regards,
Ray
next prev parent reply other threads:[~2022-03-07 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 6:07 [PATCH V2 0/4] Add tracer tool for AMD P-State driver Jinzhou Su
2022-03-04 6:07 ` [PATCH V2 1/4] cpufreq: amd-pstate: Add more tracepoint for AMD P-State module Jinzhou Su
2022-03-04 6:42 ` Huang Rui
2022-03-04 18:49 ` Rafael J. Wysocki
2022-03-07 2:53 ` Huang Rui [this message]
2022-03-09 1:23 ` Su, Jinzhou (Joe)
2022-03-09 13:29 ` Huang Rui
2022-03-04 6:07 ` [PATCH V2 2/4] tools/power/x86/intel_pstate_tracer: make tracer as a module Jinzhou Su
2022-03-04 6:44 ` Huang Rui
2022-03-04 6:07 ` [PATCH V2 3/4] tools/power/x86/amd_pstate_tracer: Add tracer tool for AMD P-state Jinzhou Su
2022-03-04 6:48 ` Huang Rui
2022-03-04 6:07 ` [PATCH V2 4/4] Documentation: amd-pstate: add tracer tool introduction Jinzhou Su
2022-03-04 6:56 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiVzssDCijRWZLoK@amd.com \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=todd.e.brandt@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.