From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EB5CC433F5 for ; Mon, 7 Mar 2022 16:17:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F9531712; Mon, 7 Mar 2022 17:16:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F9531712 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646669854; bh=8tjddFmERVub+eJeodtYbStmrrQSVt5R8T5mKB/8hxw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TE3wJVa8zKQRFxuktAanZNlcZ7N47mQHCHE7GYMIFRVgn7fZdx5g8bQVv6hXJUiFP awxeOECw9BiTvURMcdguSf85tWrgv/UdlDl91Y4ykPa5uiMsfsugsFVT9G56KnSZzR k73WfblsqaYgl6oiq9E6WPhDxAnYo9cp0bCzNoj4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 046FEF8020D; Mon, 7 Mar 2022 17:16:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D6562F80271; Mon, 7 Mar 2022 17:16:31 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 635D6F80132 for ; Mon, 7 Mar 2022 17:16:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 635D6F80132 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t7xUG4Ja" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CF4360C58; Mon, 7 Mar 2022 16:16:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE714C36AE5; Mon, 7 Mar 2022 16:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646669785; bh=8tjddFmERVub+eJeodtYbStmrrQSVt5R8T5mKB/8hxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t7xUG4JaGuaEIgWxfFOunf5ycNgeq7Zdo4Yvt8CDhYQt91/PFY0sE17x7YrnNnYCN /1ZTy7VQREK8Tig2yKhrsLU9aE+NbthGUC0KmrQUVFvpHhKvKG+uHWhyhAqZ2xpkyj FKbBIMOePuBO0thU4zG9Fk4BvRWQRrDydLJkqA3ZmvzHlQ+2Wz3SjgF5XcmnLavP53 CFyAmzGCxwXxasc85l334HJTdkxByQVj3Qc7OlfWXyshcfqKhD2Zoc0b2MZ8InLQ/s Ed7TpFuOFBWnPjBqnzHAeEdObsuNTJUL3YIGJjSgcNmFVwoV2r1QhLqlaFgXUOcsG7 IthLpKFApUKZg== Date: Mon, 7 Mar 2022 16:16:19 +0000 From: Mark Brown To: Alifer Moraes Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support Message-ID: References: <20220307141041.27538-1-alifer.m@variscite.com> <20220307141041.27538-3-alifer.m@variscite.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9yotZ5uYT3fHlEJd" Content-Disposition: inline In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com> X-Cookie: Whatever became of eternal truth? Cc: pierluigi.p@variscite.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, shengjiu.wang@gmail.com, tiwai@suse.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, eran.m@variscite.com, robh+dt@kernel.org, patches@opensource.cirrus.com, festevam@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --9yotZ5uYT3fHlEJd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote: > + - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property > + > + - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC) > + The list must be (4 x num-drc-cfgs) entries long. > + If absent or incomplete, DRC is disabled. What is the purpose of having num-drc-cfgs? We can tell how large drc-cfg-regs is so it just seems redundant. > + - num-retune-mobile-cfgs: Number of retune modes available from > + retune-mobile-cfg-regs property Same here. --9yotZ5uYT3fHlEJd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmImL9IACgkQJNaLcl1U h9D0nQf/e94yrWlNJbnJEWkZM5yQ9NWqCSnHkn9vGfNqeP08qmHuPx5rKMPsJlQE U3iaSMsrPstH1JbpQM4gp9uh+Fg6VvM5/qWyJo1MgSaaMV90p9JUzhnyWGx4JiHq /i7xUGfwLOBdC3jP7IxCeDnXlTfgdp/4XgTTzjlS1iOnQbnFUCV1LBCFf4KF02/5 F74oQX80r26mdT9BlqXSM9FpuiVJq3E7Ckzo6ilYR1u5C8MCtzZmR0LGnb3mihWs f46WBAlRgZqIWd56ISFJlOyCuM8oXNikquhN20NGRraagoxbvQQeC7zvBIDAMuZE YK+1RvyQrlT86QdGrRg9lBdvKY+14w== =gOHh -----END PGP SIGNATURE----- --9yotZ5uYT3fHlEJd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49919C433F5 for ; Mon, 7 Mar 2022 16:17:10 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KC3WR71NMz3bSm for ; Tue, 8 Mar 2022 03:17:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=t7xUG4Ja; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=broonie@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=t7xUG4Ja; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KC3Vh5JJ5z2xF0 for ; Tue, 8 Mar 2022 03:16:28 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CF4360C58; Mon, 7 Mar 2022 16:16:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE714C36AE5; Mon, 7 Mar 2022 16:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646669785; bh=8tjddFmERVub+eJeodtYbStmrrQSVt5R8T5mKB/8hxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t7xUG4JaGuaEIgWxfFOunf5ycNgeq7Zdo4Yvt8CDhYQt91/PFY0sE17x7YrnNnYCN /1ZTy7VQREK8Tig2yKhrsLU9aE+NbthGUC0KmrQUVFvpHhKvKG+uHWhyhAqZ2xpkyj FKbBIMOePuBO0thU4zG9Fk4BvRWQRrDydLJkqA3ZmvzHlQ+2Wz3SjgF5XcmnLavP53 CFyAmzGCxwXxasc85l334HJTdkxByQVj3Qc7OlfWXyshcfqKhD2Zoc0b2MZ8InLQ/s Ed7TpFuOFBWnPjBqnzHAeEdObsuNTJUL3YIGJjSgcNmFVwoV2r1QhLqlaFgXUOcsG7 IthLpKFApUKZg== Date: Mon, 7 Mar 2022 16:16:19 +0000 From: Mark Brown To: Alifer Moraes Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support Message-ID: References: <20220307141041.27538-1-alifer.m@variscite.com> <20220307141041.27538-3-alifer.m@variscite.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9yotZ5uYT3fHlEJd" Content-Disposition: inline In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com> X-Cookie: Whatever became of eternal truth? X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pierluigi.p@variscite.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, shengjiu.wang@gmail.com, tiwai@suse.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, eran.m@variscite.com, robh+dt@kernel.org, patches@opensource.cirrus.com, perex@perex.cz, festevam@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --9yotZ5uYT3fHlEJd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote: > + - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property > + > + - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC) > + The list must be (4 x num-drc-cfgs) entries long. > + If absent or incomplete, DRC is disabled. What is the purpose of having num-drc-cfgs? We can tell how large drc-cfg-regs is so it just seems redundant. > + - num-retune-mobile-cfgs: Number of retune modes available from > + retune-mobile-cfg-regs property Same here. --9yotZ5uYT3fHlEJd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmImL9IACgkQJNaLcl1U h9D0nQf/e94yrWlNJbnJEWkZM5yQ9NWqCSnHkn9vGfNqeP08qmHuPx5rKMPsJlQE U3iaSMsrPstH1JbpQM4gp9uh+Fg6VvM5/qWyJo1MgSaaMV90p9JUzhnyWGx4JiHq /i7xUGfwLOBdC3jP7IxCeDnXlTfgdp/4XgTTzjlS1iOnQbnFUCV1LBCFf4KF02/5 F74oQX80r26mdT9BlqXSM9FpuiVJq3E7Ckzo6ilYR1u5C8MCtzZmR0LGnb3mihWs f46WBAlRgZqIWd56ISFJlOyCuM8oXNikquhN20NGRraagoxbvQQeC7zvBIDAMuZE YK+1RvyQrlT86QdGrRg9lBdvKY+14w== =gOHh -----END PGP SIGNATURE----- --9yotZ5uYT3fHlEJd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F342C433F5 for ; Mon, 7 Mar 2022 16:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238176AbiCGQRW (ORCPT ); Mon, 7 Mar 2022 11:17:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244075AbiCGQRV (ORCPT ); Mon, 7 Mar 2022 11:17:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA8645AC9; Mon, 7 Mar 2022 08:16:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A45A60BAD; Mon, 7 Mar 2022 16:16:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE714C36AE5; Mon, 7 Mar 2022 16:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646669785; bh=8tjddFmERVub+eJeodtYbStmrrQSVt5R8T5mKB/8hxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t7xUG4JaGuaEIgWxfFOunf5ycNgeq7Zdo4Yvt8CDhYQt91/PFY0sE17x7YrnNnYCN /1ZTy7VQREK8Tig2yKhrsLU9aE+NbthGUC0KmrQUVFvpHhKvKG+uHWhyhAqZ2xpkyj FKbBIMOePuBO0thU4zG9Fk4BvRWQRrDydLJkqA3ZmvzHlQ+2Wz3SjgF5XcmnLavP53 CFyAmzGCxwXxasc85l334HJTdkxByQVj3Qc7OlfWXyshcfqKhD2Zoc0b2MZ8InLQ/s Ed7TpFuOFBWnPjBqnzHAeEdObsuNTJUL3YIGJjSgcNmFVwoV2r1QhLqlaFgXUOcsG7 IthLpKFApUKZg== Date: Mon, 7 Mar 2022 16:16:19 +0000 From: Mark Brown To: Alifer Moraes Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, eran.m@variscite.com, festevam@gmail.com, lgirdwood@gmail.com, linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com, patches@opensource.cirrus.com, perex@perex.cz, pierluigi.p@variscite.com, robh+dt@kernel.org, shengjiu.wang@gmail.com, tiwai@suse.com, Xiubo.Lee@gmail.com Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support Message-ID: References: <20220307141041.27538-1-alifer.m@variscite.com> <20220307141041.27538-3-alifer.m@variscite.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9yotZ5uYT3fHlEJd" Content-Disposition: inline In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com> X-Cookie: Whatever became of eternal truth? Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --9yotZ5uYT3fHlEJd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote: > + - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property > + > + - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC) > + The list must be (4 x num-drc-cfgs) entries long. > + If absent or incomplete, DRC is disabled. What is the purpose of having num-drc-cfgs? We can tell how large drc-cfg-regs is so it just seems redundant. > + - num-retune-mobile-cfgs: Number of retune modes available from > + retune-mobile-cfg-regs property Same here. --9yotZ5uYT3fHlEJd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmImL9IACgkQJNaLcl1U h9D0nQf/e94yrWlNJbnJEWkZM5yQ9NWqCSnHkn9vGfNqeP08qmHuPx5rKMPsJlQE U3iaSMsrPstH1JbpQM4gp9uh+Fg6VvM5/qWyJo1MgSaaMV90p9JUzhnyWGx4JiHq /i7xUGfwLOBdC3jP7IxCeDnXlTfgdp/4XgTTzjlS1iOnQbnFUCV1LBCFf4KF02/5 F74oQX80r26mdT9BlqXSM9FpuiVJq3E7Ckzo6ilYR1u5C8MCtzZmR0LGnb3mihWs f46WBAlRgZqIWd56ISFJlOyCuM8oXNikquhN20NGRraagoxbvQQeC7zvBIDAMuZE YK+1RvyQrlT86QdGrRg9lBdvKY+14w== =gOHh -----END PGP SIGNATURE----- --9yotZ5uYT3fHlEJd--