From: Ming Lei <ming.lei@redhat.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH] block: fix blk_mq_attempt_bio_merge and rq_qos_throttle protection
Date: Wed, 9 Mar 2022 08:44:11 +0800 [thread overview]
Message-ID: <Yif4WwqMAKA7YsJY@T590> (raw)
In-Reply-To: <20220308080915.3473689-1-shinichiro.kawasaki@wdc.com>
On Tue, Mar 08, 2022 at 05:09:15PM +0900, Shin'ichiro Kawasaki wrote:
> Commit 9d497e2941c3 ("block: don't protect submit_bio_checks by
> q_usage_counter") moved blk_mq_attempt_bio_merge and rq_qos_throttle
> calls out of q_usage_counter protection. However, these functions require
> q_usage_counter protection. The blk_mq_attempt_bio_merge call without
> the protection resulted in blktests block/005 failure with KASAN null-
> ptr-deref or use-after-free at bio merge. The rq_qos_throttle call
> without the protection caused kernel hang at qos throttle.
>
> To fix the failures, move the blk_mq_attempt_bio_merge and
> rq_qos_throttle calls back to q_usage_counter protection.
>
> Fixes: 9d497e2941c3 ("block: don't protect submit_bio_checks by q_usage_counter")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Looks fine,
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2022-03-09 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 8:09 [PATCH] block: fix blk_mq_attempt_bio_merge and rq_qos_throttle protection Shin'ichiro Kawasaki
2022-03-09 0:44 ` Ming Lei [this message]
2022-03-09 0:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yif4WwqMAKA7YsJY@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.