From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5343C433EF for ; Thu, 10 Mar 2022 22:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243632AbiCJWJs (ORCPT ); Thu, 10 Mar 2022 17:09:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231720AbiCJWJq (ORCPT ); Thu, 10 Mar 2022 17:09:46 -0500 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E0C25FF0B; Thu, 10 Mar 2022 14:08:44 -0800 (PST) Received: by mail-oi1-f172.google.com with SMTP id i5so7467876oih.1; Thu, 10 Mar 2022 14:08:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GztXpK6SPTIyxzIRwB00EenGjs45KWX35sMuyhlmPpU=; b=GZ75RRYfoVt+a2ZrusJwWltreHe5l+V6aVFQl9kog+uJyH6SamfT2u2zBusSZ2kLQ5 iYA8ki1IG/OCjaoo1dsgzvDYD6cReUFwTQaMYFpjTm0d2rQ9++7ePRulwJks+WK2ZuSP ilMOKCwOGxfWZlYjEewxwBYI6rvSTZPAsVkKr5anMno+yGwz4NGzLvFUSmIcdj0FVx0N 2YVBfl3aGxwYvcUZL9gI6RadbLWnDU0P2sIYYJiqWJOd2aUHDRT4ZJenNpwwZg2yYAhD N0hwURvUZTvAHk6O3jGCntHvCmZYADvqkYB2xzZAb+CMmqqAOQWE7nTGK5PNIu+amrG3 3YZg== X-Gm-Message-State: AOAM532bl+OKbBX/PoGe+YMRY0WxX9g8yrvmPLxYSjn13wlBfVcmt+JM xLSjLoOqdtXoEU2+0TeORA== X-Google-Smtp-Source: ABdhPJwgQc+zfIEQEAib3LEcQDo2r5x+1lCXfEqstYLiqQlMBshBEb5XHipt1XA35c6g6Y5b5JH66w== X-Received: by 2002:a05:6808:1205:b0:2d4:6eed:edd1 with SMTP id a5-20020a056808120500b002d46eededd1mr4493480oil.154.1646950123843; Thu, 10 Mar 2022 14:08:43 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id a27-20020a4ae93b000000b0031be7c7d2d3sm3050672ooe.0.2022.03.10.14.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:08:43 -0800 (PST) Received: (nullmailer pid 2169492 invoked by uid 1000); Thu, 10 Mar 2022 22:08:42 -0000 Date: Thu, 10 Mar 2022 16:08:42 -0600 From: Rob Herring To: Kuldeep Singh Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Robin Murphy , Linus Walleij , Krzysztof Kozlowski Subject: Re: [PATCH v2 2/2] dt-bindings: spi: Update clock-names property for ARM pl022 Message-ID: References: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> <20220308072125.38381-2-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308072125.38381-2-singh.kuldeep87k@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Tue, Mar 08, 2022 at 12:51:25PM +0530, Kuldeep Singh wrote: > Pl022 clock-names can be one of following: > ['apb_pclk'] or ['sspclk', 'apb_pclk'] > > The current schema refers to second case only. Make necessary changes to > incorporate both the cases and resolve below dtc warning: > clock-names: 'apb_pclk' is not one of ['sspclk'] > > Signed-off-by: Kuldeep Singh > --- > v2: > - Reword commit message > - Drop SSPCLK > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 7d36e15db5b3..6cfab948624e 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -38,11 +38,13 @@ properties: > maxItems: 2 > > clock-names: > - items: > + oneOf: > - enum: > - - SSPCLK > - - sspclk > - - const: apb_pclk > + - apb_pclk Are you going to make the driver work with no SPI clock? Because this change is saying that it is valid to have the APB bus clock and no SPI clock. Rob > + - items: > + - enum: > + - sspclk > + - const: apb_pclk > > pl022,autosuspend-delay: > description: delay in ms following transfer completion before the > -- > 2.25.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 257FEC433EF for ; Thu, 10 Mar 2022 22:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eD6MDoQJ4o7AsJ/o7d8Qv2g0hmvbeS/MTWQnI5HXCUU=; b=e60fQp47NJr92U uqZlTau0jgusW/cALLhIe9e77+qUyXkXWtQ8xD0veBjqZvn+BxoUAEBxe8oShmUBsN/0N4scKZBNT ExPokJYzLHaodQ/f9AV3vIPuSLcWrz4arZlkOioybPgEV+XQ1ZoBFP5F8Z540JYcyHQYYbXwCgbW5 FuKcHDocMTpx6XNIC+RnZKnxGCiOL5plN/5nQckSuH4/5m5CnCI19n4zqtdNQmrb2OpvNcpZO0GDF K2ybHbG1dsioDK3pPswyGpyLtY4yeLX1vj7lAF+bRvnFBy9MLg2uUDP5h2GZt+HdEws4w/mYW+UQd 9/spDcjHTVXYCTlcoYIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSQxj-00E9Qd-IR; Thu, 10 Mar 2022 22:08:47 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSQxg-00E9Q4-RC for linux-arm-kernel@lists.infradead.org; Thu, 10 Mar 2022 22:08:46 +0000 Received: by mail-oi1-f180.google.com with SMTP id q189so7411877oia.9 for ; Thu, 10 Mar 2022 14:08:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GztXpK6SPTIyxzIRwB00EenGjs45KWX35sMuyhlmPpU=; b=nbRsC480dcIjNegbe6zxb7p2bHo+Wv5VHdfL/F0NjOT+gbR3wkz9Vo/hLCG+O0OYkh c1ln75zh/CjHj3/Z/9ZZRj8fR7BVK3LwBC2SUcAIM+R9lgoa9E8oTcVtjz3R+fiwQtVa ixiUNoOQQCZDbKaIdky0kTIHtn37uotNknL+EeD+e/GxO0Kjd9xW26Ev7gTBTXjWPcvf /3hPZcY08c+TD0x6Lc5PxCNo9EwJrDJk7xTd21x1vGxFLDZdxBRM9CO8rbOnxE21yUSa 7W99hJZDS5xv6z4XYr1OHQK0kIPDYjPTpGhSIa61O2sa4Nfu7oCUWtBNaH9XUKHXSpov LRlg== X-Gm-Message-State: AOAM532RMgibEJZTdD9jGA+WjpEB4f0583271wI9d7/fKiHOFBxRGh/e bBCJ1A3R5EtVBdTg0ZgNNQ== X-Google-Smtp-Source: ABdhPJwgQc+zfIEQEAib3LEcQDo2r5x+1lCXfEqstYLiqQlMBshBEb5XHipt1XA35c6g6Y5b5JH66w== X-Received: by 2002:a05:6808:1205:b0:2d4:6eed:edd1 with SMTP id a5-20020a056808120500b002d46eededd1mr4493480oil.154.1646950123843; Thu, 10 Mar 2022 14:08:43 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id a27-20020a4ae93b000000b0031be7c7d2d3sm3050672ooe.0.2022.03.10.14.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:08:43 -0800 (PST) Received: (nullmailer pid 2169492 invoked by uid 1000); Thu, 10 Mar 2022 22:08:42 -0000 Date: Thu, 10 Mar 2022 16:08:42 -0600 From: Rob Herring To: Kuldeep Singh Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Robin Murphy , Linus Walleij , Krzysztof Kozlowski Subject: Re: [PATCH v2 2/2] dt-bindings: spi: Update clock-names property for ARM pl022 Message-ID: References: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> <20220308072125.38381-2-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308072125.38381-2-singh.kuldeep87k@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_140844_918506_517736FF X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 12:51:25PM +0530, Kuldeep Singh wrote: > Pl022 clock-names can be one of following: > ['apb_pclk'] or ['sspclk', 'apb_pclk'] > > The current schema refers to second case only. Make necessary changes to > incorporate both the cases and resolve below dtc warning: > clock-names: 'apb_pclk' is not one of ['sspclk'] > > Signed-off-by: Kuldeep Singh > --- > v2: > - Reword commit message > - Drop SSPCLK > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 7d36e15db5b3..6cfab948624e 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -38,11 +38,13 @@ properties: > maxItems: 2 > > clock-names: > - items: > + oneOf: > - enum: > - - SSPCLK > - - sspclk > - - const: apb_pclk > + - apb_pclk Are you going to make the driver work with no SPI clock? Because this change is saying that it is valid to have the APB bus clock and no SPI clock. Rob > + - items: > + - enum: > + - sspclk > + - const: apb_pclk > > pl022,autosuspend-delay: > description: delay in ms following transfer completion before the > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel