From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA298C433F5 for ; Thu, 10 Mar 2022 22:13:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 32AFF1915; Thu, 10 Mar 2022 23:12:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 32AFF1915 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646950410; bh=SrbeWDUJA575QGcisqemZrmpfYz8rpK9Vq7rnn0N194=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BRsohp37sgHiEr6uYVWZ8apKDdJyqy6uLQZDf3cHL43FnqYEte+vYj+47nqWf16Fr KuohqODt9xu5A8MVL/V+70PVBhtU5E07PgyRx8Rccjnr5asCGT2+UVf9Zdw7L/4o8C Qy93uH7FZ3wWou2U3LDKgHg9LdzsLgDs23NCRICo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8FAC8F8012F; Thu, 10 Mar 2022 23:12:39 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2AF37F80137; Thu, 10 Mar 2022 23:12:38 +0100 (CET) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6B06AF800FD for ; Thu, 10 Mar 2022 23:12:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6B06AF800FD Received: by mail-oi1-f172.google.com with SMTP id 12so7418529oix.12 for ; Thu, 10 Mar 2022 14:12:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=omjoz0M9biHPr5EKrbgbc5QfautyWsC0HyZJaIjRDEg=; b=7GPRsDeNfYIXTqfL8K/iabODFxmcKxNxgdCdqNAr2W1E8+KTrAPJ2Nqwd2ZkW2bKAZ U9Ta8N+aWdh0M3GgUnB9wfVc+xr+UBRh8O/jszEvzymYQl4VH1MLP3INESbzTfmURRDB 22Hdmvk78TAPm9LVuWDV428FdNXg3DUoPD8kO7hE+HDeKOmr+VkYHm0NdCO8bPnGso0A YXk6k41UF5nksSCr9XOXh78QAOGpyl6a9pIoyca30RclbQsnwwsaRDPraWQNmSnMQt0G 0MQh37WcaxTvqLzrEdpDKcHS+hQSSu7vU/20i+qHghEduSBMo+Dhho8i3KvysYEg4kCN Lrrw== X-Gm-Message-State: AOAM53268ioWHcOd2sJm2Uk/y3/0BI609sRc2wndtsfVpOEkhBNgqSrQ CDxdtuqEh5a+xXHM6kX6rA== X-Google-Smtp-Source: ABdhPJxHna6A8giuUalT7X77knNuIyLF0eFu5RYM8FUTp80V2T9F0GnnEXgbqAyoeBJg75biyF6+tw== X-Received: by 2002:a05:6808:1528:b0:2da:7f1d:f847 with SMTP id u40-20020a056808152800b002da7f1df847mr1796358oiw.85.1646950353167; Thu, 10 Mar 2022 14:12:33 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c14-20020a056870b28e00b000d7d5962242sm2821551oao.35.2022.03.10.14.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:12:32 -0800 (PST) Received: (nullmailer pid 2175473 invoked by uid 1000); Thu, 10 Mar 2022 22:12:31 -0000 Date: Thu, 10 Mar 2022 16:12:31 -0600 From: Rob Herring To: Trevor Wu Subject: Re: [PATCH 2/5] dt-bindings: mediatek: mt8195: add reset property Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308072435.22460-3-trevor.wu@mediatek.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-mediatek@lists.infradead.org, yc.hung@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Mar 08, 2022 at 03:24:32PM +0800, Trevor Wu wrote: > Add required properties "resets" and "reset_names", which are used to > specify audiosys hw reset for mt8195 afe driver. The subject needs to be more specific and indicate this applies to ASoC and mt8195-afe-pcm. Try to write subjects that could only ever appear once as you can never make the same change twice. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0C60C433EF for ; Thu, 10 Mar 2022 22:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q6iNDbY6eucLcPlZoLKJcJ9YCaBJy/YONdkYlP7II9A=; b=sg9iMBkfad5z0V ti0fj7jCco1MjqJWej6+JUu0Od5zFR9ex1eveayKKJwdqrNJcLyFrZAL7sTJU9pHPeJ8Nqa3SPPl6 s/H0tE9RobwMrQsUAYRxPx9TgLlYVMDoLZNSMcS0lQvSeIrdEjGMZZh6V/EwaUL+Sqc6tPuWTSJLi EACqBLdyon/oRXWsHhs1KjDs2zW1I7nCpiKNk8EfXk97tgpupDXWrBn9S98PXKxr0Tu1LpOLDZ5EZ cMmxePdhqr0EdOv+5egK9XhBHj2/VasVO01ewOVRWi8XebiVQAbzUQb4GODDspSP5bURDzOFeMqql uKQaj283m5VCU7YtEx2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR1Q-00EAV7-EB; Thu, 10 Mar 2022 22:12:36 +0000 Received: from mail-oi1-f170.google.com ([209.85.167.170]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR1N-00EAUR-VV; Thu, 10 Mar 2022 22:12:35 +0000 Received: by mail-oi1-f170.google.com with SMTP id n7so7444831oif.5; Thu, 10 Mar 2022 14:12:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=omjoz0M9biHPr5EKrbgbc5QfautyWsC0HyZJaIjRDEg=; b=IZMStZR5jAV3k3D0rMjJBwqKYepOfurfxd+EUuucYjeK7WhvuxsfsyWn1R+Qe769QT 37oMQnWTiNR/Ct4JDpMRC9NUHL2O0zv9jpySiRaxFEpwKktPe+eV59Ux+02fo38H2UmM ll5FXTvhzbSY2zUjVApammh0gi9CZVEAyAGdg6k6fhXkgmMLF8wad6vWXGxyPE+WO+az cHsvVR4bAEkfirK3BIxm1xhN0Cmv48qWRUUsIsWuPDCsA7cZvr0N3oenAI2U8OmnoqJN IyGm1P9Sc5iVOVFwqe4p+jyuS0ONRdElwQo/DiMqzx0Wsgy6SbPurC6Qep7BCNSMCYdm QsOw== X-Gm-Message-State: AOAM5322Mn/xVOBSLkHtmCjR/v8czUmkcpqMJEl93P83c41Y4bnCigHE 8HdVbUmun0ygCkkplJ3j6g== X-Google-Smtp-Source: ABdhPJxHna6A8giuUalT7X77knNuIyLF0eFu5RYM8FUTp80V2T9F0GnnEXgbqAyoeBJg75biyF6+tw== X-Received: by 2002:a05:6808:1528:b0:2da:7f1d:f847 with SMTP id u40-20020a056808152800b002da7f1df847mr1796358oiw.85.1646950353167; Thu, 10 Mar 2022 14:12:33 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c14-20020a056870b28e00b000d7d5962242sm2821551oao.35.2022.03.10.14.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:12:32 -0800 (PST) Received: (nullmailer pid 2175473 invoked by uid 1000); Thu, 10 Mar 2022 22:12:31 -0000 Date: Thu, 10 Mar 2022 16:12:31 -0600 From: Rob Herring To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, yc.hung@mediatek.com Subject: Re: [PATCH 2/5] dt-bindings: mediatek: mt8195: add reset property Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308072435.22460-3-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_141234_047094_4BD2307B X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 03:24:32PM +0800, Trevor Wu wrote: > Add required properties "resets" and "reset_names", which are used to > specify audiosys hw reset for mt8195 afe driver. The subject needs to be more specific and indicate this applies to ASoC and mt8195-afe-pcm. Try to write subjects that could only ever appear once as you can never make the same change twice. Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7FCDC433EF for ; Thu, 10 Mar 2022 22:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TaVtWOETJ0ecKZeUWq7YMNTsYjreNpul2uC7QFZKW8w=; b=R9iGt6PIt37+b/ /ogNqC41wh/SRCh72bcQbHICxbyshUthyHr33GcTexSNXA1RHC1fuMIsTHhFLrrLp9pNoulqWZU0Q CoUymBwbz7ICSDFvb0RJq5qcJcmh38lfmpW5lpCtUIbk++D3vNNtNjLZCgwSmpiiqeq1rve3//eBK LjV+9WPr2niehrtizKvCzTS4gFF/HaH0+wBuxZbptaj3KpDPAiC3vigs070oMEbXfN/UctJRooNPS CUngTzo5hPrWJtFYW2NoI2xeN4SqkIOYyE2sfRslTLjCWGOMjBeMainHSbged80ALEhoZEHcOlOBj 4CQxuG4R7COZwkgY1tyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR1S-00EAVN-6h; Thu, 10 Mar 2022 22:12:38 +0000 Received: from mail-oi1-f170.google.com ([209.85.167.170]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR1N-00EAUR-VV; Thu, 10 Mar 2022 22:12:35 +0000 Received: by mail-oi1-f170.google.com with SMTP id n7so7444831oif.5; Thu, 10 Mar 2022 14:12:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=omjoz0M9biHPr5EKrbgbc5QfautyWsC0HyZJaIjRDEg=; b=IZMStZR5jAV3k3D0rMjJBwqKYepOfurfxd+EUuucYjeK7WhvuxsfsyWn1R+Qe769QT 37oMQnWTiNR/Ct4JDpMRC9NUHL2O0zv9jpySiRaxFEpwKktPe+eV59Ux+02fo38H2UmM ll5FXTvhzbSY2zUjVApammh0gi9CZVEAyAGdg6k6fhXkgmMLF8wad6vWXGxyPE+WO+az cHsvVR4bAEkfirK3BIxm1xhN0Cmv48qWRUUsIsWuPDCsA7cZvr0N3oenAI2U8OmnoqJN IyGm1P9Sc5iVOVFwqe4p+jyuS0ONRdElwQo/DiMqzx0Wsgy6SbPurC6Qep7BCNSMCYdm QsOw== X-Gm-Message-State: AOAM5322Mn/xVOBSLkHtmCjR/v8czUmkcpqMJEl93P83c41Y4bnCigHE 8HdVbUmun0ygCkkplJ3j6g== X-Google-Smtp-Source: ABdhPJxHna6A8giuUalT7X77knNuIyLF0eFu5RYM8FUTp80V2T9F0GnnEXgbqAyoeBJg75biyF6+tw== X-Received: by 2002:a05:6808:1528:b0:2da:7f1d:f847 with SMTP id u40-20020a056808152800b002da7f1df847mr1796358oiw.85.1646950353167; Thu, 10 Mar 2022 14:12:33 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c14-20020a056870b28e00b000d7d5962242sm2821551oao.35.2022.03.10.14.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:12:32 -0800 (PST) Received: (nullmailer pid 2175473 invoked by uid 1000); Thu, 10 Mar 2022 22:12:31 -0000 Date: Thu, 10 Mar 2022 16:12:31 -0600 From: Rob Herring To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, yc.hung@mediatek.com Subject: Re: [PATCH 2/5] dt-bindings: mediatek: mt8195: add reset property Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308072435.22460-3-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_141234_047094_4BD2307B X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 03:24:32PM +0800, Trevor Wu wrote: > Add required properties "resets" and "reset_names", which are used to > specify audiosys hw reset for mt8195 afe driver. The subject needs to be more specific and indicate this applies to ASoC and mt8195-afe-pcm. Try to write subjects that could only ever appear once as you can never make the same change twice. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A1CC433EF for ; Thu, 10 Mar 2022 22:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbiCJWNj (ORCPT ); Thu, 10 Mar 2022 17:13:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343995AbiCJWNi (ORCPT ); Thu, 10 Mar 2022 17:13:38 -0500 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5962DFB; Thu, 10 Mar 2022 14:12:33 -0800 (PST) Received: by mail-oi1-f178.google.com with SMTP id o83so2441oif.0; Thu, 10 Mar 2022 14:12:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=omjoz0M9biHPr5EKrbgbc5QfautyWsC0HyZJaIjRDEg=; b=X7GYqySPrMybM2edaDOQg6w5BlZ4iKFQyUoYrAIU7nNp3ipMAYq/4b6Ot1e6yuwZtd VtAxqOyUY0Wm4aAD/KXfcCDpovUcnuHT7trlywzq3VgJqJAfGn9RhwQJPxg4GAh74Yby NvRxRqvoQ9e0F1zy8p2najFsNLLlrHvALF1OQbPAHyjOXW8jkWlEwq3LjtaOlu9lnk5Z 0a6ptiOz5wifrk3+btkK6aHYIjJUwTMdBoP3rFS7IvDN546n5TYOJaZ8OaIlHfnB1l+Z FUngKREGoBFnZWZ1bJKj9t9FRgDAklU/1bnfAaxHTrNuhUS3J00Hx9uE9BSTj50HsY7I StVQ== X-Gm-Message-State: AOAM533KrarHS3fgEtxRslyDTPHwXJgbzQEbVe/hVb2xrnj07P8D/uFD gcuPUMJ8//kh+xE0uBLcIw== X-Google-Smtp-Source: ABdhPJxHna6A8giuUalT7X77knNuIyLF0eFu5RYM8FUTp80V2T9F0GnnEXgbqAyoeBJg75biyF6+tw== X-Received: by 2002:a05:6808:1528:b0:2da:7f1d:f847 with SMTP id u40-20020a056808152800b002da7f1df847mr1796358oiw.85.1646950353167; Thu, 10 Mar 2022 14:12:33 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c14-20020a056870b28e00b000d7d5962242sm2821551oao.35.2022.03.10.14.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:12:32 -0800 (PST) Received: (nullmailer pid 2175473 invoked by uid 1000); Thu, 10 Mar 2022 22:12:31 -0000 Date: Thu, 10 Mar 2022 16:12:31 -0600 From: Rob Herring To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, yc.hung@mediatek.com Subject: Re: [PATCH 2/5] dt-bindings: mediatek: mt8195: add reset property Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308072435.22460-3-trevor.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 08, 2022 at 03:24:32PM +0800, Trevor Wu wrote: > Add required properties "resets" and "reset_names", which are used to > specify audiosys hw reset for mt8195 afe driver. The subject needs to be more specific and indicate this applies to ASoC and mt8195-afe-pcm. Try to write subjects that could only ever appear once as you can never make the same change twice. Rob